From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3593F15AE0 for ; Sat, 20 Jul 2024 07:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721458999; cv=none; b=oFlZ/RquWL0oe+3Tu2B/uGLkzOa4X29To8i4b6leAKtLNEX1UUPe9dutG+lXcz0qGpJIkYgpgEvEEhfDbkqVEA+vLw5ZzvoiUJab+BZvGKS8hrBnckchHol3dtCXWz3Wzzy7KvBbIZt9m95CHhGgX0wgHMOAyf1eQ2TjS2aS4HA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721458999; c=relaxed/simple; bh=1d4rj1ENyT2bE7yRVA3GEiplBLH4UjpvL5h5t1+rrxo=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=Xr06/Pg3/fguV1lud/ec19nLur34szm8oifnr1I951x0cnNhODT3wh25+rDYjJsmI9+jrrQBucIEqQiT9QGkATjaobxISbW8V/HLi20FF7oisurGyKMak1RaPXVyYq4AWCdExhKrKJQGaqmy0x4bpKtKUir86sBTVIfXbex0s7A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=BWouzIlP; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="BWouzIlP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1721458985; x=1722063785; i=markus.elfring@web.de; bh=1d4rj1ENyT2bE7yRVA3GEiplBLH4UjpvL5h5t1+rrxo=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=BWouzIlPeq87F7WCF9/+ASx0EnDi9C3aJTt38NAQmOwgDj09i4rkQ2QCsWq66In0 +3S1cKWB5yEMLDzQVretIBxMe1BIo7AszE10TfvB7vUg5/7IJe700cIqev65GoAFs Wjv3J2yg+PCpKmcgMEY4CT9Tb+i216jYbs6AbJ2O9TUE2f66BO2lzDoMEbru63VHp AOMPdxwwCNx9u1ITCE0ZBvtBDPrWA+pdz2dDhBNqm75+s5jMIJBqeO5uRNTgfWCOS algHj/gem+jvQHL3/EUP6t+/P4+HIBq7kmlKCaqyYoLEVjppRPiNuVYX5GxVKtUCJ w9CMSa4mdahsk4+Cog== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.89.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Ma0Pm-1ss5BF0Dsi-00WHCF; Sat, 20 Jul 2024 09:03:05 +0200 Message-ID: Date: Sat, 20 Jul 2024 09:03:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: George Yang , Lizhi Hou , Min Ma , Narendra Gutta , dri-devel@lists.freedesktop.org, Oded Gabbay Cc: LKML , Max Zhen , Sonal Santan References: <20240719175128.2257677-2-lizhi.hou@amd.com> Subject: Re: [PATCH 01/10] accel/amdxdna: Add a new driver for AMD AI Engine Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240719175128.2257677-2-lizhi.hou@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Nj8xCOuGKQDF5HRs1OkgnCh0D2KadxhyvD5PueweTe8eLSCtTyz 5R0K2KI3rpa3H4JKkzDFi1IkLRZrOt73DLgjElGZe5kFoLJesuFrP+tV+70StpCf59Rtkqd raP1OK24w5ZwZt+TkuKSWtijfIoOrLE433/08n7WKSmwFbfzaoblFUHzlt7lNwGv0fZr5yt Giv4I7cQHJ7ZsHIujkIpg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:cWiOIh88dwM=;qRaFtUxJO3Cur7t1GgjTJCq5Gis MFQAkdwzK9VvmSJCg203JfGdp9OvclCIJQze7Qx29UduMDUN4DhheM/BPj5WW9EbVKqB4h3jZ lXBRVmx7+xT98LYEh369k7zLqzy8c5HzwDdUBGjcmdh4jOEaCNp1eSpGiSbQfw4pttdBMUVoF fbXk0ng1ZYwGMXNqTl3oeNqYpvUey/f0pBGRwsf8rEr7CFjvigRV4+R32w0m85Pj9GKJTaNzg WqxbaCZ5PT5K/9CZRMrx7DLuyYoer3oBpFd12ZqgqnbFGmpSzbJ4ztUmnMZjpfqm+QUF02Q6+ sit3wWDDmwXKujMda5hgqtRX45knBRRLH5VCIpm//XEJySfteGDS4GjLUui1607Ld0xNz0V2c 3jRenHDXAYr1Dv8rqRh9nYavE6d6wnzQC4d1904e3ZNW1ORvQse08KvDuXJdF55ThG76IIpjC lU7z/L8q6N5D2CUN2DjtrsC3x4Tx+U6pXXmJljeYCsmi8G3XjGLEDR3SB04+mXhb3PyruAJQN /YQkw+tNNPGjIkTgpltCMAaKcrPHS1ZlJbd1lnbNlH7l4oZUAeAxeVgglokzWSl1fUe7yJj2b 6KpaAplvLtOAi9XFkZo4dgl6+BAbrk96xoG8iOEl4ZOLwAaw4ulLs4k02ZOcP7AScF2Ec5WWS AuEKAyBfUkiXbOGVcz6HIQirBAt/3qePKwOa6VXdZdTB7BqhMIu6nL3qdMJw5NWW4qRLkyUQA cZY6pwyWEw4fQeWUpf4YMJof8Pnp/iWOE25NMub3JjNRTpDJtDmr0BcPkKZxZOXJhS9pBbGiX +6gO/e/WYK3jLq+VN8eXvWGA== =E2=80=A6 > +++ b/drivers/accel/amdxdna/aie2_pci.h > @@ -0,0 +1,144 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2023-2024, Advanced Micro Devices, Inc. > + */ > + > +#ifndef _AIE2_PCI_H_ > +#define _AIE2_PCI_H_ =E2=80=A6 Please omit leading underscores from such identifiers. https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+d= efine+a+reserved+identifier Regards, Markus