From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35A4B32AAA0 for ; Fri, 6 Feb 2026 11:02:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770375749; cv=none; b=lDiTsyhEl7/QRzYjq4KyPkSVDZTWwFXiM+F1bblhRstOQrmdTB03h1f508SSJqyrXHENs7DGN7XdRgI4qLKQKspFfKvh0z10OEjPK7GXeg52eE1KngSHQ2+jYRpK+lKw0icGu4qoEwZOL7YPWzyp250tf9m3fLb79YZq+DjmMpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770375749; c=relaxed/simple; bh=kyjXQqXLEakUK4oJZzFyuNQhsJPPYK378hu0aq6KMl0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lgh+9IKYOGcameWyk+CMoId/xEZQCvwt95bVMFqEU6vJc5/t0jAnI2GvR+iXQY9ClwKkLO29lzs62C3uru891M4Vpbkw/7cGUaGRjrgwOvPOx+4uH0ANEwYT+u3ZmnGgeVFy74KZL8VlqqSm/6fCE1uAOKZCcjJHUfZF4duwhcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ro4G1eX6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YbZ6y2zK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ro4G1eX6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YbZ6y2zK" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6167bSSP4041882 for ; Fri, 6 Feb 2026 11:02:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lPVn62jF1j24nBmpNMUx9tZxl1Kn8T7Lu7In2hZBSRU=; b=Ro4G1eX6rvt/VmTL pB11j8gnkFz42qz3SClpAm6YIWmxd10fZfpRMjhzd1eQ225/PaRB42K8uWxRMgd5 ZbdKtEjjtBQk0lklwcePXkIxIlTgKqVmVID6frEGxek6YHv1bBGxqVorBW7pL8HI +vz43LZGFeztPZ5wq73HH2zj5CM/9YlDQeaS0zYVcvRbi1MbNHCuvR93wlBtJ5m7 X7E0uzM9CKrwyXCI5xsbAsZ2xZovRwTLqjr+IWb61C/Mm30Hl629kV4acAlgoQtK Yj0vg/mXTvAPcwWK2x+1xYGXpFTsiLOrMFIIcLQkqRh1ymjPoMwlf8yNOvGx3zLF BwcG9A== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5c2w0pbb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 11:02:28 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-948ad08958eso378087241.2 for ; Fri, 06 Feb 2026 03:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770375747; x=1770980547; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lPVn62jF1j24nBmpNMUx9tZxl1Kn8T7Lu7In2hZBSRU=; b=YbZ6y2zKBQRuedZRE5IdvXVaI2hMfToDyyqUDWZBQtx4MFlVB3thhjjl4FqurLerbA beG2Qt+DyH4anC+e/13XbEmq6vBclXJJwdf/oH2eoT/bzD/4QDv8gZ3uIa7lgXqBEb8W ZHe/0YVFNh8OshdfSkWc1Lg+NUwiDBhz14L2SkPtAhbQDMz/5infbI7uZSx0spIy1FYc iFzl+3wro5ETKPadVVQHtzo1w99fX5H6y1TimUgC6p9D+NSpYMWzPta2r03QNw6ihr7A 07UzWKR+h89GE9nlTnsMkYsAc+wwVScKMDyFlVZ0hmDYWHTbenEffKNZriTxpo1SFwsp +SOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770375747; x=1770980547; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lPVn62jF1j24nBmpNMUx9tZxl1Kn8T7Lu7In2hZBSRU=; b=TUtSTYO9+QS6VcAZ7YEwKlo/1gecsSzwdFW6qRq2gM+D9w/rZDHIilH2DXzmLgzkau w1BedBGljCUeRX4KMB/5XUYUdKR+qpHVAizmwADZ/9GNR4RB0YI5zh69wxksQnoFzgcS fufbouuG7/te1gE8fqGKpORKvi00zAlct3pwQw+r5tB1bpdNyrakqaLvnqtX7vlYGjNa TsEYR3nxSd0dlLI62lI6MG6AFlHBvP+jqii2a8ig3rfa8a9slcuF4ZN597l4kwFiXYUS jFQwJTu/9jbzwnPALObqNGOkL3WhxMJ/6WbAk2dEVIVeRk+krJBl8SagcdrlpZ19IoxG Yihw== X-Forwarded-Encrypted: i=1; AJvYcCVErSo1svZTOEjxJIM6ssl5EC3dBqZ1sl2e/VqLqn/R0BH2FWzihML4Jya1WbpaJbXE6hgsP9rqydFs/pw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+EplvI4RV/+asXRZrZZ/eDxLUfCIuWSn6tJyFDOBqmX77J3HD VUWESk2cSr/kI+zE6CoPCHfBconYfnrCdtU1txc3LX/bvAR6+xVOg7YxqSTobLGXyNEgSbjAs1B bjeRBbx+e1V3LRAbE00oxF2UL+ccWR6sXZ173AWTiYxvtvGAe6NHXgjE38jAOThBuyL4= X-Gm-Gg: AZuq6aJAquiXlOKPInJByYmoMhcsNMMoLXfda+QsrhyR6Su33pMJCVQnN1L9cEWnjvb cxG+/y3rCMblQ2tNZZLQL/merRiqJpfBNP8YN8wPoaKJe2XADNIg5nWxGufJ1H/3dYQkpF2A6wh QxAXiYf4vOH+CwSgm4qcaskUYr1baCyN78noF6ekGpaDCEKBVIhuiDMBmfG/wsBBM6ZS2SutF39 10ymSeOVsxBVCOevDzpGOaDwnSLtl+HyI6JxF+eHgNteT6+MsCJNAhiAFM5cPrc5sPTFvUIrTG7 5iH32lF5MMtMmoj4mcrJKZwhuL9w++89JA3rZ26QtROV6nKPpz/gdYh7HvVf+4/mYUvbIO9M7GH MpHT2QAicLiTQSbfB7YdXLgd+4+Mk04vmm00rzGdfRXtLKVGtVeHF5NZpRN5vT4L7bk4= X-Received: by 2002:a05:6123:5d2:20b0:566:221b:c68e with SMTP id 71dfb90a1353d-56705eac59emr291753e0c.1.1770375747202; Fri, 06 Feb 2026 03:02:27 -0800 (PST) X-Received: by 2002:a05:6123:5d2:20b0:566:221b:c68e with SMTP id 71dfb90a1353d-56705eac59emr291749e0c.1.1770375746797; Fri, 06 Feb 2026 03:02:26 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8edae3c255sm72414766b.62.2026.02.06.03.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Feb 2026 03:02:26 -0800 (PST) Message-ID: Date: Fri, 6 Feb 2026 12:02:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support To: Yongxing Mou , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-3-231882bbf3f1@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260205-edp_phy-v1-3-231882bbf3f1@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDA3NiBTYWx0ZWRfX5+iEHc2oHHDX qUZsIJcuGbaIWxrk5BHNXRHIzSqHGJAH0HUZdweeV2POknGzTe7D0UOCUpjlMwwOxZ0M7IzHJmS bDFOXR9aYY4A6webDRa73qen/NzIaF4Rjg/IWKEIrJk87VZ91jVUXrW63PpcAuvavQONyYt8/Jp AlSVy0F5rXtTVBBx/PGcRjKBDZ/vF7GDWx5FUKjp1MfvZYSX3IPtvgxv/yhvMV7odN/VVDULVBS 5DxwPWTT+iKw0gvnqVkjIk+FhQLYFMlcIcy2hYiEj8zMHatUBXTeITjsrN3DypLJHzwQAIDq7Lx nSuOkOVJIeeA0gtdsBnFy8erNwynvCn7sWQ+HCaTCqrw/r6CF9Hb0KlynhmwwCPM9nXlSpq6g/I kcZ9kKKBGfvhfHmPFeMtLA8spyyNrN6lpN57IUUMivacNOwTY3Wb7Q1fLee56OVVUOLDZ4K2TgN MaxnBlkONY/lTz3GjJQ== X-Authority-Analysis: v=2.4 cv=Wtom8Nfv c=1 sm=1 tr=0 ts=6985ca44 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=aJhC5vt3dY1r1Tj9l4IA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-GUID: IDDjKlaA0GVK-hvPyxGOU2fuUfoi7RMt X-Proofpoint-ORIG-GUID: IDDjKlaA0GVK-hvPyxGOU2fuUfoi7RMt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_03,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060076 On 2/5/26 10:20 AM, Yongxing Mou wrote: > Add DP/eDP switch support by splitting the PHY swing/pre-emphasis tables > into separate DP and eDP configurations. This allows the driver to select > the correct table based on the is_edp flag. > > Add a dedicated table for the SC7280/glymur platforms, as they are not > compatible with the others. > > Signed-off-by: Yongxing Mou > --- [...] > +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = { > + { 0x0b, 0x11, 0x16, 0x1b }, > + { 0x0b, 0x19, 0x1f, 0xff }, > + { 0x18, 0x1f, 0xff, 0xff }, > + { 0x1f, 0xff, 0xff, 0xff } > +}; > + > +static const u8 edp_pre_emp_hbr2_hbr3_v3[4][4] = { > + { 0x0c, 0x15, 0x19, 0x1e }, > + { 0x09, 0x14, 0x19, 0xff }, > + { 0x0f, 0x14, 0xff, 0xff }, > + { 0x0d, 0xff, 0xff, 0xff } > +}; This is not quite in line with docs for kodiak. Now, if you have better/newer sequences than the HPG, I'm not objecting, but please cross-check the rest of this patch I think looks fine Konrad