From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751704AbdJVPBw (ORCPT ); Sun, 22 Oct 2017 11:01:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:58948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751635AbdJVPBu (ORCPT ); Sun, 22 Oct 2017 11:01:50 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 720DC21871 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [f2fs-dev] [PATCH] f2fs: return error number for quota_write To: Jaegeuk Kim , Chao Yu Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20171012231500.19489-1-jaegeuk@kernel.org> <20171016230444.GA94030@jaegeuk-macbookpro.roam.corp.google.com> <79d07284-167a-3b12-bed3-cea138ab4eb7@kernel.org> <20171017181749.GB10794@jaegeuk-macbookpro.roam.corp.google.com> <20171019190851.GB82186@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: Date: Sun, 22 Oct 2017 23:01:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171019190851.GB82186@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/10/20 3:08, Jaegeuk Kim wrote: > On 10/18, Chao Yu wrote: >> On 2017/10/18 2:17, Jaegeuk Kim wrote: >>> On 10/17, Chao Yu wrote: >>>> >>>> >>>> On 2017/10/17 7:04, Jaegeuk Kim wrote: >>>>> On 10/16, Chao Yu wrote: >>>>>> Hi Jaegeuk, >>>>>> >>>>>> On 2017/10/13 7:15, Jaegeuk Kim wrote: >>>>>>> This patch returns an error number to quota_write in order for quota to handle >>>>>>> it correctly. >>>>>> >>>>>> We should return error number like __generic_file_write_iter, right? it >>>>>> needs to return written bytes if we have written one page or more, otherwise >>>>>> return error number feedbacked from write_begin. >>>>>> >>>>>> So how about reverting 4f31d26b0c17 ("f2fs: return wrong error number on >>>>>> f2fs_quota_write")? >>>>> >>>>> I thought like that, but realized the code change is somewhat different between >>>>> them. >>>> >>>> Hmm... main structure of codes here is copied from other file systems, is there >>>> the same problem in *_quota_write of other file systems? >>>> >>>> BTW, it looks making below judgment condition being useless. >>>> >>>> if (len == towrite) >>>> return 0; >>> >>> We need this to avoid needless inode updates. :P >> >> For err = 0 and len == towrite case, it more likes a bug of quota that passing >> 0 in @len. >> >> :(, Oh, still didn't get that why there is difference in between reverting and >> this fixing. Can you please explain more about this? > > Ah, right. Let me just revert the original patch. :) Reviewed-by: Chao Yu Thanks, > > Thanks, >