From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74715CE7B1F for ; Fri, 29 Sep 2023 09:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232979AbjI2Jhd (ORCPT ); Fri, 29 Sep 2023 05:37:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232732AbjI2Jh2 (ORCPT ); Fri, 29 Sep 2023 05:37:28 -0400 Received: from out-190.mta1.migadu.com (out-190.mta1.migadu.com [IPv6:2001:41d0:203:375::be]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED84B195 for ; Fri, 29 Sep 2023 02:37:25 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695980243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZNsHOigj0XnJbEFXDMySb2RUIiZjhex7b0xOV+U74ms=; b=pPKFzh/9h/gB7qDkTsZ83d34bfI2yuw0obRHjsfJ7NnNmRTjE4DEf8x2jJPJZ+3xt6M5Yc s2jk9/LHgH9wEd7+PvU7eyxuCWFnnLL2oO2GJP6h8ybAPRd7MPqiVWWVe7YoQWgyUbhUxy nBQO19Z/hV1iF3Ijx4WHmMuVJ6gDqvw= Date: Fri, 29 Sep 2023 17:37:13 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4 1/2] mm: pass page count and reserved to __init_single_page Content-Language: en-US To: Mike Rapoport Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, willy@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230928083302.386202-1-yajun.deng@linux.dev> <20230928083302.386202-2-yajun.deng@linux.dev> <20230929081938.GT3303@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yajun Deng In-Reply-To: <20230929081938.GT3303@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/9/29 16:19, Mike Rapoport wrote: > On Thu, Sep 28, 2023 at 04:33:01PM +0800, Yajun Deng wrote: >> Subject: mm: pass page count and reserved to __init_single_page > We add pass flags that tell __init_single_page() how to initialize page > count and PG_Reserved, I think a better subject would be: > > mm: allow optional initialization of page count and PG_reserved flag Okay. >> When we init a single page, we need to mark that page reserved when it >> is reserved. And some pages need to reset page count, such as compound >> pages. >> >> Introduce enum init_page_flags, the caller will init page count and mark >> page reserved by passing INIT_PAGE_COUNT and INIT_PAGE_RESERVED. > This does not really describe why the change is needed. How about > > __init_single_page() unconditionally resets page count which is unnecessary > for reserved pages. > > To allow skipping page count initialization and marking a page reserved in > one go add flags parameter to __init_single_page(). > > No functional changes. Okay. >> Signed-off-by: Yajun Deng >> --- >> v4: move the changes of __init_zone_device_page(). >> v3: Introduce enum init_page_flags. >> v2: Introduce INIT_PAGE_COUNT and INIT_PAGE_RESERVED. >> v1: https://lore.kernel.org/all/20230922070923.355656-1-yajun.deng@linux.dev/ >> --- >> mm/hugetlb.c | 2 +- >> mm/internal.h | 8 +++++++- >> mm/mm_init.c | 24 +++++++++++++----------- >> 3 files changed, 21 insertions(+), 13 deletions(-) >> >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c >> index a82dc37669b0..bb9c334a8392 100644 >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -3196,7 +3196,7 @@ static void __init hugetlb_folio_init_tail_vmemmap(struct folio *folio, >> for (pfn = head_pfn + start_page_number; pfn < end_pfn; pfn++) { >> struct page *page = pfn_to_page(pfn); >> >> - __init_single_page(page, pfn, zone, nid); >> + __init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT); >> prep_compound_tail((struct page *)folio, pfn - head_pfn); >> ret = page_ref_freeze(page, 1); >> VM_BUG_ON(!ret); >> diff --git a/mm/internal.h b/mm/internal.h >> index d7916f1e9e98..449891ad7fdb 100644 >> --- a/mm/internal.h >> +++ b/mm/internal.h >> @@ -1209,8 +1209,14 @@ struct vma_prepare { >> struct vm_area_struct *remove2; >> }; >> >> +enum init_page_flags { > enum page_init_flags please Okay. >> + INIT_PAGE_COUNT = (1 << 0), >> + INIT_PAGE_RESERVED = (1 << 1), >> +}; >> + >> void __meminit __init_single_page(struct page *page, unsigned long pfn, >> - unsigned long zone, int nid); >> + unsigned long zone, int nid, >> + enum init_page_flags flags); >> >> /* shrinker related functions */ >> unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, >> diff --git a/mm/mm_init.c b/mm/mm_init.c >> index 06a72c223bce..9716c8a7ade9 100644 >> --- a/mm/mm_init.c >> +++ b/mm/mm_init.c >> @@ -557,11 +557,11 @@ static void __init find_zone_movable_pfns_for_nodes(void) >> } >> >> void __meminit __init_single_page(struct page *page, unsigned long pfn, >> - unsigned long zone, int nid) >> + unsigned long zone, int nid, >> + enum init_page_flags flags) >> { >> mm_zero_struct_page(page); >> set_page_links(page, zone, nid, pfn); >> - init_page_count(page); >> page_mapcount_reset(page); >> page_cpupid_reset_last(page); >> page_kasan_tag_reset(page); >> @@ -572,6 +572,10 @@ void __meminit __init_single_page(struct page *page, unsigned long pfn, >> if (!is_highmem_idx(zone)) >> set_page_address(page, __va(pfn << PAGE_SHIFT)); >> #endif >> + if (flags & INIT_PAGE_COUNT) >> + init_page_count(page); >> + if (flags & INIT_PAGE_RESERVED) >> + __SetPageReserved(page); >> } >> >> #ifdef CONFIG_NUMA >> @@ -714,7 +718,7 @@ static void __meminit init_reserved_page(unsigned long pfn, int nid) >> if (zone_spans_pfn(zone, pfn)) >> break; >> } >> - __init_single_page(pfn_to_page(pfn), pfn, zid, nid); >> + __init_single_page(pfn_to_page(pfn), pfn, zid, nid, INIT_PAGE_COUNT); > There is __SetPageReserved call a few lines below, it can be folded here. > No, There is a #ifdef in front of it. If so, I need to add __SetPageReserved to another init_reserved_page(). And there is an return before __init_single_page. I will change INIT_PAGE_COUNT to 0 in next patch. >> } >> #else >> static inline void pgdat_set_deferred_range(pg_data_t *pgdat) {} >> @@ -821,8 +825,8 @@ static void __init init_unavailable_range(unsigned long spfn, >> pfn = pageblock_end_pfn(pfn) - 1; >> continue; >> } >> - __init_single_page(pfn_to_page(pfn), pfn, zone, node); >> - __SetPageReserved(pfn_to_page(pfn)); >> + __init_single_page(pfn_to_page(pfn), pfn, zone, node, >> + INIT_PAGE_COUNT | INIT_PAGE_RESERVED); >> pgcnt++; >> } >> >> @@ -884,7 +888,7 @@ void __meminit memmap_init_range(unsigned long size, int nid, unsigned long zone >> } >> >> page = pfn_to_page(pfn); >> - __init_single_page(page, pfn, zone, nid); >> + __init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT); >> if (context == MEMINIT_HOTPLUG) >> __SetPageReserved(page); >> >> @@ -967,9 +971,6 @@ static void __ref __init_zone_device_page(struct page *page, unsigned long pfn, >> unsigned long zone_idx, int nid, >> struct dev_pagemap *pgmap) >> { >> - >> - __init_single_page(page, pfn, zone_idx, nid); >> - >> /* >> * Mark page reserved as it will need to wait for onlining >> * phase for it to be fully associated with a zone. >> @@ -977,7 +978,8 @@ static void __ref __init_zone_device_page(struct page *page, unsigned long pfn, >> * We can use the non-atomic __set_bit operation for setting >> * the flag as we are still initializing the pages. >> */ >> - __SetPageReserved(page); >> + __init_single_page(page, pfn, zone_idx, nid, >> + INIT_PAGE_COUNT | INIT_PAGE_RESERVED); >> >> /* >> * ZONE_DEVICE pages union ->lru with a ->pgmap back pointer >> @@ -2058,7 +2060,7 @@ static unsigned long __init deferred_init_pages(struct zone *zone, >> } else { >> page++; >> } >> - __init_single_page(page, pfn, zid, nid); >> + __init_single_page(page, pfn, zid, nid, INIT_PAGE_COUNT); >> nr_pages++; >> } >> return (nr_pages); >> -- >> 2.25.1 >>