From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA66AECAAA1 for ; Tue, 30 Aug 2022 17:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232108AbiH3RmJ (ORCPT ); Tue, 30 Aug 2022 13:42:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231455AbiH3Rls (ORCPT ); Tue, 30 Aug 2022 13:41:48 -0400 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99EB7136B04 for ; Tue, 30 Aug 2022 10:39:06 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id bq23so16517712lfb.7 for ; Tue, 30 Aug 2022 10:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=e7JEKYuofd3ohVuN0wQat/Bd3pvagzYZJuquu9YnaTc=; b=sccqeAOnaZ63YsK2QiDUkPx1XiQueuhmVcEyY7D1/T3NLqy3NAh1+Rn5w6JOBChXhu ofeHiBKfVgGiNTBIcjYbaWG0bevSh3X+fk5q7sb5LCLRS+4DyYSJ+uG/vBOBiWAMmKDW jyvx+aaIJMt2iCgo44tfCGHh4nDVa8QMUy6otmtxcqjNbWx6q/0MDzbY2s7hU9faiC5X cdgbRrNnmv9X+w1NVtP+ut5y/2I9SI0LdciIfqtNo7Eop8so4Is9jCUG+1q2fBdQQcD0 D4DjZbo9t1yznxP0R1uwKzA4EyA2VIJBZJdJZy4sYf9PIhWN6ow3ixkbKogA3GvRC2QN MhHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=e7JEKYuofd3ohVuN0wQat/Bd3pvagzYZJuquu9YnaTc=; b=RJD51U5OHXqzxqiMXWZBifoJHPCORWR36uZ6CKR/6TrFyvjmcr2KvlTk5rocIX/kDc 9j9v3ehVhFUAu5s76wQMFGuBlm6DGhMq1XD9r1EO226q8CWhnTt8e4YyWhp9MeztofRv yOIOH95U//1b09wW5KDqktXtqlxH8emb1YZSCSAaWh7vFf57BXlQ/6yRvTI/Hqh7nO/9 wXOlwyldGsW/hy87liDOTMBBcvkKxwjh9IysPo3rQSyJWPIAkWVc6LvYqZ9eg3TPCKrF m4DTNYS8VOHKoYalegJ9+WaQlGsnBZ6wVnx2stejlrcC5RdzVmNo/ciuP/m2YJbQuGIW Ewqg== X-Gm-Message-State: ACgBeo3OgzdzTrGv08+x25VwkoOaan23FPMABKEJ3uVaYrmWLa9n0wL7 ZuAwKVqbITVbrrytP0H4rk1jTA== X-Google-Smtp-Source: AA6agR71Ri1C6ITQXhDL5pZbp01DKxvtr8nIL2S4m+SgX2lfZcjbi0Z3IVSXrgmMwJay7vslWOAXeg== X-Received: by 2002:a05:6512:3d1e:b0:48b:3f76:eff with SMTP id d30-20020a0565123d1e00b0048b3f760effmr8545084lfv.312.1661880765623; Tue, 30 Aug 2022 10:32:45 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id q7-20020a2eb4a7000000b00263d44b079bsm1166844ljm.99.2022.08.30.10.32.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 10:32:44 -0700 (PDT) Message-ID: Date: Tue, 30 Aug 2022 20:32:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v1 1/1] usb: phy: mxs: apply board calibration value base on chip trim value Content-Language: en-US To: Frank Li , kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, balbi@kernel.org, gregkh@linuxfoundation.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, imx@lists.linux.dev References: <20220830162538.2845274-1-Frank.Li@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220830162538.2845274-1-Frank.Li@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/08/2022 19:25, Frank Li wrote: > USBPHY_TRIM_OVERRIDE provide chip trim value. DTS provide board level > calibration data. Board level calibration data should be base on chip > trim value. > > For example, TXCAL45DP board level hope add +2.85% register base on > standard 45ohm. But chip trim value is -5.25% to get 45ohm output. > Actually finial TXCAL45DP should be -5.25% + 2.85% = -2.4%. > > If chip have not trim value at USBPHY_TRIM_OVERRIDE, No behavior change. > board level calibration will be applied. > > If chip have trim value at USBPHY_TRIM_OVERRIDE and no DTS board level > data, chip trim value will be applied. > > Signed-off-by: Frank Li > --- > drivers/usb/phy/phy-mxs-usb.c | 40 ++++++++++++++++++++++++++++++++--- > 1 file changed, 37 insertions(+), 3 deletions(-) Use scripts/get_maintainers.pl to CC all maintainers and relevant mailing lists.... and do not Cc unrelated folks. Best regards, Krzysztof