From: Suman Anna <s-anna@ti.com>
To: <santosh.shilimkar@oracle.com>,
Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
<ssantosh@kernel.org>
Cc: <lee.jones@linaro.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <praneeth@ti.com>,
<tony@atomide.com>, Wei Yongjun <weiyongjun1@huawei.com>
Subject: Re: [PATCH v2] soc: ti: pruss: Fix wrong check against *get_match_data return value
Date: Mon, 16 Nov 2020 13:11:57 -0600 [thread overview]
Message-ID: <af1ecbaf-52e5-5e8b-2b0c-ee8cfe5cb0f0@ti.com> (raw)
In-Reply-To: <528e56d5-23d5-9f83-1bf4-a7f786593eae@oracle.com>
On 11/16/20 1:06 PM, santosh.shilimkar@oracle.com wrote:
> On 11/16/20 9:31 AM, Suman Anna wrote:
>> Hi Santosh,
>>
>> On 11/16/20 11:22 AM, Grzegorz Jaszczyk wrote:
>>> Since the of_device_get_match_data() doesn't return error code, remove
>>> wrong IS_ERR test. Proper check against NULL pointer is already done
>>> later before usage: if (data && data->...).
>>>
>>> Additionally, proceeding with empty device data is valid (e.g. in case
>>> of "ti,am3356-pruss").
>>>
>>> Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX")
>>> Reported-by: Wei Yongjun <weiyongjun1@huawei.com>
>>> Signed-off-by: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
>>> Acked-by: Suman Anna <s-anna@ti.com>
>>
>> Can you please pick this up for 5.10-rc's?
>>
> Nothing is broken so I will just add these for next merge window.
Yeah, that is fine as well. Thanks Santosh.
regards
Suman
prev parent reply other threads:[~2020-11-16 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:22 Grzegorz Jaszczyk
2020-11-16 17:31 ` Suman Anna
2020-11-16 19:06 ` santosh.shilimkar
2020-11-16 19:11 ` Suman Anna [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af1ecbaf-52e5-5e8b-2b0c-ee8cfe5cb0f0@ti.com \
--to=s-anna@ti.com \
--cc=grzegorz.jaszczyk@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=praneeth@ti.com \
--cc=santosh.shilimkar@oracle.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®