From: "Arnd Bergmann" <arnd@arndb.de>
To: "Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Tomas Winkler" <tomas.winkler@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Wentong Wu" <wentong.wu@intel.com>,
"Alexander Usyskin" <alexander.usyskin@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mei: fix vsc dependency
Date: Wed, 13 Dec 2023 15:42:08 +0100 [thread overview]
Message-ID: <af1f937b-37e0-466d-ac94-4f57e086f326@app.fastmail.com> (raw)
In-Reply-To: <ZXmtqc7fTeZbRW5B@kekkonen.localdomain>
On Wed, Dec 13, 2023, at 14:12, Sakari Ailus wrote:
> On Wed, Dec 13, 2023 at 01:43:05PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The Kconfig dependency in the new module is reversed from the dependency
>> on the exported symbols, so it fails to link with CONFIG_INTEL_MEI_VSC
>> disabled and CONFIG_INTEL_MEI_VSC_HW enabled:
>> @@ -64,6 +64,7 @@ config INTEL_MEI_VSC_HW
>> tristate "Intel visual sensing controller device transport driver"
>> depends on ACPI && SPI
>> depends on GPIOLIB || COMPILE_TEST
>> + depends on INTEL_MEI_VSC
>
> Oops. The dependency indeed seems to have been reversed.
>
> Could you also reorder the entries so the one that depends on the other
> would be below?
Update: I actually misread the code and the original dependency
appears to have been correct. Instead there is a different bug,
so I'll send a new patch after I have done enough testing on
the new version.
Armd
prev parent reply other threads:[~2023-12-13 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 12:43 Arnd Bergmann
2023-12-13 13:12 ` Sakari Ailus
2023-12-13 14:42 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af1f937b-37e0-466d-ac94-4f57e086f326@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexander.usyskin@intel.com \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomas.winkler@intel.com \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®