From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F2CC433F5 for ; Mon, 14 Feb 2022 21:35:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbiBNVfS (ORCPT ); Mon, 14 Feb 2022 16:35:18 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbiBNVe7 (ORCPT ); Mon, 14 Feb 2022 16:34:59 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85A5315720F for ; Mon, 14 Feb 2022 13:32:13 -0800 (PST) Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 397B7407BD for ; Mon, 14 Feb 2022 21:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1644874332; bh=Vpk09spyV9imDGj1kfUzd1GTJIyfhaN7DgNwXJd/bD0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e60NqLzyZV697QIjr9gD8+zn8IrsHL1ZzR6zifawktptCcEAwwDezFbPv/rcvfegL YHjZz6Dw8tLgtclLzCOSJqnt30ciTOGqIiNVlF3DF1Fx+sNCDy7y6DK6zASXPn59Rq UDJ9x3W+rG1I8PtUxFafBIt/A3N/rqOtVA1uD2gADBmCSY4UFBp8/nWHPGR3f+KrBQ /vcskUVtn82dBXNBbURNNUi2AOna799rPxsKglqCdd2DLbzEAkT2H8ZfpZ0f6vDzEd zyKBiOVn49p1jweSKCySzJNzypXS30DfRy6i9RGaMkoLQjv7g5pjyQnfn4D5+JL0Q1 zgCEro8Lz4MvQ== Received: by mail-ej1-f71.google.com with SMTP id qa30-20020a170907869e00b006cee5e080easo1349506ejc.3 for ; Mon, 14 Feb 2022 13:32:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Vpk09spyV9imDGj1kfUzd1GTJIyfhaN7DgNwXJd/bD0=; b=gn26s9Yl0rjVCxxNI5Kd3p0J+W0KNDIFkWg0io7257KfXnkwBhnqijaXXpvj6PJiyk CgJwRFeAPVsp30Zer3jR36w1eX52xAt+7KWf/i3D6dTgHAtTrIpJ2nMOQgFqJZM2ogo0 6M31OTdhGbMQHX4hwVbpkxgaTPUGn8DzsVPCSEhpGQJzzTzx8VciV2q8bRiK2vX0n2SG K8+l+mV+vP0R+iroeOEztkmw6nAaUWR7n/hjAC/tGtDra17uJh7Cl42+MsHNTSKCiNWZ dAv7U1BiJbYEbOPqfl3flOghOtJBvSVKBgjH0f3Ngj7da9qwX88PLaMUD+X2QY03LXf4 8hgA== X-Gm-Message-State: AOAM5329DpSQaqNB0hnryuifxQxsaNALXQ7Vr1t1lk9DW1ASUvY0aC2G klgaH6RNRrg1xTA1QwJ7Te5OKjzLW/ThU9fwNyz+TTsUKvWTPidHBcI94EQWSMlDM/SCM4ScJCl 9xYrEiiAyzU5KB773lAl3V388Njp6IdxSwSTRV5+TyA== X-Received: by 2002:a17:907:9687:: with SMTP id hd7mr561411ejc.715.1644874331561; Mon, 14 Feb 2022 13:32:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqnjThzRbcUFM+c4bi7NwvMvdAFVVUVTZmoKvJUlbWhdI51H+3uTCCB+/iNFrzs2cm1lQjfg== X-Received: by 2002:a17:907:9687:: with SMTP id hd7mr561405ejc.715.1644874331369; Mon, 14 Feb 2022 13:32:11 -0800 (PST) Received: from [192.168.0.106] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id h11sm3910302edb.68.2022.02.14.13.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Feb 2022 13:32:10 -0800 (PST) Message-ID: Date: Mon, 14 Feb 2022 22:32:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [1/1] dt-bindings: pwm:Convert pwm-mtk-disp.txt format file to pwm-mtk-disp.yaml format file Content-Language: en-US To: xinlei.lee@mediatek.com, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <1644847276-27622-1-git-send-email-xinlei.lee@mediatek.com> <1644847276-27622-2-git-send-email-xinlei.lee@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <1644847276-27622-2-git-send-email-xinlei.lee@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2022 15:01, xinlei.lee@mediatek.com wrote: > From: xinlei lee Commit msg is needed. Subject - missing space after ':' and it is too long. No need to say "format file" twice. You miss "PATCH" in subject. Using `git format-patch` is the easiest way to create proper patches. > > Signed-off-by: xinlei lee > --- > .../devicetree/bindings/pwm/pwm-mtk-disp.yaml | 60 ++++++++++++++++++++++ > 1 file changed, 60 insertions(+) I do not see the conversion here... You only add one file. Where is the removal? > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.yaml b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.yaml > new file mode 100644 > index 0000000..2f1183e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.yaml Let's name the file as with most bindings, so with vendor: "mediatek,pwm-disp.yaml" > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/pwm-mtk-disp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: mediatek PWM Controller Device Tree Bindings > + > +maintainers: > + - Thierry Reding > + - Uwe Kleine-König > + - Lee Jones > + - Rob Herring > + allOf referencing pwm.yaml > +properties: > + compatible: > + enum: > + - mediatek,mt2701-disp-pwm > + - mediatek,mt6595-disp-pwm > + - mediatek,mt8173-disp-pwm > + - mediatek,mt8183-disp-pwm > + - mediatek,mt8186-disp-pwm > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Main Clock > + - description: Mm Clock > + This schema was not tested. Please run it against your DTS files (make dtbs_check). You need pwm-cells and power-domains. Maybe more... > + clock-names: > + items: > + - const: main > + - const: mm Blank line. > +required: "compatible" is required, put it first in the list. > + - reg > + - interrupts > + - clocks > + - clock-names> + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include Blank line. > + disp_pwm: disp_pwm0@1100e000 { node name: "pwm" (generic as schema and devicetree specification ask for). > + compatible = "mediatek,mt8183-disp-pwm"; > + reg = <0x1100e000 0x1000>; > + interrupts = ; > + clocks = <&topckgen CLK_TOP_DISP_PWM>, > + <&infracfg_ao CLK_INFRA_AO_DISP_PWM>; > + clock-names = "main", "mm"; > + status = "okay"; No need for status. > + }; > \ No newline at end of file Best regards, Krzysztof