From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBotfJQz2W+Vw7fQ1ygOJB22+E0dJ/zJ2kE6lWVoQ7nQWM33jXfSxLCKcDemal5uym1eb3kC7 ARC-Seal: i=1; a=rsa-sha256; t=1516322027; cv=none; d=google.com; s=arc-20160816; b=RqDt4FfM5mbNfqsNzHOMvEr6Z4VfJecFEcpdXSO6CFz1h9veIOBVk/6CLvardIuQAP g6l8vsV/gRu2aeRD+k1P6812RvVbznpnJ+NKscr4uPn1KHrw8KF8u8YKL0taUFlv1fhL VyEvD5bu1Xoes5uAaY0cbCOLxcWLABzPgARZmhkyf3ZFq6b/aiJX1q7knMaNGw2gHui0 CzDECNaAP7yL9m61vHV8nVzSbORuJ9qg6an7383P6EGIqfxBPPGX20UEzcPMUoeQZRQG lsvad40DEWUYgx8fjUm8ZP3/H3mBuM1WuqkaRVrLwWHOv3dD41U0ZQp5MmhIKbayXjyb N1OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:reply-to :arc-authentication-results; bh=26OoY+IJOdRYg46It1Ek59wjEW518NjwVyJuDLcVz5k=; b=D5cn1VmmSUIexwCaj9RDI6B3OBqt6iJmyOrS20I270JcaskcU3dbq/Gj0GHCxcOBQl mmNAQTSEZ4R+N3XF3iwwmhzIk4vtaDlQbTf1fSsCf39NLoWuOyHdKYQ1wTp2gaQlEOLe 2qrj8ZGwO80wMBIQjo0nF7Fk/HAg/696n8GntFtEU39kMaU2K+HiY0H5oBhkz6pNOysI OQWtskS5SRK6fQt7NForLfrBJZCGM8mVDw++b0UJACJQflMGqpyGecQqcuoKYRGQ8HwT tdFxq8dZbmz19sF3jC6Ur3DIPdF6xtyXluIv5C8F3XX6rvSTPu9TV/HPAmapvtz4d0Nt EEGw== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 64.68.200.34 is neither permitted nor denied by best guess record for domain of shuah@kernel.org) smtp.mailfrom=shuah@kernel.org Authentication-Results: mx.google.com; spf=neutral (google.com: 64.68.200.34 is neither permitted nor denied by best guess record for domain of shuah@kernel.org) smtp.mailfrom=shuah@kernel.org Reply-To: shuah@kernel.org Subject: Re: [PATCHv2] selftests/x86: Add {,_32,_64} targets To: Dmitry Safonov , linux-kernel@vger.kernel.org Cc: 0x7f454c46@gmail.com, Ingo Molnar , Andy Lutomirski , Greg Kroah-Hartman , Thomas Gleixner , linux-kselftest@vger.kernel.org, x86@kernel.org, Shuah Khan References: <20180118222625.24408-1-dima@arista.com> From: Shuah Khan Message-ID: Date: Thu, 18 Jan 2018 17:33:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180118222625.24408-1-dima@arista.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589970455221827423?= X-GMAIL-MSGID: =?utf-8?q?1589978886791831546?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/18/2018 03:26 PM, Dmitry Safonov wrote: > One can only use `make all` or `make _` > as make targets. > `make ` doesn't work as Ingo noticed: > x86> make test_vsyscall > gcc -O2 -g -std=gnu99 -pthread -Wall -no-pie test_vsyscall.c -o test_vsyscall > /tmp/aBaoo3nb.o: In function `init_vdso': > test_vsyscall.c:68: undefined reference to `dlopen' > test_vsyscall.c:76: undefined reference to `dlsym' > test_vsyscall.c:80: undefined reference to `dlsym' > test_vsyscall.c:84: undefined reference to `dlsym' > test_vsyscall.c:88: undefined reference to `dlsym' > test_vsyscall.c:70: undefined reference to `dlopen' > collect2: error: ld returned 1 exit status > : recipe for target 'test_vsyscall' failed > make: *** [test_vsyscall] Error 1 > > Makefile target substitution neither works :-/ > > Generate .PHONY targets per-test and fix target substitution. > > Cc: Andy Lutomirski > Cc: Greg Kroah-Hartman > Cc: Shuah Khan > Cc: Thomas Gleixner > Cc: linux-kselftest@vger.kernel.org > Cc: x86@kernel.org > Reported-by: Ingo Molnar > Signed-off-by: Dmitry Safonov > --- > v2: collide two target lines $(1) and $(1)_{64,32} > > tools/testing/selftests/x86/Makefile | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > v2 is the right one. Thanks for taking care of this. I plan to get this into 4.16-rc1 unless there is a dependency on x86 tree. thanks, -- Shuah