From: Matthias Brugger <mbrugger@suse.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
robh+dt@kernel.org, frowand.list@gmail.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: irq: Export of_msi_get_domain
Date: Wed, 22 Jan 2020 12:03:39 +0100 [thread overview]
Message-ID: <af2d8b26-d651-6273-74ae-25a0b2fc7d0a@suse.com> (raw)
In-Reply-To: <20200122104723.16955-1-peter.ujfalusi@ti.com>
On 22/01/2020 11:47, Peter Ujfalusi wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> Export of_mis_get_domain to enable it for users from outside.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Rob, Matthias,
>
> I needed to resort to remove module build support for the new ringacc UDMA
> drivers (now they are in next-20200122) due to the fact that of_msi_get_domain()
> is not having the EXPORT_SYMBOL_GPL() which is used by both drivers.
>
> I have found this old patch in lkml, but can not see the history of why it is
> not applied.
The series it was part of was abandoned. The itself shouldn't have an issue.
Regards,
Matthias
>
> Regards,
> Peter
>
> drivers/of/irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index a296eaf52a5b..73017506ef00 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -673,6 +673,7 @@ struct irq_domain *of_msi_get_domain(struct device *dev,
>
> return NULL;
> }
> +EXPORT_SYMBOL_GPL(of_msi_get_domain);
>
> /**
> * of_msi_configure - Set the msi_domain field of a device
>
next prev parent reply other threads:[~2020-01-22 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 10:47 Peter Ujfalusi
2020-01-22 11:03 ` Matthias Brugger [this message]
2022-08-12 17:44 Kevin Hilman
2022-08-12 18:09 ` Rob Herring
2022-08-16 17:40 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2d8b26-d651-6273-74ae-25a0b2fc7d0a@suse.com \
--to=mbrugger@suse.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®