From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43E9FC433F5 for ; Mon, 16 May 2022 09:59:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232099AbiEPJ7A (ORCPT ); Mon, 16 May 2022 05:59:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231435AbiEPJ65 (ORCPT ); Mon, 16 May 2022 05:58:57 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5485B21BD for ; Mon, 16 May 2022 02:58:53 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id k30so7058230wrd.5 for ; Mon, 16 May 2022 02:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=awMikNuwzVLC+pmZZU3cfGp/NS4iflwUhbb4vdr1BwU=; b=TGkJGxkuZAfVOWbjyHTHXuRlzDFJ/R/VFXCAEzftXtlyUp9DvQKtq6YhoD14PyEI5f YQxuyM/gkfWDE18Jwy5tcdp+9E6kGKsAQS4D5yUI3k1eSSdwPxs0fOUtpmCNqUiRyHNd xPm5qxLUKT7QFJ+UmxHZ44NYuFIrLD4jgj9TtbZBuanEzqkfRA5So8Ri/69zGst1OjAN Bnx1VTUKSiZVNcL0bEjj1/vAgrLQVdr++gN2Uz3hI1MBUv6QesxshBj020Lg4TA0XDMm PB2VtQgKAcDKmP7AZLIsjnDpVM1fjopxboadRalpbuQXarNcdhast8vJT4uS6YOeFbQN Vogw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=awMikNuwzVLC+pmZZU3cfGp/NS4iflwUhbb4vdr1BwU=; b=Tjc38AesvqfGu8pSlTpXloZiTfozs1Pah0ft8JSXDJTNgzjlypE/SInwU7ZmMJ8u1W r2qHQmMSN8FzwzDg54w6EPLGvV3Roor/0+0vO4Tn8h0Fd/FEBsICS7DUNMAwqgdNeqGq rr1XcAPH+BmdOKVZydLmKKNgbXSlMXp1R2OKTdoDWaj6LVOb73UBpzjEpPnRHE8bAANG Ox83zX99BRTs7qfqKgpgEqI87nvxMzDr4hHGLXooc6aopdgTZqJ62NmAs1fqtjSfG9KZ FlW3m4qQce17qYgH1ZsLZCwOWFWF++dUZaB333Us8tNGYnNcD9q9qjDoEJ+WEIe1kWlf eiXg== X-Gm-Message-State: AOAM5306CqtCQFoo2xn3A6eF2IdRBV4EAMtWpEa3OuWcfuxY/tMQ6r9d RQkVgZhe2BT1kM3ou82hKX3o7g== X-Google-Smtp-Source: ABdhPJxKlfFTUQWpLCHDwKBtfdXNaL6242t1PprpAeei/WKMmBWjox0VQEBz/nuIn6pjuYl3HMJ2sg== X-Received: by 2002:a05:6000:1acd:b0:20c:7201:9267 with SMTP id i13-20020a0560001acd00b0020c72019267mr13455532wry.41.1652695131910; Mon, 16 May 2022 02:58:51 -0700 (PDT) Received: from ?IPV6:2a01:e34:ed2f:f020:b464:e524:6a1d:33d0? ([2a01:e34:ed2f:f020:b464:e524:6a1d:33d0]) by smtp.googlemail.com with ESMTPSA id g9-20020adfbc89000000b0020c5253d909sm9676582wrh.85.2022.05.16.02.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 May 2022 02:58:51 -0700 (PDT) Message-ID: Date: Mon, 16 May 2022 11:58:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] thermal: imx_sc_thermal: Fix refcount leak in imx_sc_thermal_probe Content-Language: en-US To: Miaoqian Lin , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Anson Huang , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220516073151.25918-1-linmq006@gmail.com> From: Daniel Lezcano In-Reply-To: <20220516073151.25918-1-linmq006@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/05/2022 09:31, Miaoqian Lin wrote: > of_find_node_by_name() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: e20db70dba1c ("thermal: imx_sc: add i.MX system controller thermal support") > Signed-off-by: Miaoqian Lin > --- > drivers/thermal/imx_sc_thermal.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_thermal.c > index 8d76dbfde6a9..1ab854c228e5 100644 > --- a/drivers/thermal/imx_sc_thermal.c > +++ b/drivers/thermal/imx_sc_thermal.c > @@ -95,6 +95,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) > if (!sensor) { > of_node_put(child); > of_node_put(sensor_np); > + of_node_put(np); > return -ENOMEM; > } Please use goto statement > @@ -125,6 +126,7 @@ static int imx_sc_thermal_probe(struct platform_device *pdev) > } > > of_node_put(sensor_np); > + of_node_put(np); > > return ret; > } -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog