From: Markus Elfring <Markus.Elfring@web.de>
To: Herbert Xu <herbert@gondor.apana.org.au>, linux-crypto@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: rng - Combine two seq_printf() calls into one in crypto_rng_show()
Date: Wed, 19 Nov 2025 11:16:22 +0100 [thread overview]
Message-ID: <af38ab0e-79b8-432d-a923-16d2af129154@web.de> (raw)
In-Reply-To: <aR1LcMOO0B6qUdOX@gondor.apana.org.au>
…>> +++ b/crypto/rng.c
>> @@ -81,8 +81,7 @@ static void crypto_rng_show(struct seq_file *m, struct crypto_alg *alg)
>> __maybe_unused;
>> static void crypto_rng_show(struct seq_file *m, struct crypto_alg *alg)
>> {
>> - seq_printf(m, "type : rng\n");
>> - seq_printf(m, "seedsize : %u\n", seedsize(alg));
>> + seq_printf(m, "type : rng\nseedsize : %u\n", seedsize(alg));
>
> This makes the code look worse and appears to be an optimisation
> that isn't really needed.
Would you expect to specify still two string literals at such a source code place?
Regards,
Markus
prev parent reply other threads:[~2025-11-19 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 15:56 Markus Elfring
2025-11-19 4:45 ` Herbert Xu
2025-11-19 10:16 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af38ab0e-79b8-432d-a923-16d2af129154@web.de \
--to=markus.elfring@web.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®