From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 708AB374170 for ; Thu, 25 Jun 2026 07:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782373899; cv=none; b=FNQpOBrGU991Ql76ULo76892QKe/WguqyGKx+lub6LvX3Dens5fOuE4jhL/mF9Eli5YgTFrDWYV8noEq2cAx4FjpO3SiY/TY7VvQqmUfyCcJDWo2sM3cTzE6kWzHwAwKYW8eMv5Wrj8oiIqKFHFNz80YWSYtbUsPDFjc2HABPJE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782373899; c=relaxed/simple; bh=IhddJ8wJua/m+ug2p6DPU/19D/1A9Q5EUbXR5cH3xDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QoRKIchF96F3Oq3E/wv9nXPM+7eDdH5gfjLaSAiBu8pm3pxqZFUBreN8FnMs+3diXFY/prhv/Zlbc2PDOZutLY2peZhWuLbnihDGaVkTkVO2y0TqN1wp5dNJN1X1VJcd04TMv3Ng4HIK0sPrZGKCcS0VsJ0PfDrDEfcPc2PTU5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A6UJJ4mc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K7uRlQAC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A6UJJ4mc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K7uRlQAC" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P6hKmd1528043 for ; Thu, 25 Jun 2026 07:51:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7LTkSUI+YJToHS8a4HwcpVIMbbMkUqrCKJ7kdKLzNKU=; b=A6UJJ4mcHbqUjDYf Eov29aBmQqnUI2JQSICLlh0i0+MV00o7JJvg9xvz5n1S6+aG7QBrZz41TdGOc/uF bJ4kdfCziNq1+LH5/CfpAihwd0FUY3CzWG3ECu76F5EckGc93d4Zn/uzRhvTE3Uj 8w74YPmuvmcqRpXwzBjdSPkJ0KXQFVb0BN8azOgT9Fud6GRbLEjarsrS0esqTu3v qiY2Cmy862MhkpMmk+GkSzse58g+tIT4Qu4rt9PgOHHRyRCCLHRnlwQ5l90uRzGR 5KM75Lw3bPNwe1Ki2vS3GvAu4iqTtWeKYmYI2EuHX3ixxnIS/u9EqNGdNOkWopr/ AZwVLw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0ya8r8d2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 07:51:35 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9214bfa3b98so325617785a.0 for ; Thu, 25 Jun 2026 00:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782373895; x=1782978695; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7LTkSUI+YJToHS8a4HwcpVIMbbMkUqrCKJ7kdKLzNKU=; b=K7uRlQAC/ikvfan9mqqZUR34aLjwV0HLiIZIVI/aMmxcxrl5xiqNGWuNQNN6OhK5PM Be6FSHrKJs3a/miPD5noQBovGRrrdikJWZMuTFZsTYL0QR6fH+Ba3VeuDr1bXx97IkTh 7/+BnE2LlSPvEZ6w0bQyKxaBa0EbJWknLE71lIYrQn6cGTE65IQZctaN1eVqO6GMzpEq evi077Q75vDtnmxsNXsyKEzRETqAKhKy66o/Vkub8VktpnqieNtxMDNCMe6gbhpwYbih mClxu5mydYimYOVspdeWMuPZsJue7T2CzcjRFS4W/Jj11fEPFR1c16ZgnpQWmi5IXObE A1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782373895; x=1782978695; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7LTkSUI+YJToHS8a4HwcpVIMbbMkUqrCKJ7kdKLzNKU=; b=ga8jSrXasKPjBu8LH+5hTts277ozMkIfrFtbikEgEn6K+p5a5/kV5zLatVGhM7pfFn a0AG3OgfHqv/sdoH+iLLlQ0XGXWX3XXgScCNgl3w7rrf2/qD9G6FbCbUjS6h0Lz095pA HhMgWKLP61a7ut+CdIleU6xNHyugmTx0inv3QQLhIcGxYl6aAf1xnbfLpnUsn6tx68Ke qWcngn9EaOns/SWG/MMO8D0hHNUMAb33N5+okbJPndYx2zun5l3pCNT20RItHM0i7ttO OKRSVTmYb9NL+6Q4C/o9s0GVTOWqzhreN+oT0NpzPTAoA/PvChf8IiOpDRj5PvwtWCQp m+eA== X-Forwarded-Encrypted: i=1; AFNElJ94mXgMHY0fNwdRtsxcfV0H3jKjJaPkeL2qVaZ8ifUWGnByi0TuLlfgmu3cWap+Q7TzUZkWVzjjB167mJQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxlbZwH0LRCFy6cQoC/dWR4Kalgxvxjoy873TOmZvfNheJTiLyJ nJWVsLRiV1wkcQMbX15LG801m6X9cl7zPe3afs0u0LT/OA7uWn4Rmfd8h6lDdsGX77YEab8LOJq mQfQBTAH3oYwxpPIFdzPckB55p/keUaAoer79A/UCPcvPm6oP0LMwVcTSkB7WB87pmTs= X-Gm-Gg: AfdE7cm4nEJm/bSLUSBFrfIkBRdXjT39iE5julXmChOqrcPlFj/+mMCQS1g1SRH4uxK VANGR/mzT3684MnvgtTEqd1asjiLvRUKiNOQ3rWIWp7mE+voIUsrjFuDMeqVndGuoSu2PjmX9Xr W+QmgNw6LmT9CF0tHgd11v6pYr1ZKDnifXON9xr9m4ywbfkbkD2MAyzi4WT5Yjr6zs0SQM1w5lG Ho2NCrl/xkYMv73AoWb4so8BzspX0GOeF2Xdxi36WsMVc/iuiPmzBxSGOB4UaGsJg1MsO+gv8oR EO1+fxtEjzYDWsI8jDOo18mD9Vf3CmDf8n201lW4WmhtqNMVgGmJ00yrMRYndiGvo5bIjOxYOnX v+d5cc5s/Aptm/69qcSZvHNO45/Dm/9VsC3c3v5kOVhtFemK1ZLP4BZMn3Om4wzT6z22pQsgMdQ == X-Received: by 2002:a05:620a:4106:b0:915:79c8:ec94 with SMTP id af79cd13be357-9293d8b33f1mr194382385a.39.1782373894612; Thu, 25 Jun 2026 00:51:34 -0700 (PDT) X-Received: by 2002:a05:620a:4106:b0:915:79c8:ec94 with SMTP id af79cd13be357-9293d8b33f1mr194378785a.39.1782373894204; Thu, 25 Jun 2026 00:51:34 -0700 (PDT) Received: from [192.168.10.101] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-46c1ee01d9csm14999506f8f.12.2026.06.25.00.51.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 00:51:33 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 09:51:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] dt-bindings: remoteproc: qcom,pas: add thermal mitigation properties To: Krzysztof Kozlowski , Gaurav Kohli Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi , Dmitry Baryshkov References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-1-291a2ff4c634@oss.qualcomm.com> <20260610-ocelot-of-stimulating-excellence-bcb0fe@quoll> <03d863ee-2caa-41f2-94b5-7332fc930b42@oss.qualcomm.com> <7f1e46fb-15e3-4638-9930-8abc1dd5a778@oss.qualcomm.com> <3cbcaf8c-357e-42d2-91c1-9d1a32c55ed0@oss.qualcomm.com> <9a31bb29-75d7-42fa-b8a8-4155cf85cadf@oss.qualcomm.com> <61765401-3397-497d-a0ca-e9bf9d76cc6a@oss.qualcomm.com> <5b0f1f39-ddaa-4a2e-ab29-34aacc9ff672@kernel.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDA2NiBTYWx0ZWRfX7DyZwsxr34lz h1J9gQcXDZQHHv3Diz3ndk72F17ZiB6ppYcfKTQTx6pQpjFsvxv0IPWvKZCYaa9Vpe7rluOkGYh y4NeAtjHjB2IrqpJisyM7SF2wpbX0pg= X-Proofpoint-GUID: WC1kUTuO0zo3rVsZGq_vdPgUYinvzn62 X-Proofpoint-ORIG-GUID: WC1kUTuO0zo3rVsZGq_vdPgUYinvzn62 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDA2NiBTYWx0ZWRfX+437pCCC/3Sh WUwaw0B6y+1EXaFtVjbJoOYBgGKgC/MMJ/gb6xTCLjPoDbJeEoDu7LXqihJK7TJhMR6KESfZ4eA 2GBgMHcEKD8SqyD0zV0qApLz+H8bl3owNkiQFYLz5dk51o/u3AWFpS292vXTYFM/lmyOVni/fKJ kGDQ82fl5Mt1IuBrAsjmoVjd6uQ2CCXckymRXAdRNGMJ237KlmFovFFN1Ufml4h4Ydupl3zLTF3 VEQxv+W6wLW/dRhcQdZku/rRdpcbqVQ26rio83X5bfvkE+oZmT0Ixo4IjDl7XlDk56Ir0a4Hpws Qhtlp6dNPqfUt4ZtejaMRUWGwGSmo5EzOfK36QVPnnG5V6rhw5fdYdqrle1X460YPP/9udYin84 P2qA5ggdnFAS/Mi3DADdTdjGxYOgpVZYALsN3nJZK2yPLhcChSIfFt8gOIulcCJayHA8EpMj4eu X7RieHXekp6yeTuQphw== X-Authority-Analysis: v=2.4 cv=Z+Xc2nRA c=1 sm=1 tr=0 ts=6a3cde07 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=RTo7OxITtARzf4XpFQgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250066 Le 25/06/2026 à 08:48, Krzysztof Kozlowski a écrit : > On 24/06/2026 17:56, Daniel Lezcano wrote: >> On 6/24/26 12:42, Krzysztof Kozlowski wrote: >> >> [ ... ] >> >>> Therefore I still do not see the need of tmd-names. You know the name of >>> cooling device, because you have strict one-to-one mapping. >> >> >> There is one remote proc with one or multiple cooling devices attached. >> >> We describe those in the remoteproc node with the tmd-names. >> >> Anyway, we should be able to list the tmd names in the driver itself if >> we ensure a consistency with the index by defining them in a shared >> header eg. include/dt-bindings/firmware/qcom,cdsp.h >> >> #define HAMOA_TMD_CDSP_SW 0 >> #define HAMOA_TMD_CDSP_HW 1 >> #define HAMOA_TMD_CP0UV_RESTRICTION_COLD 2 >> >> In the driver: >> >> struct tmd_name { >> const char *name; >> int id; >> bool disabled; >> }; >> >> static struct tmd_name tmd_names[] = { >> { .name = "cdsp_sw", HAMOA_TMD_CDSP_SW }, >> { .name = "cdsp_hw", HAMOA_TMD_CDSP_HW, .disabled = true }, >> { .name = "cpuv_restriction_cold", HAMOA_TMD_CP0UV_RESTRICTION_COLD, >> .disabled = true }, >> }; >> >> ... >> for (int i = 0; i < ARRAY_SIZE(tmd_names); i++) { >> >> if (tmd_names[i].disabled) >> continue; >> devm_cooling_of_device_register(rprocdev, >> tmd_names[i].name, tmd_names[i].id, ...); >> } >> >> >> In the device tree: >> >> cooling-maps = <&rproc HAMOA_TMD_CDSP_SW min max>; >> >> I think that is somehow what Konrad and Dmitry were suggesting >> >> Does it sound better ? > > Yes and I am surprised that it came now. So you had TMD index available > thus the ID was defined. If device has unique and fixed ID, you should > not have any more properties defining it, because that ID is enough. Any > names could be only for users, e.g. label, but that is not the case here. Yes indeed, having the constraint of cooling index and tmd(name, id) for the connection between the cooling device and the thermal zone was a bit confusing in our discussion. Thanks for the review