From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17D2C3DD512 for ; Mon, 4 May 2026 23:31:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777937513; cv=none; b=Rgx/z1p8vygKSTd1r09BDp3bouGSLirt0Mmg9pQ1VWGmB+J6o6gK/5rGC0HxYfl0wEhHZeYys6svuX+Pv77AbePBa+lo+T/AX4VdMWEn79iBWLxrbPQ/VSIslCCiFeY+Q0v8DX+dxJnZ8xbfjEt4/1/VVp3jHBw6Ipqbxt5Vh2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777937513; c=relaxed/simple; bh=mLVFdp5TspvCCdHUC34Lqoaa6WJY8K3YQB6d/Orv8/8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZQUXDOm+lPC5BuLH8SE3WpjFFQFNySWOtVXlCI6sPFJ5Q5WrYR/5zQoQXKDsHBZ46u+0ut+VPPWZOn3CY0+GW8KCydxJ18CiNxsNdHu9eeFxNFvXJFDESwk/JcP4uh7O1szlZCi9QpZUbzPazeNiSC8EM2Wjzc1qbyVLliDbpfk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QAGFA+0H; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Te1uBzM0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QAGFA+0H"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Te1uBzM0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777937511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WIdi3Vf7s14TiGM2SJEWnXo9lX3vBp55691Ki3YV0NY=; b=QAGFA+0HVXG77RiZqgUngoMrGNDVs4Sx1aPjV0r5Mzb33sNNQTtJKYyOFcCFFWYMWa3Icb 7ynDrSc21zatwsQzJnJvscYvC3feVF/n79qFuhyahmICwgmPu0weXGpTFz122pd6SIxn/J FaU/eG0urkv2g5uZrJVchYsw71q1bvQ= Received: from mail-yx1-f71.google.com (mail-yx1-f71.google.com [74.125.224.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-mVWRhvViMzOSlWEl-miuZw-1; Mon, 04 May 2026 19:31:49 -0400 X-MC-Unique: mVWRhvViMzOSlWEl-miuZw-1 X-Mimecast-MFC-AGG-ID: mVWRhvViMzOSlWEl-miuZw_1777937509 Received: by mail-yx1-f71.google.com with SMTP id 956f58d0204a3-65c53d7c36bso3674385d50.0 for ; Mon, 04 May 2026 16:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777937509; x=1778542309; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=WIdi3Vf7s14TiGM2SJEWnXo9lX3vBp55691Ki3YV0NY=; b=Te1uBzM0W2x754eDmKozP8TKE9c5VIjH7naS59PDvhFmC7USJ9p6obQynvZUV/FpnI xtFU6284//rgij/XuApyBxiQoMI4sB1keRd0PFYPEE9CGF1d+Nywh0E7r9/uU9JGkipT HD9ViAwOwTCjnZJpLBfGKJaNIbhLi5mjKdPwxbaDsblVzpznToRnW/bbhileWK1Ctw6H ezp54Lgi1rrrtCfpH6wArAsHC8Ik61+5PM/TYQqO9V8GpTEowZxiE8vDqgAxyGJmL8ck FrgcPHwainy3R2rmvVfoRNHqZwLNihs9dDnIRMoRt+K1WFeI0qumVCrzYwRrLTo5195P 68PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777937509; x=1778542309; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WIdi3Vf7s14TiGM2SJEWnXo9lX3vBp55691Ki3YV0NY=; b=XbvcCD/qkCZ8WEePjvNrvI1ZgTZGFNE6BwWRXR0YujEyk8V9jlWw3Ksz7djw6qVaLc xqCaT0ehLv7eOwyV4yTnN+jbz7fw2WGy63WgfXsO3MCOyaO308Tx6aKBSdL4UETtZBoF UumoLYirJHdmh2bS1SFGCySqFZIyh6RrOaykbWeTrIYGR/Gq8bVUoBNwnMTcQ104yBeB NNl7vUrsNWtfCU0dUuwc6ptvJGp1yHEKtkOgJ4xmbm2tjIHnZDUZuT+r7fMpLQ3gHo8M FMiQlMFLmHqCvZRTEklmwXYn25NjF5st6ni+4BRA3G3hBMVL3AO/sSeR2rFb9zwl5CBT DoGg== X-Forwarded-Encrypted: i=1; AFNElJ8ZWNRQW3EoffnXzYO7yDwhauIfQ7u3hmkOyVrYPagJCaBwTTbJCYj1Wwe7eRc8v9ojw+dQrM8LQhEdon4=@vger.kernel.org X-Gm-Message-State: AOJu0YzN6FPCs0CEgF7DJ5nh0OZe50z2t6yDZIUb/EggnV45zzxngs3g b5gEzmu8sOaM4Q2Yk0OCfiASsiY8F9xzlt897N7Oe/LwekM3cExKM1O2R5vA1kaqgZDIrs2yCc9 yldwpQEJ8Z2cfOr9zRRYXfElxOleDqSeA09XU1ftYFwPfDiNAbD5gIILssPksGTrSLw== X-Gm-Gg: AeBDieuFXj5C30pkoUNotpO9S8+AZWLTdEZ/6hoOY/7TSAnpIokp29LipPmKAQnysbW PUdJr2TnUumGh8B/psHvQj5QNOJp3LqeLQ3Zg9r9iqRW/OqsqRjocuijar3pkBhGGxIxTmNUFEZ OEIX9/WHX1z53GvEnnNyqWcDKiYZSiszgd7ehNim/oxF5dOJqDQbHirit649bYSIixNY6ziL4Yt m7jdiHOAzyePpnLDRQyfNWFA2jg9TksYC/2+L5PZ3vH81adc6s7clQLD0V+9HIlEHaWXp1wipBF 7hOidEQNKkIgSQKrCifC+JM8X6Pvl7F/HfsW8SD8qK5MxX06EUjBIaaft4NInBPC1P4uTNZGwLB /CPS/G89l4B1veVKHl4DIEn6TcpguFZVfCnGhKMKb6O1pY+jmnq5YO4vYEudTEo8= X-Received: by 2002:a05:690e:480c:b0:65c:2066:a9c1 with SMTP id 956f58d0204a3-65c69ecfc79mr685831d50.42.1777937509205; Mon, 04 May 2026 16:31:49 -0700 (PDT) X-Received: by 2002:a05:690e:480c:b0:65c:2066:a9c1 with SMTP id 956f58d0204a3-65c69ecfc79mr685812d50.42.1777937508761; Mon, 04 May 2026 16:31:48 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65c2df83478sm6167827d50.2.2026.05.04.16.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 16:31:47 -0700 (PDT) Message-ID: Subject: Re: [PATCH 3/3] hfsplus: fix null pointer dereference in hfsplus_create_attributes_file From: Viacheslav Dubeyko To: Tristan Madani , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tristan Madani , syzbot+bc70a12e438dadba4fb4@syzkaller.appspotmail.com Date: Mon, 04 May 2026 16:31:46 -0700 In-Reply-To: <20260501110218.29906-3-tristmd@gmail.com> References: <20260501110218.29906-1-tristmd@gmail.com> <20260501110218.29906-3-tristmd@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.0 (3.60.0-1.fc44app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-05-01 at 11:02 +0000, Tristan Madani wrote: > From: Tristan Madani >=20 > hfsplus_create_attributes_file() calls hfsplus_mark_inode_dirty() with > HFSPLUS_ATTR_TREE_I(sb) before sbi->attr_tree has been set by > hfs_btree_open(). HFSPLUS_ATTR_TREE_I dereferences sbi->attr_tree to > reach ->inode, causing a null pointer dereference when attr_tree is > still NULL. >=20 > Move the mark_dirty call to after hfs_btree_open() and guard it with a > NULL check on sbi->attr_tree. >=20 > Reported-by: syzbot+bc70a12e438dadba4fb4@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=3Dbc70a12e438dadba4fb4 > Tested-by: syzbot+bc70a12e438dadba4fb4@syzkaller.appspotmail.com > Fixes: ee8422d00b7c ("hfsplus: fix potential Allocation File corruption a= fter fsync") > Cc: stable@vger.kernel.org > Signed-off-by: Tristan Madani > --- > fs/hfsplus/xattr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c > index 452a1f9becb2d..1ea9f313368c5 100644 > --- a/fs/hfsplus/xattr.c > +++ b/fs/hfsplus/xattr.c > @@ -317,12 +317,13 @@ static int hfsplus_create_attributes_file(struct su= per_block *sb) > next_node++; > } > =20 > - hfsplus_mark_inode_dirty(HFSPLUS_ATTR_TREE_I(sb), HFSPLUS_I_ATTR_DIRTY)= ; > hfsplus_mark_inode_dirty(attr_file, HFSPLUS_I_ATTR_DIRTY); > =20 > sbi->attr_tree =3D hfs_btree_open(sb, HFSPLUS_ATTR_CNID); > if (!sbi->attr_tree) > pr_err("failed to load attributes file\n"); > + else > + hfsplus_mark_inode_dirty(HFSPLUS_ATTR_TREE_I(sb), HFSPLUS_I_ATTR_DIRTY= ); > =20 > failed_header_node_init: > kfree(buf); This patch already fixes the issue: https://lore.kernel.org/linux-fsdevel/6601b6ec0de087674f60566db950449c4e821= bfc.camel@redhat.com/ Thanks, Slava.