mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ye janboe <janboe.ye@gmail.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: rjw@sisk.pl, bunk@kernel.org, bugme-janitors@lists.osdl.org
Subject: Re: fix rtc_cmos bug
Date: Wed, 20 May 2009 13:17:03 +0800	[thread overview]
Message-ID: <af3ea28a0905192217x2006dbe4gb456217d110b916f@mail.gmail.com> (raw)
In-Reply-To: <af3ea28a0905170804n500126e4tc425dafd9fcaa68a@mail.gmail.com>

my fix is wrong?

Why no one ack this patch?

Thanks

Janboe

2009/5/17 ye janboe <janboe.ye@gmail.com>:
>    fix  Bug 13326 -  Null pointer dereference in rtc-cmos driver
>    http://bugzilla.kernel.org/show_bug.cgi?id=13326
>
>    Signed-off-by: janboe <janboe.ye@gmail.com>
>
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index 23e10b6..da132f6 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -1179,7 +1179,9 @@ static int __init cmos_init(void)
>        int retval = 0;
>
>  #ifdef CONFIG_PNP
> -       pnp_register_driver(&cmos_pnp_driver);
> +       retval = pnp_register_driver(&cmos_pnp_driver);
> +       if (retval)
> +               return retval;
>  #endif
>
>        if (!cmos_rtc.dev)
>

  reply	other threads:[~2009-05-20  5:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-17 15:04 ye janboe
2009-05-20  5:17 ` ye janboe [this message]
2009-05-20  6:16   ` Ozan Çağlayan
2009-05-20 13:03     ` ye janboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af3ea28a0905192217x2006dbe4gb456217d110b916f@mail.gmail.com \
    --to=janboe.ye@gmail.com \
    --cc=bugme-janitors@lists.osdl.org \
    --cc=bunk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®