From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Michael Dege <michael.dege@renesas.com>,
Christian Mardmoeller <christian.mardmoeller@renesas.com>,
Dennis Ostermann <dennis.ostermann@renesas.com>
Subject: Re: [PATCH net-next] net: renesas: rswitch: cleanup max_speed setting
Date: Wed, 5 Feb 2025 17:26:09 +0100 [thread overview]
Message-ID: <af3fb019-48fa-42e0-9e02-a4b0d3a724bc@cogentembedded.com> (raw)
In-Reply-To: <59bc0c2b-0ece-427e-80c5-5b6920132989@lunn.ch>
> You should only need max-speed when you have a PHY which can do more
> than the MAC.
This is exactly the case.
Unfortunately I don't have the spider schematics nearby, but AFAIU (one of flavours of) the board has
PHYs capable of 5G but connected over SGMII. When two such boards are connected to each other, on
mainline kernel auto-negotiation takes noticeably longer than with the Renesas BSP kernel.
> Also, phylink handles this a lot better than phylib. So you might want
> to change rswitch to phylink, especially if you have link speeds > 1G.
The reverse switch happened in commit c16a5033f77b ("net: renesas: rswitch: Convert to phy_device").
I did not check the tech details of that, but decided not to touch it.
Nikita
next prev parent reply other threads:[~2025-02-05 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 17:09 Nikita Yushchenko
2025-02-03 18:09 ` Andrew Lunn
2025-02-05 16:26 ` Nikita Yushchenko [this message]
2025-02-05 19:27 ` Andrew Lunn
2025-02-05 19:35 ` Andrew Lunn
2025-02-05 20:26 ` Nikita Yushchenko
2025-02-05 21:28 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af3fb019-48fa-42e0-9e02-a4b0d3a724bc@cogentembedded.com \
--to=nikita.yoush@cogentembedded.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=christian.mardmoeller@renesas.com \
--cc=davem@davemloft.net \
--cc=dennis.ostermann@renesas.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®