From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbdKHVfy (ORCPT ); Wed, 8 Nov 2017 16:35:54 -0500 Received: from mout.web.de ([212.227.17.12]:59878 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbdKHVfw (ORCPT ); Wed, 8 Nov 2017 16:35:52 -0500 Subject: [PATCH 2/2] tipc: Improve a size determination in two functions From: SF Markus Elfring To: tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org, "David S. Miller" , Jon Maloy , Ying Xue Cc: LKML , kernel-janitors@vger.kernel.org References: <25790616-164d-fe3e-bda4-3155299a8171@users.sourceforge.net> Message-ID: Date: Wed, 8 Nov 2017 22:35:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <25790616-164d-fe3e-bda4-3155299a8171@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:eLNwJCnmrbVwEmyT1y/0YGNsZflXVZjMdy6fJ7DuP/QKIlYcRin Quc60RFXJkI0dpayF9lOUtSK3cLD1fhwjiWdQbW3UdO/KmdaaJtkEcUOWrD0Y3i4wlRyxhQ hSb4cooYLeEcSQYRZ1Xlh0ZR2CdGdmzDACCWFhpCUz13aILTgS34hwZdfPeXc/qaapq4Ac5 kY3nUKC6k7gpH3gOHWorg== X-UI-Out-Filterresults: notjunk:1;V01:K0:UiNdC3ubXgY=:WqGjy9whUykiofnecfBqs5 DHUPvMwxgsNGJ3uGWg+ALpVQsnOTt/PUSFsYBXOSdkH2dptfxFvL1MP5lcRla9HTR4rXIhgwi BxkaJ5kNdAla5/6s2tRmj09q4pan8VBTlWCnqkrJOZ5iSBlIBXjPVJDB4xTZVn70y+udAaMeO V9YKfPLcsh6PO7sPejoxcYEwskXFUQO3Evw138VpcWziaiz2PTPVxSbwnt5yHL6f7DnOpClJI KvRM631NAbPaAJg6cyZuMMmWBS8gYbLQA7vSJ4pqYKLoOSf0RGoAePMWH4mhQKrhTeVMiShcW /CKAPrASFjbGTIRUG+WebTem+oGeVbdeDaJDgIEBTjI06MkccSk35Ec/LwXIeq0t4ddgXreGG 0rsciDinIMI9tBZ6t7MwwgVGQvo8FeLHTQKuyXUBhiTmqn08h0iOwQW6gH02+kWgOnK7Y3g+I RimQaPh+wDn5LVenXxERPDKXIQX5mQGKbqBzdUJjNhPKbKfeTH7iaN3Sd//b9rB5Omqi5AXNA mF7iGWCYRfIHhfy+wNxkIobi0jQiQqcnmWtSkV4jEJvUv4o/Oy+Bkh1eyR4MsBqMj5+lhFyFx NaN1BxdErwzF7n1BKPVaqtVig8Y1Tp3f8HFNPWy/22RZ0sB770SbZ41SivNpkkV+7dMbUf7M2 5icUF5Zu4Ba0HxP6HFTeVIhDJuzGMu3BzLdeM1kM3fHv0otMEabpfitSWKKRh48nM9d2+6LQV LI82ZYONTX7FE1YNEEUmHM50o1N8a9Z6A9w8bedB+vJCYGFBc8b9Zd0cRsfn+xNtrLumVp5qF h+evlQdb93oVFhDgLfTqNvURzegosCpi26KBwvTuoeZiJBA1Ko= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 8 Nov 2017 22:23:07 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/tipc/server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tipc/server.c b/net/tipc/server.c index 7359d37e39cd..5d001b6acbe5 100644 --- a/net/tipc/server.c +++ b/net/tipc/server.c @@ -219,7 +219,7 @@ static struct tipc_conn *tipc_alloc_conn(struct tipc_server *s) struct tipc_conn *con; int ret; - con = kzalloc(sizeof(struct tipc_conn), GFP_ATOMIC); + con = kzalloc(sizeof(*con), GFP_ATOMIC); if (!con) return ERR_PTR(-ENOMEM); @@ -410,7 +410,7 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len) struct outqueue_entry *entry; void *buf; - entry = kmalloc(sizeof(struct outqueue_entry), GFP_ATOMIC); + entry = kmalloc(sizeof(*entry), GFP_ATOMIC); if (!entry) return NULL; -- 2.15.0