From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755915AbdKGBTW (ORCPT ); Mon, 6 Nov 2017 20:19:22 -0500 Received: from mail1.windriver.com ([147.11.146.13]:46511 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755888AbdKGBTP (ORCPT ); Mon, 6 Nov 2017 20:19:15 -0500 Subject: Re: [PATCH] selftests: futex: fix compilation error To: Shuah Khan References: <1509941009-11521-1-git-send-email-Lei.Yang@windriver.com> <6b0b866a-b142-8c07-41e3-d561d4b91fb3@osg.samsung.com> CC: , , Shuah Khan From: lei yang Message-ID: Date: Tue, 7 Nov 2017 09:18:47 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [128.224.163.162] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017年11月07日 07:48, Shuah Khan wrote: > On 11/06/2017 04:45 PM, Shuah Khan wrote: >> On 11/05/2017 09:03 PM, Lei Yang wrote: >>> I run into below error when building futext >>> /bin/sh: -c: line 5: syntax error: unexpected end of file >>> >>> the closing ";" and "\" are necessary. >>> My OS is "Ubuntu 14.04.5 LTS" >>> >>> Signed-off-by: Lei Yang >>> --- >>> tools/testing/selftests/futex/Makefile | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile >>> index f0c0369..943f3a2 100644 >>> --- a/tools/testing/selftests/futex/Makefile >>> +++ b/tools/testing/selftests/futex/Makefile >>> @@ -11,9 +11,9 @@ all: >>> BUILD_TARGET=$(OUTPUT)/$$DIR; \ >>> mkdir $$BUILD_TARGET -p; \ >>> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ >>> - if [ -e $$DIR/$(TEST_PROGS) ]; then >>> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; >>> - fi >>> + if [ -e $$DIR/$(TEST_PROGS) ]; then \ >>> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \ >>> + fi \ >>> done >>> >>> override define RUN_TESTS >>> >> Hmm. I don't see this error on linux_4.14-rc8? >> >> Can you give more details on the gcc version you are using? > > I meant gnumake version? I am not seeing the failure with what I am > using $ make -v GNU Make 3.81 Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. This program built for x86_64-pc-linux-gnu Lei > thanks, > -- Shuah >