From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D647C001B0 for ; Mon, 17 Jul 2023 15:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbjGQPUX (ORCPT ); Mon, 17 Jul 2023 11:20:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231643AbjGQPT5 (ORCPT ); Mon, 17 Jul 2023 11:19:57 -0400 X-Greylist: delayed 401 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 17 Jul 2023 08:19:31 PDT Received: from mfwd20.mailplug.co.kr (mfwd20.mailplug.co.kr [14.49.36.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E262119B0 for ; Mon, 17 Jul 2023 08:19:31 -0700 (PDT) Received: (qmail 4484 invoked from network); 18 Jul 2023 00:12:48 +0900 Received: from m41.mailplug.com (121.156.118.41) by 0 (qmail 1.03 + mailplug 2.0) with SMTP; 18 Jul 2023 00:11:48 +0900 Received: (qmail 529759 invoked from network); 18 Jul 2023 00:11:48 +0900 Received: from unknown (HELO sslauth52) (lsahn@wewakecorp.com@211.252.87.165) by 0 (qmail 1.03 + mailplug 2.0) with SMTP; 18 Jul 2023 00:11:48 +0900 Message-ID: Date: Tue, 18 Jul 2023 00:11:47 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] fs: inode: return proper error code in bmap() Content-Language: en-US To: Matthew Wilcox , Leesoo Ahn Cc: Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230715082204.1598206-1-lsahn@wewakecorp.com> From: Leesoo Ahn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 23. 7. 15. 23:56에 Matthew Wilcox 이(가) 쓴 글: > On Sat, Jul 15, 2023 at 05:22:04PM +0900, Leesoo Ahn wrote: > > Return -EOPNOTSUPP instead of -EINVAL which has the meaning of > > EOPNOTSUPP is the wrong errno. ENOTTY is "more" correct. Thank you for the feedback, just figured out that ioctl never returns the error code. Best regards, Leesoo