From: David Lechner <dlechner@baylibre.com>
To: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Sean Anderson" <sean.anderson@linux.dev>,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 5/9] spi: Documentation: add page on multi-lane support
Date: Fri, 23 Jan 2026 14:00:46 -0600 [thread overview]
Message-ID: <af4e092b-1b80-42c1-824d-16554d91e792@baylibre.com> (raw)
In-Reply-To: <20260119101116.00002664@huawei.com>
On 1/19/26 4:11 AM, Jonathan Cameron wrote:
> On Fri, 16 Jan 2026 16:35:13 -0600
> David Lechner <dlechner@baylibre.com> wrote:
>
>> On 1/14/26 3:10 AM, Jonathan Cameron wrote:
>>> On Mon, 12 Jan 2026 11:45:23 -0600
>>> David Lechner <dlechner@baylibre.com> wrote:
>>>
...
>>> Whilst simple I'd kind of expect a multi lane case as the example, or this and
>>> the multilane one? For me the comment that follows is sufficient for the 1 lane
>>> offset case you have here.
>>
>> I thought that is what I did. I have one example that shows multiple lanes (ADC)
>> and one example that shows the map (Thing 1/2).
>>
>> But I guess you mean that you want a 3rd example that show both the map and
>> multiple lanes at the same time?
> Oops. No. I was arguing....
>>
>> I chose these two examples because they came from real-world use cases that
>> drove adding this feature. We didn't have a real-world case yet that used
>> both the map and multiple lanes at the same time so I didn't include that.
>>
>>>
>>>> + ...
>>>> + };
>>>> + };
>>>> +
>>>> +
>>>> +The default values of ``spi-rx-bus-width`` and ``spi-tx-bus-width`` are ``<1>``,
>>>> +so these properties can still be omitted even when ``spi-rx-lane-map`` and
>>>> +``spi-tx-lane-map`` are used.
>
> This comment is enough to allow you to drop the first example entirely and
> just have the 2nd.
>
> Jonathan
>
I still like having two examples of real-world uses cases since they are solving
two very different problems. It think combining these into one contrived example
would make it more difficult to see that.
next prev parent reply other threads:[~2026-01-23 20:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 17:45 [PATCH v5 0/9] spi: add " David Lechner
2026-01-12 17:45 ` [PATCH v5 1/9] spi: dt-bindings: change spi-{rx,tx}-bus-width to arrays David Lechner
2026-01-12 17:45 ` [PATCH v5 2/9] spi: dt-bindings: add spi-{tx,rx}-lane-map properties David Lechner
2026-01-14 8:57 ` Jonathan Cameron
2026-01-12 17:45 ` [PATCH v5 3/9] spi: support controllers with multiple data lanes David Lechner
2026-01-12 19:07 ` Andy Shevchenko
2026-01-12 19:11 ` Mark Brown
2026-01-12 19:35 ` Andy Shevchenko
2026-01-16 23:12 ` David Lechner
2026-01-19 7:44 ` Andy Shevchenko
2026-01-14 9:05 ` Jonathan Cameron
2026-01-16 22:20 ` David Lechner
2026-01-12 17:45 ` [PATCH v5 4/9] spi: add multi_lane_mode field to struct spi_transfer David Lechner
2026-01-14 9:06 ` Jonathan Cameron
2026-01-12 17:45 ` [PATCH v5 5/9] spi: Documentation: add page on multi-lane support David Lechner
2026-01-14 9:10 ` Jonathan Cameron
2026-01-16 22:35 ` David Lechner
2026-01-19 10:11 ` Jonathan Cameron
2026-01-23 20:00 ` David Lechner [this message]
2026-01-12 17:45 ` [PATCH v5 6/9] spi: dt-bindings: adi,axi-spi-engine: add " David Lechner
2026-01-14 9:11 ` Jonathan Cameron
2026-01-12 17:45 ` [PATCH v5 7/9] spi: axi-spi-engine: support SPI_MULTI_LANE_MODE_STRIPE David Lechner
2026-01-14 9:16 ` Jonathan Cameron
2026-01-16 22:43 ` David Lechner
2026-01-12 17:45 ` [PATCH v5 8/9] dt-bindings: iio: adc: adi,ad7380: add spi-rx-bus-width property David Lechner
2026-01-12 17:45 ` [PATCH v5 9/9] iio: adc: ad7380: add support for multiple SPI lanes David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af4e092b-1b80-42c1-824d-16554d91e792@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome