From: "Ed L. Cashin" <ecashin@coraid.com>
To: linux-kernel@vger.kernel.org
Cc: ecashin@coraid.com, Greg K-H <greg@kroah.com>
Subject: [PATCH 2.6.15-git9] aoe [1/8]: zero packet data after skb allocation
Date: Thu, 19 Jan 2006 12:37:24 -0500 [thread overview]
Message-ID: <af4ea3ed437649839c3ef9d66d5705d4@coraid.com> (raw)
These eight patches supercede the seven aoe patches sent on January
third for the 2.6.15-rc7 kernel. A bug existed in the Jan. 3 set of
patches where the retransmit timer for an AoE device AoE timer could
be added twice. That bug has been fixed in this set of patches.
Signed-off-by: "Ed L. Cashin" <ecashin@coraid.com>
Zero the data in new socket buffers to prevent leaking information.
diff -upr 2.6.15-git9-orig/drivers/block/aoe/aoecmd.c 2.6.15-git9-aoe/drivers/block/aoe/aoecmd.c
--- 2.6.15-git9-orig/drivers/block/aoe/aoecmd.c 2006-01-18 13:22:49.000000000 -0500
+++ 2.6.15-git9-aoe/drivers/block/aoe/aoecmd.c 2006-01-18 13:48:53.000000000 -0500
@@ -28,6 +28,7 @@ new_skb(struct net_device *if_dev, ulong
skb->protocol = __constant_htons(ETH_P_AOE);
skb->priority = 0;
skb_put(skb, len);
+ memset(skb->head, 0, len);
skb->next = skb->prev = NULL;
/* tell the network layer not to perform IP checksums
--
"Ed L. Cashin" <ecashin@coraid.com>
next reply other threads:[~2006-01-19 18:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-19 17:37 Ed L. Cashin [this message]
[not found] <1d5bd928255f552b12b1b329c92257bb@coraid.com>
2006-01-19 22:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af4ea3ed437649839c3ef9d66d5705d4@coraid.com \
--to=ecashin@coraid.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome