From: Chen Wandun <chenwandun@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>, <Markus.Elfring@web.de>
Cc: <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
<mingo@redhat.com>, <cj.chengjian@huawei.com>,
<chenwandun@huawei.com>
Subject: Re: [PATCH next] perf tools: fix potential memleak in perf events parser
Date: Thu, 11 Jun 2020 23:05:07 +0800 [thread overview]
Message-ID: <af4efc64-b55a-959c-b342-b70357f10173@huawei.com> (raw)
In-Reply-To: <20200611131651.GC18482@kernel.org>
在 2020/6/11 21:16, Arnaldo Carvalho de Melo 写道:
> Em Thu, Jun 11, 2020 at 09:42:34AM +0800, Chen Wandun escreveu:
>> Fix potential memory leak in function parse_events_term__sym_hw()
>> and parse_events_term__clone().
>>
>> 1. Free memory when errors occur.
>> 2. Function new_term may return error, so it is need to free memory
>> when the return value is negative.
> Try to fix one thing per patch, i.e. first the most obvious one, then
> the other that requires going thru the new_term() logic, i.e. first
> this, which is super easy to review:
> Would you like to add the tag “Fixes” to the commit message?
>
Hi, Arnaldo and Markus.
Thank you for your reply, I will update in v2
Best Regards,
Chen Wandun
prev parent reply other threads:[~2020-06-11 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 1:42 Chen Wandun
2020-06-11 13:16 ` Arnaldo Carvalho de Melo
2020-06-11 15:05 ` Chen Wandun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af4efc64-b55a-959c-b342-b70357f10173@huawei.com \
--to=chenwandun@huawei.com \
--cc=Markus.Elfring@web.de \
--cc=acme@kernel.org \
--cc=cj.chengjian@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®