From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752512AbdLFPI7 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 6 Dec 2017 10:08:59 -0500
Received: from mga05.intel.com ([192.55.52.43]:23689 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752472AbdLFPI5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 6 Dec 2017 10:08:57 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.45,368,1508828400"; 
   d="scan'208";a="181897395"
Subject: Re: [PATCH] x86/mm/kaiser: avoid 32-bit/PAE build warning
To: Arnd Bergmann <arnd@arndb.de>,
        the arch/x86 maintainers <x86@kernel.org>
References: <20171206141627.688219-1-arnd@arndb.de>
 <CAK8P3a0ZN2ALu1tj9sm8-Lt9SsRgpbQtz91zR4MhY-Np7TQNyg@mail.gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <af5124d4-b2cc-7d3c-5b8e-f7381859efd6@linux.intel.com>
Date: Wed, 6 Dec 2017 07:08:56 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAK8P3a0ZN2ALu1tj9sm8-Lt9SsRgpbQtz91zR4MhY-Np7TQNyg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/06/2017 07:03 AM, Arnd Bergmann wrote:
> On Wed, Dec 6, 2017 at 3:15 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> 
>> This changes the type to u64 in the architecture-independent dummy,
>> and to pteval_t in the x86 specific portion that is used when KAISER
>> is enabled, ensuring that the flags can always fit. Unfortunately,
>> pteval_t is not provided by most other architectures, so we are
>> a little bit inconsistent here.
> 
> I ran into a new regression with my patch applied, after doing more randconfig
> builds:
> 
> In file included from /git/arm-soc/include/linux/kaiser.h:5,
>                  from /git/arm-soc/arch/x86/events/intel/ds.c:4:
> arch/x86/include/asm/kaiser.h:34:10: error: unknown type name
> 'pteval_t'; did you mean 'dev_t'?
> 
> Maybe it's better to just to the last one-line change in include/linux/kaiser.h.

Hi Arnd,

Are you hitting this in -next?

The newest version of this code has a single kpti_init() function that
shouldn't have any of these problems.