From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2084.outbound.protection.outlook.com [40.107.236.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ACE82B9A8; Mon, 23 Sep 2024 14:00:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.84 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727100050; cv=fail; b=MaZvygzGaWQum++XsM22CFxRzMfoJHDjYSSpfndIe237wGJzfRHPXMg3DGl6a/14TPiN+bPW4v14U81wJ8cjgeHwPRgcG4KTmc1/4f3XnQosw6ln6mmfvBQ2IcLIi1GFLyXxM9vke9gADrz2jCXPRSPxVZByNcfnt2N9IDhVTJY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727100050; c=relaxed/simple; bh=hhEfoWTmH5AjSLndPPMIwJMgWZ85dOedHmgyuXZes3E=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=MVj/KPTb2e+CfQ+nkjLNVCI2VefYRtTiATtrVQLEtzCWlpZ6eedJqKNvOuW8zIX7ZfpfQI6xqTI5fFRfPIkk7Bh+ywHETKDK1+kSxxMzG8oMcYfKEf9SKtc+f6l01nucPyLOIk9snSdQYqNBxqLsRpr5au2dsz0P/Z/RRmrlhcs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=xB6CXoxh; arc=fail smtp.client-ip=40.107.236.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="xB6CXoxh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Gu39bdfifBEu1q03zYFKjkl/Oa1dQWXVElU+LFoQ0KZIUPKpHchZagC3ji33t5sv9V7jeSe9B7OJObPJKM39JbyNo6ruoWUnrpIqEIKfib27TUiWuL1+lZ+lDmBFkd9o8bf1s0Tg0vsw5vNPWXPqzw43zbIZuE9Kzwpe9VdqLUwnnXu4CBhs2vLjPN054Sh52VjUiYvPmCH/VQRiqPcqdXCe4rv614jrvgHxNTvxXmr6wllANZwvb7XaDen8JO7jsZbw1uLabgiX8Ph9d1ps8//GBwWNoHszEie2jqPPrUIDzGNLxX6Y9ZZLIAdU3omIlzJe9afeGFPFAGQsC4Qjig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RiEsEBFbyyM/GCeR+uQq4wSZjae7dU16hQQ7ZHpik4U=; b=RNxf8eMMF24jio+4rpEekOTOt9pgU4SKnmjzi9BZPuKO4FjWbnSr1SZtr6Rmko7k5CAny9Y6RDGkoR6vH0G0LGBl7Tagke+yRlybxoW0EjM/CfExEb8euVrafJ3xd2GXp9jxEcD520z/b7o38O0R6hiP1dfxrmCBUPp9sIMrCWk4Lf+Q5vfpywa/FHoKMXat/UfntlBM2dpkG2VVTUGFC9COgFQBjXoHlI3qa767QjiOMk/RrMErerlQu//cNPPmUq8gMMHg9DQtKLOhqqOzbmZsElbnK8tzYJdZEZR7bfThYM8SU9N+Iwi7AxasPu0BBbsjvch5aQNG/gMq6nBecQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RiEsEBFbyyM/GCeR+uQq4wSZjae7dU16hQQ7ZHpik4U=; b=xB6CXoxhtgNBSifzyRzkNdEuB6v2riYDcAyfbL4W0Q+Dm732T5jfWGk28noq9wQHYIrPVWTQMumWt1aUcO1yV9H8HUJNIDGLt6sNhVr2MZ/UnAEtjBag9gUaaZzOV1zreGdrO88WT40H7WsdHRbJvi2WZOd2C1u2SyylLjNJew4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) by CY5PR12MB9053.namprd12.prod.outlook.com (2603:10b6:930:37::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Mon, 23 Sep 2024 14:00:45 +0000 Received: from PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::46fb:96f2:7667:7ca5]) by PH7PR12MB5685.namprd12.prod.outlook.com ([fe80::46fb:96f2:7667:7ca5%2]) with mapi id 15.20.7982.012; Mon, 23 Sep 2024 14:00:45 +0000 Message-ID: Date: Mon, 23 Sep 2024 16:00:39 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dma-buf: Add syntax highlighting to code listings in the document To: Tommy Chiang , Sumit Semwal Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org References: <20240119033126.1802711-1-ototot@chromium.org> Content-Language: en-US From: =?UTF-8?Q?Christian_K=C3=B6nig?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::19) To PH7PR12MB5685.namprd12.prod.outlook.com (2603:10b6:510:13c::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB5685:EE_|CY5PR12MB9053:EE_ X-MS-Office365-Filtering-Correlation-Id: 7382a360-e59b-42e8-92e9-08dcdbd81e84 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eWNpOCtOVElIS3RsdEczWGl6SjZrYTVNTFd3eldmT0pzUFBxamh0ZVdsQnpT?= =?utf-8?B?VzV4anp3b0xjbVBEVS8zdUVieEk1UnptV0JLU3MwMkJVU3UzZzhRZXVPR2g4?= =?utf-8?B?YVF1ZHJvSWhoTnJ2WTQ5QXUrT2x0NWN4U3JUaDNSa2xzQXUxY2xFVEtkY0RL?= =?utf-8?B?N3JTS3h0cXdaeG1MNmpHV0hiRGl3MWorbHhLOHpTKzIzbVY2bU10aU9BbWxL?= =?utf-8?B?WHRMb1hKQjlkbGR1dEwyL0d2YmFyakdJckVaZXQ2SitYOThVTmlZZFpGNWt3?= =?utf-8?B?eDJ2YSt4OEdsNDZZL0pFVzR4TiszbE5NVnJzRlpHV1hmQmRrd0MzdXkzTGMr?= =?utf-8?B?ZEIybkpwR3o3SytqcFJ6TGhpaEhQU3ZKRENZRWtTWFEzd2F5bW43dzdIbW5q?= =?utf-8?B?cVpINFhjb1hrNTZrSUw5RVBCUjd0NTBDUkVjekpHWFR2cC9CWVZ4Y0pUWDll?= =?utf-8?B?UEhnSEdNNXVpK25LMDBYTTFyNFRkc3BLMFpvY2JiMXlDRTdOakVMQlFnNUJY?= =?utf-8?B?UkFHcFhUK1ZtQWhYL1g1cTJGazJjYmRmUzBzSHZFRUZuQXlKMXpnOGhkdGVB?= =?utf-8?B?SzlsYjNjZmhzWjNmeERjVDQzWitNaHpuMTR4ZnVEWUU5Rk15Q0pNaWpYT0E3?= =?utf-8?B?VTFRVlVyaWVXeHR3T1RBOERob2dHMVRYeHlTck1mN1BaVlNUMnNuTVVBU05l?= =?utf-8?B?M2c2Qkk2ODBjNVcrVGF1bkNQSmtmYlFPQ2VwRU5PV0QyRFZlMkhjc1Z4S0FN?= =?utf-8?B?QWp1bEdkN0Fkay8yaWJTSDA4L2FQeEpOaUNIeDkvWS9CUW93YmlGNnVXcnZ4?= =?utf-8?B?S1ZKQkVYSjFpNnhYaVhTNHBiMndoOUsycnlSRENKNU9ieGtDUGlUeWtIL0Rh?= =?utf-8?B?VEludG5Wb3paU2txa2VDK1liSThsQzhzMzlsWVVBZXRWeUs2YTBQL2JNdldi?= =?utf-8?B?Uk1wSk5tVWM0aXMrb3pJY05ZdktOeDh4UlFqeFVnc0x6c2Z0aTVndnROWTFa?= =?utf-8?B?bk55cytuczZxOUl3NU1HWXl2UUdFN3NERFEyb0dpMi9ieDZOUWJ4NmJzcW9L?= =?utf-8?B?RWhGT25iYVE5TDQwRmxRUlh3emZnN3R2OHhEQnJWQlZpSU5kUFVTR1RtcFpG?= =?utf-8?B?cEYwRk93TFY4a1NDbkgzcElXS1didk9GUWN4YXFCL3BXendDRFRSenJJK0ZH?= =?utf-8?B?c043WHFyUEZJK0hibCtHb3VKTXVpc2FIVDQrOFZVNGxnSk9NanJSMURaa1Zs?= =?utf-8?B?L240M2gvMHdudU45dzlrZDZlZEpTNnpXTVkvWk92ZG9hYVNKUTRqZlNLSjlP?= =?utf-8?B?YWc2VU1WVjlzbmE5WWZaZ1BUZDlISUFjWWZZY01UUmxUY1lNVlIrcncrSGts?= =?utf-8?B?TTlpS1JBcFlua240MENSNUptVHlkaE0yRWxCQzJWdEYwbGRZNVY3Wm5PakRO?= =?utf-8?B?QnMrQkVnOXpJUDlrREVHWHV0RS9XTzZ4YjJFNCtIZHlZeFUzc0FBdVkvblI1?= =?utf-8?B?S1dhRW96aDdpVjE3TzkvQWZJZVkyVFdDVW0wVEtCL21VcmZiaCttWWdmcnM4?= =?utf-8?B?UVVmWlBzYll6T0hjU1lKN1l4SGZIZnQwOXEwRlNZVDl5MTRGTkVrOFI5VGpm?= =?utf-8?B?c3IrNHgwaVd3QWpFalhMTjNTSTZqbnZLVUZWc2RhK2dhWFZyM21DcFVhcE0w?= =?utf-8?B?R1Q5K1lrVi80dU5nUTRDL0xaZlFxbEhLM2lLemk0blBiY0dSejBidTlnPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB5685.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmVQLzlvWEJ1dGdFdng3Yk42VlJYWlgzUjBTVTB5Q3FzU3g4SzloaGFvWW1K?= =?utf-8?B?QmNrODFpbjE3OTdmbVdSS0xncnh1MTdwTndPdDdzYmxMb3VONGc2eHZ3YmY4?= =?utf-8?B?ekFyQjRYVFNFb0NtNFFlY09iajFvaHYwZURVTHVrWGhkd2wvUmsyNFMxYkQz?= =?utf-8?B?YkNOZ1JiRkUxN0xLZjRQdkJXZWFxM05PYVBPdEc1SFZnWURhcXFraXRlOUNG?= =?utf-8?B?dUFIaEJIQ3hRaE1Xbm9peTBUWW5IZzYvZzV1dFJ6eCs5YW80WnBjQVUrR28w?= =?utf-8?B?WnZiV1dCVzFqU0Y3Uk9sQ0xqWHhRa0JrREdtM1VMWjY0dFFmYXV4aFBDWDUv?= =?utf-8?B?aUl0Z09KZTJCU1dmeGtvUXRzZkNtRHFVTGxxUmVnQnNvOVN4aHVmaGg1aCtH?= =?utf-8?B?NytlYzV2c1g0TXE4MzRlcWJQSFZOdlhXVlB1dFpPVllaZ3g4TzI4ZzVDdmx5?= =?utf-8?B?eEUxVXZuYVhTRUtSZE9PZlJNV01NeVhIaGZpYjRSRGIwZ2s0bEh6d25TVFkz?= =?utf-8?B?VkpycUtYbE9JaUZNa3VLMi9JempWL0RFajVZUFlDclJOL0owNWRtc1BqNzZ3?= =?utf-8?B?Z0FBNUFVWTBuTUpNczZRVC9hVTY3dEFWMkd1cUFtY0FiemVwUmMzU3U1dHV1?= =?utf-8?B?TnQ2WGlxUmIzZ1pxdlBXQ0RRMWZCdHB2Z0VmL1RNYm44ank5VE5ZN0JKVDRw?= =?utf-8?B?SlpkTGVKZjRMc3J3QnFqTFB1Z2NtYnRsYzdHR2VZdGlsMHFiN09qeXZtVUJ2?= =?utf-8?B?S2dRcWVpL3dYU3Fja1F5c3dJeGVwZ05mdzZpb3JJOTVlbndsdE1aeXltRXVF?= =?utf-8?B?MFg4QUZqZkRxWVhQZVRZd2xKK3JkVUNsY3FUTXdwYlAxV1k0M2FwaGhHV1VD?= =?utf-8?B?QjZKV1NOYk9hbEQrV1RHSkFVRzdPb1doRGtvNVRrc1pyM3ZHeHYzNEl4ME1E?= =?utf-8?B?S3ZSS29QZEp1UjJkMTBuWG9rVzBORUNmeXBIb3NMRThBempubmRKTlRIYURH?= =?utf-8?B?RTVCWkFINTJ0U3RMSkdLcklQY1ozMHJCcmhjNHh3NmhITjM5L09IUHBwWDQr?= =?utf-8?B?M3Z5eGQ4clBwKzRIeHcwZVRCK3ZITUtJaGlHbThpem9kQTc3ZFVUNUtyNmh5?= =?utf-8?B?ZXNwNDcyWEF5NmFvdzh4bWVxbUwwVUlScHNHWEJRYW9XeXZTbW5pK0N2VVNy?= =?utf-8?B?WWJHV1BhSnk1eVRnUk1BTExVclRMZHJKajZVNGlROE0reCtuR1c4VTdURkc1?= =?utf-8?B?Qm5Fanl2SytpbENpUVpCWVkwNThhS3hBTlFlMmErMHZFLzl3WG5ZN082QUpT?= =?utf-8?B?eDd6dTVCRVljdTF6ZzBGOVpLT2w4eERuRlpNdDRKYThMU0ExeGVVb2hyNVY4?= =?utf-8?B?Zkp4MU5BSVN0MnROalZVc0U1ZnpTcEo0VGxPbE5OZnBGVVA5UklrbTBOMnVl?= =?utf-8?B?Sk9ZY2FzQ1pnN0hlMjNRU1NiUDB2WG1GdmprenUweDJyOHVOT3FndHpZOFcw?= =?utf-8?B?NlNUT01LdlpCRjRlOTF1bDlYRFhNNjNBblAvNTl5RlF6VUFLZ2xRQ0xtYi9y?= =?utf-8?B?NHlrR3M0M3hFK1VNUE1vNDQvSFJjRTkrMjEwTUdGRThiREkwWE5XNk1iVFIv?= =?utf-8?B?Z2htdk8yK3Mrc01BTUF3WHJYYTNrSFJtaHBjZkVSQkZXRVNLNWxjZzcwQUtB?= =?utf-8?B?NTBXbWxqM2x1Z3p3T0poL3gyREZ1bXBlUVBCZjdwR1o2RTVGbG55OEN3ZE1r?= =?utf-8?B?K1lMTW1Fcy9VSXNzL0w1cVgydnNDSS9IVkprMURNV0Z1azZ4SWZhcTFnTWVH?= =?utf-8?B?dXdLTXJsaktPUVFGTm5hVHNTN2N2VFB1NEc3Mkp4VVM3NVBhdW1YY2FMa1NI?= =?utf-8?B?eEY1ZzNyT1YyOHNoTVRrOWVvQ3RSNzZvc1FOZUlnRXhtd2FyRjU5MEliR2Zw?= =?utf-8?B?d1R1Q29tU1d1NmlkdGNJNEovWEdMUHN4b1E0RzVqa21sSENUQ1lqb0xkWGJD?= =?utf-8?B?VW9Xc3hGOWRORHZxc0R5R0ZPc0huWndRYUQ0R1lLMVJOQkZHU2VXdm5tamZo?= =?utf-8?B?N296SDNqaWlaWGJSS0YwY094a0xodTd3UktWTkRBVVVrTXh1VW9lTTA3dzg3?= =?utf-8?Q?pUQ9mENpXfK+gcwVlGaRFXdFe?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7382a360-e59b-42e8-92e9-08dcdbd81e84 X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2024 14:00:45.2475 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZElz3Isfoy8od8WuCdFp3iYmnWbeqb/9ZIqSIgE2HTj0iWhwkNZUJd7eL7kxoPu/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB9053 Nothing wrong with this, I just didn't had time to double check it myself and then forgotten about it. Going to push it to drm-misc-next. Regards, Christian. Am 23.09.24 um 11:22 schrieb Tommy Chiang: > Ping. > Please let me know if I'm doing something wrong. > > On Mon, Feb 19, 2024 at 11:00 AM Tommy Chiang wrote: >> Kindly ping :) >> >> On Fri, Jan 19, 2024 at 11:33 AM Tommy Chiang wrote: >>> This patch tries to improve the display of the code listing >>> on The Linux Kernel documentation website for dma-buf [1] . >>> >>> Originally, it appears that it was attempting to escape >>> the '*' character, but looks like it's not necessary (now), >>> so we are seeing something like '\*' on the webite. >>> >>> This patch removes these unnecessary backslashes and adds syntax >>> highlighting to improve the readability of the code listing. >>> >>> [1] https://docs.kernel.org/driver-api/dma-buf.html >>> >>> Signed-off-by: Tommy Chiang >>> --- >>> drivers/dma-buf/dma-buf.c | 15 +++++++++------ >>> 1 file changed, 9 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c >>> index 8fe5aa67b167..e083a0ab06d7 100644 >>> --- a/drivers/dma-buf/dma-buf.c >>> +++ b/drivers/dma-buf/dma-buf.c >>> @@ -1282,10 +1282,12 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); >>> * vmap interface is introduced. Note that on very old 32-bit architectures >>> * vmalloc space might be limited and result in vmap calls failing. >>> * >>> - * Interfaces:: >>> + * Interfaces: >>> * >>> - * void \*dma_buf_vmap(struct dma_buf \*dmabuf, struct iosys_map \*map) >>> - * void dma_buf_vunmap(struct dma_buf \*dmabuf, struct iosys_map \*map) >>> + * .. code-block:: c >>> + * >>> + * void *dma_buf_vmap(struct dma_buf *dmabuf, struct iosys_map *map) >>> + * void dma_buf_vunmap(struct dma_buf *dmabuf, struct iosys_map *map) >>> * >>> * The vmap call can fail if there is no vmap support in the exporter, or if >>> * it runs out of vmalloc space. Note that the dma-buf layer keeps a reference >>> @@ -1342,10 +1344,11 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_move_notify, DMA_BUF); >>> * enough, since adding interfaces to intercept pagefaults and allow pte >>> * shootdowns would increase the complexity quite a bit. >>> * >>> - * Interface:: >>> + * Interface: >>> + * >>> + * .. code-block:: c >>> * >>> - * int dma_buf_mmap(struct dma_buf \*, struct vm_area_struct \*, >>> - * unsigned long); >>> + * int dma_buf_mmap(struct dma_buf *, struct vm_area_struct *, unsigned long); >>> * >>> * If the importing subsystem simply provides a special-purpose mmap call to >>> * set up a mapping in userspace, calling do_mmap with &dma_buf.file will >>> -- >>> 2.43.0.381.gb435a96ce8-goog >>>