From: Sameer Pujar <spujar@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <spujar@nvidia.com>, <perex@perex.cz>, <tiwai@suse.com>,
<broonie@kernel.org>, <lgirdwood@gmail.com>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<digetx@gmail.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
<atalambedu@nvidia.com>
Subject: Re: [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding for AHUB
Date: Mon, 10 Feb 2020 17:00:56 +0530 [thread overview]
Message-ID: <af58b6b2-25b2-e968-73c9-d87e1a9e2746@nvidia.com> (raw)
In-Reply-To: <20200206181045.GA31521@bogus>
On 2/6/2020 11:40 PM, Rob Herring wrote:
> External email: Use caution opening links or attachments
>
>
> On Thu, Jan 30, 2020 at 04:03:34PM +0530, Sameer Pujar wrote:
>> Audio Hub (AHUB) comprises a collection of hardware accelerators for audio
>> pre-processing and post-processing and a programmable full crossbar for
>> audio routing across these accelerators. This patch adds YAML schema for DT
>> binding of AHUB and few of its following components. These devices will be
>> registered as ASoC components.
>> * ADMAIF
>> * I2S
>> * DMIC
>> * DSPK
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>> .../bindings/sound/nvidia,tegra186-dspk.yaml | 105 +++++++++++++
>> .../bindings/sound/nvidia,tegra210-admaif.yaml | 165 +++++++++++++++++++++
>> .../bindings/sound/nvidia,tegra210-ahub.yaml | 130 ++++++++++++++++
>> .../bindings/sound/nvidia,tegra210-dmic.yaml | 105 +++++++++++++
>> .../bindings/sound/nvidia,tegra210-i2s.yaml | 112 ++++++++++++++
>> 5 files changed, 617 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml
>> create mode 100644 Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
>> new file mode 100644
>> index 0000000..dc9fef3
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
>> @@ -0,0 +1,105 @@
>> +# SPDX-License-Identifier: (GPL-2.0)
. . .
>> + items:
>> + - description: initial module clock rate
>> +
>> + "#sound-dai-cells":
>> + const: 1
>> +
>> + sound-name-prefix:
>> + $ref: /schemas/types.yaml#/definitions/string
>> + description:
>> + Used as prefix for sink/source names of the component. Must be a
>> + unique string among multiple instances of the same component.
>> + The name can be "DSPK1" or "DSPKx", where x depends on the maximum
> Sounds like a constraint.
Is there a better way to convey the recommended strings above?
All the other comments I will fix in next revision. Thanks.
. . .
next prev parent reply other threads:[~2020-02-10 11:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 10:33 [PATCH v2 0/9] add ASoC components " Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 1/9] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-03 20:19 ` Dmitry Osipenko
2020-02-04 4:24 ` Sameer Pujar
2020-02-06 18:10 ` Rob Herring
2020-02-10 11:30 ` Sameer Pujar [this message]
2020-02-11 18:15 ` Rob Herring
2020-01-30 10:33 ` [PATCH v2 2/9] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-05 17:02 ` Dmitry Osipenko
2020-02-06 11:56 ` Sameer Pujar
2020-02-06 16:49 ` Dmitry Osipenko
2020-02-07 11:03 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 3/9] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-06 16:53 ` Dmitry Osipenko
2020-02-07 11:06 ` Sameer Pujar
2020-02-08 16:19 ` Dmitry Osipenko
2020-01-30 10:33 ` [PATCH v2 4/9] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-06 16:59 ` Dmitry Osipenko
2020-02-06 17:06 ` David Laight
2020-02-07 11:23 ` Sameer Pujar
2020-02-07 11:24 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 5/9] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-01-30 16:22 ` Dmitry Osipenko
2020-02-04 4:29 ` Sameer Pujar
2020-01-30 17:09 ` Dmitry Osipenko
2020-01-30 17:18 ` Dmitry Osipenko
2020-02-04 4:35 ` Sameer Pujar
2020-02-04 4:34 ` Sameer Pujar
2020-01-30 17:25 ` Dmitry Osipenko
2020-01-31 3:12 ` Sameer Pujar
2020-01-31 14:34 ` Dmitry Osipenko
2020-02-04 4:36 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 6/9] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-06 17:15 ` Dmitry Osipenko
2020-02-07 11:26 ` Sameer Pujar
2020-02-07 18:22 ` Dmitry Osipenko
2020-02-10 11:15 ` Sameer Pujar
2020-02-10 12:22 ` Jon Hunter
2020-02-10 14:49 ` Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 8/9] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-01-30 10:33 ` [PATCH v2 9/9] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-06 17:36 ` [PATCH v2 0/9] add ASoC components for AHUB Dmitry Osipenko
2020-02-07 11:30 ` Sameer Pujar
2020-02-07 18:25 ` Dmitry Osipenko
2020-02-10 11:22 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af58b6b2-25b2-e968-73c9-d87e1a9e2746@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=rlokhande@nvidia.com \
--cc=robh@kernel.org \
--cc=sharadg@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®