From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AB78179A7; Thu, 23 Jan 2025 07:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737617601; cv=none; b=tfzq0jBT5T1Xxyg+cAjRuBlNwUFVfQD+oU7oA4daBTOJorMNuCr+jv77VsbpHnINd9f8n0vCRWJ4bJNRXzaxLzRrQlGoSnZRLN9S2W6g5cxSq2+R+92zUrzvyfCD9C8br5s3Oy2Jp1mD7p2sXeIRpid1oiNJWVF2fDyTznmiGfk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737617601; c=relaxed/simple; bh=Aow7+KN6fOUfwrkaPUJswMCuAuxbu4JPHCgYjffwWN8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=T973UNkAU4+Kk8fZOqtcQ5OTabNcxvSVgRrYTn8yPz2bN5nEN1EdYa3kIfcTCmFGKgBwJl1318RK5VQV1eYljq1U/C5BwTOoN8lipeBDRBfUS72p5+qWPM7BwcXLM6zibyHqRs5UVZY3gUPBnz+WYaDOH2RDeoNkQZH1dnj5nPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=lyW10yfs; arc=none smtp.client-ip=80.241.56.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="lyW10yfs" Received: from smtp1.mailbox.org (unknown [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Ydt2x1QV9z9sWp; Thu, 23 Jan 2025 08:33:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1737617593; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pafGZP171TKVXmmTNtfdIkH/JLfRofR6L9YfhmD45jE=; b=lyW10yfsdoKC9khVw9jNmQQjpXd/IpvM0GENMUQG4ShV8XOOqjm/LPE0R7H2th4muEIaww WjWGoh0BAWCFJX9B1qk8du3Kt58QKRUC0Ge1iJGXX7tDbaRkH3zzd1MyOqNFUNE4LWtTnA ZHxS83eGnU7TcUn45ektfe2nG2rLtuoSRq3Z3UwhPFP4g9edzj2p7EtYo96EGGNiALZVWP c9S2JgPiw/mfMODTFYK5JEz9pj8xFBlTNA+rQvHuuNZjMKghxgF7TAx8WQAiasC8dCWHJE a5A29twSa5ZfOqnphJ+ERRMcVAtkimJEY1P1GJC5V+sjGzEqGq0UxhYyBuaG5Q== Message-ID: Subject: Re: [PATCH] drm/sched: Use struct for drm_sched_init() params From: Philipp Stanner Reply-To: phasta@kernel.org To: Boris Brezillon , Philipp Stanner Cc: Alex Deucher , Christian =?ISO-8859-1?Q?K=F6nig?= , Xinhui Pan , David Airlie , Simona Vetter , Lucas Stach , Russell King , Christian Gmeiner , Frank Binns , Matt Coster , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Qiang Yu , Rob Clark , Sean Paul , Konrad Dybcio , Abhinav Kumar , Dmitry Baryshkov , Marijn Suijten , Karol Herbst , Lyude Paul , Danilo Krummrich , Rob Herring , Steven Price , Liviu Dudau , Luben Tuikov , Matthew Brost , Melissa Wen , =?ISO-8859-1?Q?Ma=EDra?= Canal , Lucas De Marchi , Thomas =?ISO-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Sunil Khatri , Lijo Lazar , Mario Limonciello , Ma Jun , Yunxiang Li , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, etnaviv@lists.freedesktop.org, lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, intel-xe@lists.freedesktop.org Date: Thu, 23 Jan 2025 08:33:01 +0100 In-Reply-To: <20250122181227.491b7881@collabora.com> References: <20250122140818.45172-3-phasta@kernel.org> <20250122181227.491b7881@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MBO-RS-ID: 8a70febfe27100aa303 X-MBO-RS-META: sw7fmubqh1x18f97mnek9yippijrrm9p On Wed, 2025-01-22 at 18:16 +0100, Boris Brezillon wrote: > On Wed, 22 Jan 2025 15:08:20 +0100 > Philipp Stanner wrote: >=20 > > =C2=A0int drm_sched_init(struct drm_gpu_scheduler *sched, > > - =C2=A0=C2=A0 const struct drm_sched_backend_ops *ops, > > - =C2=A0=C2=A0 struct workqueue_struct *submit_wq, > > - =C2=A0=C2=A0 u32 num_rqs, u32 credit_limit, unsigned int hang_limit, > > - =C2=A0=C2=A0 long timeout, struct workqueue_struct *timeout_wq, > > - =C2=A0=C2=A0 atomic_t *score, const char *name, struct device *dev); > > + const struct drm_sched_init_params *params); >=20 >=20 > Another nit: indenting is messed up here. That was done on purpose. I never got why so many like to intend to the opening brackets, because: 1. The kernel coding guide line does not demand it 2. It mixes tabs with spaces 3. It doesn't create an identical level of intendation 4. It wastes huge amount of space and does not solve the problem of long names, but might even make it worse: https://elixir.bootlin.com/linux/v6.13- rc3/source/drivers/gpu/drm/scheduler/sched_main.c#L1296