From: Alexandre Mergnat <amergnat@baylibre.com>
To: Ed Tsai <ed.tsai@mediatek.com>, axboe@kernel.dk
Cc: kbusch@kernel.org, liusong@linux.alibaba.com,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com,
peter.wang@mediatek.com, stanley.chu@mediatek.com,
powen.kao@mediatek.com, alice.chao@mediatek.com,
naomi.chu@mediatek.com
Subject: Re: [PATCH v2] blk-mq: check on cpu id when there is only one ctx mapping
Date: Wed, 31 May 2023 11:40:04 +0200 [thread overview]
Message-ID: <af5df07e-f93f-9588-4fdb-b89b37aa28a1@baylibre.com> (raw)
In-Reply-To: <20230531083828.8009-2-ed.tsai@mediatek.com>
On 31/05/2023 10:38, Ed Tsai wrote:
> commit f168420 ("blk-mq: don't redirect completion for hctx withs only
> one ctx mapping") When nvme applies a 1:1 mapping of hctx and ctx, there
> will be no remote request.
>
> But for ufs, the submission and completion queues could be asymmetric.
> (e.g. Multiple SQs share one CQ) Therefore, 1:1 mapping of hctx and
> ctx won't complete request on the submission cpu. In this situation,
> this nr_ctx check could violate the QUEUE_FLAG_SAME_FORCE, as a result,
> check on cpu id when there is only one ctx mapping.
Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
--
Regards,
Alexandre
next prev parent reply other threads:[~2023-05-31 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 8:38 Ed Tsai
2023-05-31 8:38 ` [PATCH v2] " Ed Tsai
2023-05-31 9:40 ` Alexandre Mergnat [this message]
2023-05-31 9:04 ` Stanley Chu
2023-06-11 15:21 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af5df07e-f93f-9588-4fdb-b89b37aa28a1@baylibre.com \
--to=amergnat@baylibre.com \
--cc=alice.chao@mediatek.com \
--cc=axboe@kernel.dk \
--cc=ed.tsai@mediatek.com \
--cc=kbusch@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=liusong@linux.alibaba.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=powen.kao@mediatek.com \
--cc=stanley.chu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®