From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F4BEEB5 for ; Tue, 29 Apr 2025 10:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745924237; cv=none; b=HaGjcQwCt2XFskLmMJ9jWjBjsde5gdpgd+KsgQhLCCgBAst4ilavRn9uKUz5pswPyinEyTv1Ur2yLutwYUXLArqplOkzUHwH+Jjeq+/29CgUpkK/L3Dh2TNMxg/8SmTe/wcvih9nF2f01LHBXtG64ulsN+Y23yaOhRSg0JAs3co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745924237; c=relaxed/simple; bh=Q3IUv1IptwoqxtcxxQnCfv/z8U0PZ19+CT76FvE/MI4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=balg0NoFRt9ba3fz+bh79iqt+v/1+tQHfO/n5QXmAexyd53BAj2qBJL/Orak26y6wCJWhxsh+Ilmd7PF/qhXrfuW33/awv/XuVA4q894bdAHXRjmqM74xyP0v+4V++8JjiXXpAfk1Yq1h8OWZsrjoFYfxbVQU0iUdvqVcTG95eQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FWFVsorX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FWFVsorX" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53T9ahUD025060 for ; Tue, 29 Apr 2025 10:57:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RaIsk3krAO50FiCRlyJ2JPF+E8yq6SBCaXeUPT0TyQY=; b=FWFVsorXnJEHGeOE BInV6qWg8TV+/qsACwdFnOMm5gAf+twqVkl4hO4SkI+wB7oTHLZZgOdNfEAg+y8/ XcdYDs/N8/JkDF0FeWALxtm0DXxFo9QhmTmyLtcgXe4VuwXe0IvuKYPs5AD9fnj0 vSMTcRV0kVxi4MirRxFWiURZTtwj0EVJ97POuxRGf1z9sgGhYSqzXE6edHQblZdE Kq6xd1W0e8WwQfs1B0FuLta1KT/r/IIqzC3vCj8G5Qe41znJyKZ11b9tJBQ0tgis j3zbng/3bdBDYGjxQn545V+MS7UY3igzmJCauyjpF9WMr1+GhUvXhs4wLbV42P8q ylm5UQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 468muqmf6c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 29 Apr 2025 10:57:14 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-47ae537a9d6so8232981cf.3 for ; Tue, 29 Apr 2025 03:57:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745924234; x=1746529034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RaIsk3krAO50FiCRlyJ2JPF+E8yq6SBCaXeUPT0TyQY=; b=d0qvTLb0PuXQkFWoMm8crhUOvM9ov8B4QnT4CBJ2YE0LBF5Hm5tDts7UwOmLBYwMud cUPGxIrMwetiHpfqs/Hd1K+a9eiaZT7IJ54vL1fZdls3vZQAKrpKFVdI7RGm1sW6ejJY x9xvd1nV6W9EckUM87O7O0SmcFYnCRNNzeO1N/0GL2zodC3wCzdBspPnDI0J4e9yYK9c RRbBhhyDPp9mYWIm5BiCWv1qG/nXyp6jnZlQciWhOZ0UDzeQ9EudNOmrK13Sov3BXkot G2KSY82YvLOXREVOdLtr48QwRSGG+IEmo6nLRVMBR4k1/EjVTvNOQJXoOY6725SLyigC oGGw== X-Forwarded-Encrypted: i=1; AJvYcCWcC9cHafJASsHJTW7co/jVR+M5S510QyPQoeudOc878+kBhsC8d5sHapyWcvjTmbcoRTKNj6UZjeC8Kt0=@vger.kernel.org X-Gm-Message-State: AOJu0YyKCdlyQ4qQ3org/4M+jR+ekJAKZID9Vfvs0CKnbvM6Ic6Qcd7r bUobUsChSWZhHBVSJ/xWaeWG8HFzVHqM29OdCYtmiytNmwe1oCyZzLafP0S1vOBGZnFiPdrML0n yN63/Al7YiLLkJc3V9Whtl1eiO1N8KHvRXI3g7I+Y0NF/60Lr+Ya8pXpLvhbwX54= X-Gm-Gg: ASbGnctDoGh8vqn/TWAqpO5g7zxOu6Lsk4Q0r79wWmd14H8bDOdgbzRl45Q+rnZYxwk zykdAB+bdItudd6YrPfdJbUTAdBlPmZ4AsV8cHedqJiUEySWXUEy6Vq9n9KgBNwlZTaNjS1s8QE HImmTnI1jlpRrN89G97Mb5LcCO2w3+LhRfIiW4P7xzA0AuSTLkM1xe2zaBTDOcUluMCezZBRUBF aK6y0NQDOaYOjPV8QZQOM4cKo2Brqz6mFLoUcaoLqapakj3DzsUvpoN/5PkY+g2hypj+nE0KHuk 1ypKtOjRnrenJ2p9lUvwskwrjJ2iPpIs2uqZaPgkyYIwrlyuGlPqkp8/u7PTKgIAng== X-Received: by 2002:a05:622a:1822:b0:475:1c59:1748 with SMTP id d75a77b69052e-488682fca48mr15300731cf.11.1745924233839; Tue, 29 Apr 2025 03:57:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAGDiKbYXYI1YKP03aH36Y/ijWTB1LGNtNpA7B35+8pnVEETxrISLoviJLQZ9SaGON3KQ2KA== X-Received: by 2002:a05:622a:1822:b0:475:1c59:1748 with SMTP id d75a77b69052e-488682fca48mr15300571cf.11.1745924233440; Tue, 29 Apr 2025 03:57:13 -0700 (PDT) Received: from [192.168.65.43] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ace6ecf8cb3sm771648166b.93.2025.04.29.03.57.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 03:57:12 -0700 (PDT) Message-ID: Date: Tue, 29 Apr 2025 12:57:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier To: Prasad Kumpatla , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@oss.qualcomm.com, Mohammad Rafi Shaik References: <20250429092430.21477-1-quic_pkumpatl@quicinc.com> <20250429092430.21477-5-quic_pkumpatl@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250429092430.21477-5-quic_pkumpatl@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI5MDA4MSBTYWx0ZWRfX3jrYMokvAd8i oDByOeJXBN5qQZSR4h6KTNz8P88ma7MzJqmoGoZh9m0Gqc64Axt3sQW2WsCpGaZblNubj4UpeBN /vniUBa3axqqHEhnYwsBm5gp7pDctGkBH1KaDi2vhgByIfHu5m/KIeTXjM2diLzr/kIvPLSI8Ly TWSdnYCXKUeD9mEeftdITOLLFvA0jv/V8kjqHFRsElJ/9Myyy4eALhQr8+TvLMJoEK0kkjHusf6 3Kn3EXYEn9YsiH83nX302wbA1t5q31tYf41hg0di8gg8nwL4jsa/x3YToSNHBMb0YYfh0IK/bnK fCWoraFN7nDyt3Yqsvcw6I44xoms6jyOBqfRX0pqc8guhRuV/KGVcHc6G45CdKofAoYCkq8Zhtc tAC/HKD+kw+q++SLCOw6bXzD8JQ0RagedBBSwSrhCfc1PKgatKeKbIEXHMHBfRmSSuNt9W6X X-Proofpoint-GUID: JnbOeLToZqgef-rIYtvEmW4VmFzRuK1H X-Proofpoint-ORIG-GUID: JnbOeLToZqgef-rIYtvEmW4VmFzRuK1H X-Authority-Analysis: v=2.4 cv=M/5NKzws c=1 sm=1 tr=0 ts=6810b08a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=COk6AnOGAAAA:8 a=hnSZPa_brixH1gHJoW4A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_04,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504290081 On 4/29/25 11:24 AM, Prasad Kumpatla wrote: > From: Mohammad Rafi Shaik > > Add nodes for WSA8830 speakers amplifier on qcs6490-rb3gen2 board. > > Enable lpass_wsa and lpass_va macros along with pinctrl settings > for audio. > > Signed-off-by: Mohammad Rafi Shaik > Co-developed-by: Prasad Kumpatla > Signed-off-by: Prasad Kumpatla > --- > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 70 ++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > index 5fbcd48f2e2d..43cbdbe43afd 100644 > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -19,6 +19,7 @@ > #include "pm7325.dtsi" > #include "pm8350c.dtsi" > #include "pmk8350.dtsi" > +#include "qcs6490-audioreach.dtsi" > > /delete-node/ &ipa_fw_mem; > /delete-node/ &rmtfs_mem; > @@ -765,6 +766,44 @@ > }; > }; > > +&lpass_dmic01_clk { > + drive-strength = <8>; > + bias-disable; > +}; > + > +&lpass_dmic01_data { > + bias-pull-down; > +}; > + > +&lpass_dmic23_clk { > + drive-strength = <8>; > + bias-disable; > +}; > + > +&lpass_dmic23_data { > + bias-pull-down; > +}; > + > +&lpass_va_macro { > + status = "okay"; > +}; > + > +&lpass_wsa_macro { > + status = "okay"; > +}; > + > +&lpass_wsa_swr_clk { > + drive-strength = <2>; > + slew-rate = <1>; > + bias-disable; > +}; > + > +&lpass_wsa_swr_data { > + drive-strength = <2>; > + slew-rate = <1>; > + bias-bus-hold; > +}; These properties should likely be moved to sc7280.dtsi > + > &mdss { > status = "okay"; > }; > @@ -1039,6 +1078,31 @@ > status = "okay"; > }; > > +&swr2 { > + status = "okay"; Please keep a newline between the properties and first subnode [...] > &tlmm { > gpio-reserved-ranges = <32 2>, /* ADSP */ > <48 4>; /* NFC */ > @@ -1095,6 +1159,12 @@ > */ > bias-pull-up; > }; > + > + sw_ctrl: sw-ctrl-state { Not only non-descript, this node is not used Konrad