From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB7FC21FF48 for ; Tue, 7 Oct 2025 12:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759841714; cv=none; b=fKGD7qOxNMKXKNYraQs1OzwxP/ETNNzM/VveL/1XtFqFt5XITIMzxw+WdAeM28W9tUvWy8t8GRT/slRur17d4L8WifnEvn5RlX/TMFDzGxEkpc6NMEEMh5tANUGyRoitGbmFalrO36GhPhKKN4kBh/lG6Ow/9bHEkEck2wSLjMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759841714; c=relaxed/simple; bh=sskRBZIq3ZV/qQ1N2FKi74Cz4KCa9C3J5w4ehhfzGn4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CIb9WMWJTqKzKd7Sa1DngilqE65GdGecBqDTbjLMWRw+rXhLMriGcS9uC/qeYGN8r8rdZXUVVuuQcBmTXamz7qZGgJKdm5KRRiTN7ktkdk9FKXNkjnSRnZ343r5aF+NTKKa8MJxWcDiEhuKEARVuuU7F+Q3xFAxnnVCMaFwNnqU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KJOeaBtU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KJOeaBtU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759841711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JObPDM43kbrRGTVx2qicxdWSHWXv4jr/i/WMIAB1AqU=; b=KJOeaBtUmy1sGi+3AtW7QjtVJcRVGFdp/84lKPZRo+ApPzZeyoGkFIrscoXdo2dShFVhak ISPISpRxQg97lrL3o1iF1twusvAC1im4Lt0XJkybplCNxQRPswALwI8JF5GAMTQbmHANp0 3IskintkSTV7Cwz38HMdR4ClQfr7STo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-Vwcr7kWLOoGlU18bvXrERw-1; Tue, 07 Oct 2025 08:55:10 -0400 X-MC-Unique: Vwcr7kWLOoGlU18bvXrERw-1 X-Mimecast-MFC-AGG-ID: Vwcr7kWLOoGlU18bvXrERw_1759841709 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-46e39567579so27201375e9.0 for ; Tue, 07 Oct 2025 05:55:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759841709; x=1760446509; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JObPDM43kbrRGTVx2qicxdWSHWXv4jr/i/WMIAB1AqU=; b=cGFdYb11xr34xr2SAElqmrlFP8pGTjcGRKrxcr1rWxuzpKPhDNvNK/+d0JNATRpwpe x8WJX+TU2R5G2/nj9fwTa3Zpdchp/SQ9bwT3cYIsegePlSDODBr+332cQ/wleK59mBi9 07TvicbTAky8PT+efDwOJoU49r24/PUxMA6yhINpRw/NjKIv4wMdYtLpXJ8KzXU+m1Rk 5Yd5fwps8pbIfooaGB73FZrrh8BRL6Aoc854+lDnXZcSt+G8PEzwNBT+8LBWODJl/qap 9xR7C5WhqCzMBTfCSi4ji40sup+pmoaxU9q2RIZmVr40uMhY43CAgxv2q4uqgD6hjY3I FAWA== X-Forwarded-Encrypted: i=1; AJvYcCVoMKJBQ2WPtHk7DWRF0+xQuiVjIBkdodr0O2zzjNGWH7UaYann57JTsiAAFMW3kzh8Cyofw7UrYYfqjsI=@vger.kernel.org X-Gm-Message-State: AOJu0YxOX+T6rVN77Qx7h7+vtJ4PEGiobf4PIade8tEkM1c8ybuL9VrO APFwqcYD1ZZ0QJ21RqAkDHrKMYVckvctLOoVid78bdIKRydRTNvYArvjGJGQSFbRGAJo9lqIFCd HpTlo8AsQncaAnv9JQtnS6TY9aySSI0+dlP31Fhunb1c/yd9rmzNGp8Y+IgAguvvrPg== X-Gm-Gg: ASbGncs4zSB+hnt8mAttRgqhUFLmsz12IHSbjqgz2g398+79E99mP2nB8BG729s5nKe +qzvpXa451vfdSsRz/LLaoL884Sb6t2ncHV1zRHQzAhDqYv0isHvtXmosxFpMCvVW/iC/+oWb7Y HF21StaIXem3xYeOsgx2MruE/mjs9VHQUdV4cGGivdxWWnb2suK3gk1Qz4h2ZwCNq63Z7SY0fHw Ly2kC2SM2FAvONu2vbXpse6al25w4dF/vAkSd6jwc00QFqkn1s8U530X7+iZmCq+dVCLsRKOZhB sPudJjgUv2SJ6nhJj4hPRaiwPOnM9P5qG/9bLhz2QfYhPcvoLbEJ4+T0afIlTmvB22VqIKF3o+W ER9z75Fa9n1SV2Fm/2g== X-Received: by 2002:a05:600c:83cf:b0:46e:38f7:625f with SMTP id 5b1f17b1804b1-46e7110e4edmr114208145e9.10.1759841709262; Tue, 07 Oct 2025 05:55:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEf+yr0C4xLuJM/GLkBC+pknfkcsjQX8ZNgouB/KZMa7StJI4sxuc/r62BoMnwYLfDYtvHz+g== X-Received: by 2002:a05:600c:83cf:b0:46e:38f7:625f with SMTP id 5b1f17b1804b1-46e7110e4edmr114207955e9.10.1759841708852; Tue, 07 Oct 2025 05:55:08 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8e9703sm25776462f8f.30.2025.10.07.05.55.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 05:55:08 -0700 (PDT) Message-ID: Date: Tue, 7 Oct 2025 14:55:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] wireguard: allowedips: Use kfree_rcu() instead of call_rcu() To: Fushuai Wang , Jason@zx2c4.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org Cc: wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251005133936.32667-1-wangfushuai@baidu.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251005133936.32667-1-wangfushuai@baidu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/5/25 3:39 PM, Fushuai Wang wrote: > Replace call_rcu() + kmem_cache_free() with kfree_rcu() to simplify > the code and reduce function size. > > Signed-off-by: Fushuai Wang > --- > drivers/net/wireguard/allowedips.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireguard/allowedips.c b/drivers/net/wireguard/allowedips.c > index 09f7fcd7da78..5ece9acad64d 100644 > --- a/drivers/net/wireguard/allowedips.c > +++ b/drivers/net/wireguard/allowedips.c > @@ -48,11 +48,6 @@ static void push_rcu(struct allowedips_node **stack, > } > } > > -static void node_free_rcu(struct rcu_head *rcu) > -{ > - kmem_cache_free(node_cache, container_of(rcu, struct allowedips_node, rcu)); > -} > - > static void root_free_rcu(struct rcu_head *rcu) > { > struct allowedips_node *node, *stack[MAX_ALLOWEDIPS_DEPTH] = { > @@ -271,13 +266,13 @@ static void remove_node(struct allowedips_node *node, struct mutex *lock) > if (free_parent) > child = rcu_dereference_protected(parent->bit[!(node->parent_bit_packed & 1)], > lockdep_is_held(lock)); > - call_rcu(&node->rcu, node_free_rcu); > + kfree_rcu(node, rcu); > if (!free_parent) > return; > if (child) > child->parent_bit_packed = parent->parent_bit_packed; > *(struct allowedips_node **)(parent->parent_bit_packed & ~3UL) = child; > - call_rcu(&parent->rcu, node_free_rcu); > + kfree_rcu(parent, rcu); > } > > static int remove(struct allowedips_node __rcu **trie, u8 bits, const u8 *key, This is net-next material, and net-next is currently closed for the merge window, but I guess Jason will take this patch in his tree. Cheers, Paolo