From: "Arnd Bergmann" <arnd@arndb.de>
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/applicom:Removed the unused variable byte_reset_it
Date: Tue, 08 Oct 2024 07:41:26 +0000 [thread overview]
Message-ID: <af62c108-0f76-4df2-a56d-0b08d26853e9@app.fastmail.com> (raw)
In-Reply-To: <20241008072825.12937-1-zhujun2@cmss.chinamobile.com>
On Tue, Oct 8, 2024, at 07:28, Zhu Jun wrote:
> Remove unused variable and redundant readb in ac_register_board
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
This is probably intentional, as the readb() can both have side-effects
on the device and serialize the device against a previous instructions.
It would have been nice to have a comment in there, but since that
is 30 year old code, I doubt we get more information on it now.
Just don't remove those.
Arnd
next prev parent reply other threads:[~2024-10-08 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 7:28 Zhu Jun
2024-10-08 7:41 ` Arnd Bergmann [this message]
2024-10-08 7:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af62c108-0f76-4df2-a56d-0b08d26853e9@app.fastmail.com \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®