From: haver <haver@linux.vnet.ibm.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org
Subject: Re: [PATCH 0/3] Some small clean-ups in genwqe
Date: Mon, 08 Jan 2018 13:57:45 +0100 [thread overview]
Message-ID: <af63380f8477e6672e542359f5ce7386@linux.vnet.ibm.com> (raw)
In-Reply-To: <20171214143406.14652-1-gpiccoli@linux.vnet.ibm.com>
Hi Guilherme,
On 2017-12-14 15:34, Guilherme G. Piccoli wrote:
> This patchset is composed by 3 small clean-ups to genwqe
> driver. It aims to improve code clarity, by removing unused
> stuff and make the code follow some conventions.
>
> It was built and tested against v4.15-rc3, and aims merge
> in v4.16 if possible.
>
> Thanks in advance!
>
> Guilherme G. Piccoli (3):
> genwqe: Remove unused variable and rename function
> genwqe: Make defines uppercase
> genwqe: Remove unused parameter in some functions
>
> drivers/misc/genwqe/card_base.c | 16 ++++++++--------
> drivers/misc/genwqe/card_base.h | 20 +++++++++-----------
> drivers/misc/genwqe/card_ddcb.c | 22 +++++++++++-----------
> drivers/misc/genwqe/card_debugfs.c | 2 +-
> drivers/misc/genwqe/card_dev.c | 19 ++++++++-----------
> drivers/misc/genwqe/card_utils.c | 25 +++++++++----------------
> 6 files changed, 46 insertions(+), 58 deletions(-)
Looks ok to me. Thanks for the contribution.
Regards
Frank
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
prev parent reply other threads:[~2018-01-08 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 14:34 Guilherme G. Piccoli
2017-12-14 14:34 ` [PATCH 1/3] genwqe: Remove unused variable and rename function Guilherme G. Piccoli
2017-12-14 14:34 ` [PATCH 2/3] genwqe: Make defines uppercase Guilherme G. Piccoli
2017-12-14 14:34 ` [PATCH 3/3] genwqe: Remove unused parameter in some functions Guilherme G. Piccoli
2018-01-08 12:57 ` haver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af63380f8477e6672e542359f5ce7386@linux.vnet.ibm.com \
--to=haver@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome