From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753469AbdDKBoq (ORCPT ); Mon, 10 Apr 2017 21:44:46 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:5321 "EHLO dggrg01-dlp.huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752644AbdDKBon (ORCPT ); Mon, 10 Apr 2017 21:44:43 -0400 Subject: Re: [PATCH 4/4] f2fs: avoid frequent checkpoint during f2fs_gc To: Jaegeuk Kim , , , References: <20170411001308.12881-1-jaegeuk@kernel.org> <20170411001308.12881-4-jaegeuk@kernel.org> From: Chao Yu Message-ID: Date: Tue, 11 Apr 2017 09:42:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170411001308.12881-4-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0B0207.58EC34FC.0014,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: de243fb15187c82bc1104ddb615dac2a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/4/11 8:13, Jaegeuk Kim wrote: > Now we're doing SSR aggressively more than ever before, so once we reach to > the reserved_segment, f2fs_balance_fs will call f2fs_gc, which triggers > checkpoint everytime. We actually must avoid that. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index e2f9b2b12b74..4a720f3394d9 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -966,7 +966,11 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, bool background) > * threshold, we can make them free by checkpoint. Then, we > * secure free segments which doesn't need fggc any more. > */ > - ret = write_checkpoint(sbi, &cpc); > + if (prefree_segments(sbi)) { > + ret = write_checkpoint(sbi, &cpc); > + if (ret) > + goto stop; > + } > if (ret) > goto stop; We don't need redundant check here? Otherwise, this patchset looks good to me, anyway please add: Reviewed-by: Chao Yu Thanks, > if (has_not_enough_free_secs(sbi, 0, 0)) >