From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63366C433DB for ; Mon, 18 Jan 2021 20:04:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 343C82229C for ; Mon, 18 Jan 2021 20:04:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394143AbhARUEY (ORCPT ); Mon, 18 Jan 2021 15:04:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437783AbhARUDr (ORCPT ); Mon, 18 Jan 2021 15:03:47 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9F03C061573 for ; Mon, 18 Jan 2021 12:03:06 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id v67so25807800lfa.0 for ; Mon, 18 Jan 2021 12:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7alCZU74sYXZV+z2uTznaZthaKp3BCYeASOmff2ui7k=; b=SrYXliND6Oh+2oSBueZymwtXnV3QfzIfdTGfexRuvg5TStwvicae9b2Lo9AlyzB/BY BuZRORCvr9q0XlU4F/RkPQPYA0ECgzcupN+N+LHX2W/vB/Q9O4e/Vv6ucXkqjKkOZkZM nx0dntzNLu0tQtHuZIjvm60/HUsSMCK7mvptfhUx+96Yna6CiO+8dGIBfD01PFZyeB9g h4bKTbjLlxM+lv33mlhhWXZV2uuEbgULiP30fo6Bg/zaaQ3FbVYwXE6ixt4aVSJo+fL1 2WtcNCVdw3AcQBUjj+sJJE8SGkl73GYZPINwg04imZfeH5c4C5dBvtERa26lIuzuV2mF YBWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7alCZU74sYXZV+z2uTznaZthaKp3BCYeASOmff2ui7k=; b=dlZHCXFKQQt93r0NJrcpGUtT6F43wVwQLFo1Ab9nIDvkhbi7JQqOuTxWjQ8BbGZwlr 9jSjSh+o0NUKevA5iA+j5ndjUPQOktOSW7byypf9qGEGaW39ty64hcKc8zNBBw3Y6XsK nXJu0Kr2+JUgm7XpPCXflClXCG2NW6Ui/usa6xiOeTjA1ghgpGdEdlxGnxWR+g9fSsN4 z4lRzV4osjoLT4m4tWU687n1szQBWfBbAv5B9G5/UKi5jgxuNZlwDXLwi7wHYO0Snl80 /crQkBV6cg7nqFjQOz6+kwmXzk2Q9KzTcjTyXfufMGlm22VmMr+R8kjKp16lw55t9vAd 4CNQ== X-Gm-Message-State: AOAM531wVUOv+SpDlgmQtBR3MBrfEk/LnJElXbqd7nTJWFYNEc7X9e9S j3KhgMXyNoINTqQbmAg1tJoMng== X-Google-Smtp-Source: ABdhPJwF51/aX4FTbG5kCK1BB4KSS9O5EWPwO2EInwvKz65Wd6gW5mAeIodUdbkWqYzZ4oJ4hIgsXw== X-Received: by 2002:a19:997:: with SMTP id 145mr355979lfj.588.1611000185480; Mon, 18 Jan 2021 12:03:05 -0800 (PST) Received: from [192.168.118.216] ([85.249.43.69]) by smtp.gmail.com with ESMTPSA id i19sm1999072lfj.212.2021.01.18.12.03.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 12:03:04 -0800 (PST) Subject: Re: [PATCH v4] media: ov8856: Configure sensor for GRBG Bayer for all modes To: Robert Foss Cc: Dongchun Zhu , Mauro Carvalho Chehab , linux-media , linux-kernel , Sakari Ailus , Bingbu Cao , Tomasz Figa References: <20210118190132.1045913-1-robert.foss@linaro.org> <357f6099-7a36-bbf6-723c-a4ca76835d00@linaro.org> From: Andrey Konovalov Message-ID: Date: Mon, 18 Jan 2021 23:03:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Robert, On 18.01.2021 22:54, Robert Foss wrote: > I was going for row, but got a bit wild with the Ctrl-C + Ctrl-V, is Yeah... "raw" was in my original text > that alright with you? Other than these few raw vs row mistypes the patch is fine for me. My Reviewed-by tag holds. Thanks, Andrey > On Mon, 18 Jan 2021 at 20:28, Andrey Konovalov > wrote: >> >> Oops.. I've missed a few mistypes >> >> On 18.01.2021 22:18, Andrey Konovalov wrote: >>> Hi Robert, >>> >>> Thanks for you patch! >>> >>> Reviewed-by: Andrey Konovalov >>> >>> On 18.01.2021 22:01, Robert Foss wrote: >>>> The previously added modes 3264x2448 & 1632x1224 are actually >>>> configuring the sensor for BGGR mode, this is an issue since >>>> the mode that is exposed through V4L incorrectly is set as GRBG. >>>> >>>> This patch fixes the issue by moving the output crop window of >>>> internal sensor ISP uses by one row, which means that the Bayer >>>> pattern of the output is changed. >>>> >>>> From: >>>> row 1: B G B G B G ... >>>> row 2: G R G R G R ... >>>> raw 3: B G B G B G ... >> - row >>>> ... >>>> >>>> To: >>>> raw 2: G R G R G R ... >> - row >>>> raw 3: B G B G B G ... >> - row >> >> Thanks, >> Andrey >> >>>> ... >>>> >>>> Signed-off-by: Robert Foss >>>> Suggested-by: Andrey Konovalov >>>> --- >>>> >>>> Changes since v1: >>>> - Sakari: Added mode information to ov8856_mode struct >>>> - Sakari: enum_mbus_code updated >>>> >>>> Changes since v2: >>>> - Andrey: Switched approach to changing the sensor configuration >>>> to yield identical Bayer modes for all modes >>>> >>>> Changes since v3: >>>> - Andrey: Improve commit msg to explain Bayer shift better >>>> >>>> drivers/media/i2c/ov8856.c | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/media/i2c/ov8856.c b/drivers/media/i2c/ov8856.c >>>> index 2f4ceaa80593..8a355135c7db 100644 >>>> --- a/drivers/media/i2c/ov8856.c >>>> +++ b/drivers/media/i2c/ov8856.c >>>> @@ -428,7 +428,7 @@ static const struct ov8856_reg mode_3264x2448_regs[] = { >>>> {0x3810, 0x00}, >>>> {0x3811, 0x04}, >>>> {0x3812, 0x00}, >>>> - {0x3813, 0x02}, >>>> + {0x3813, 0x01}, >>>> {0x3814, 0x01}, >>>> {0x3815, 0x01}, >>>> {0x3816, 0x00}, >>>> @@ -821,7 +821,7 @@ static const struct ov8856_reg mode_1632x1224_regs[] = { >>>> {0x3810, 0x00}, >>>> {0x3811, 0x02}, >>>> {0x3812, 0x00}, >>>> - {0x3813, 0x02}, >>>> + {0x3813, 0x01}, >>>> {0x3814, 0x03}, >>>> {0x3815, 0x01}, >>>> {0x3816, 0x00}, >>>>