From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: maud_spierings@hotmail.com,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/4] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver
Date: Mon, 25 Nov 2024 13:21:01 +0100 [thread overview]
Message-ID: <af6f4b48-7e9b-4561-818d-150fe954d821@oss.qualcomm.com> (raw)
In-Reply-To: <20241124-asus_qcom_display-v3-2-002b723b1920@hotmail.com>
On 24.11.2024 11:00 AM, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maud_spierings@hotmail.com>
>
> The Asus vivobook s15 uses the ATNA56AC03 panel.
> This panel is controlled by the atna33xc20 driver instead of the generic
> edp-panel driver
>
> Signed-off-by: Maud Spierings <maud_spierings@hotmail.com>
> ---
> arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> index f25991b887de3fca0092c5f81c881c5d8bd71aac..dbc85aff50a95bfc2ac11528d1901979ec7b1501 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> @@ -407,9 +407,13 @@ &mdss_dp3 {
>
> aux-bus {
> panel {
> - compatible = "edp-panel";
> + compatible = "samsung,atna56ac03", "samsung,atna33xc20";
> + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
> power-supply = <&vreg_edp_3p3>;
>
> + pinctrl-0 = <&edp_bl_en>;
> + pinctrl-names = "default";
> +
> port {
> edp_panel_in: endpoint {
> remote-endpoint = <&mdss_dp3_out>;
> @@ -475,6 +479,16 @@ &pcie6a_phy {
> status = "okay";
> };
>
> +&pmc8380_3_gpios {
> + edp_bl_en: edp-bl-en-state {
> + pins = "gpio4";
> + function = "normal";
> + power-source = <0>;
This is <1> on other boards.. I'm guessing you verified this against
at-boot values?
Konrad
next prev parent reply other threads:[~2024-11-25 12:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 10:00 [PATCH v3 0/4] Asus vivobook s15 improvements Maud Spierings via B4 Relay
2024-11-24 10:00 ` [PATCH v3 1/4] dt-bindings: display: panel: samsung,atna56ac03: Document ATNA56AC03 Maud Spierings via B4 Relay
2024-11-24 11:00 ` Krzysztof Kozlowski
2024-11-24 12:29 ` Maud Spierings
2024-11-24 16:00 ` Krzysztof Kozlowski
2024-11-24 16:00 ` Krzysztof Kozlowski
2024-11-25 17:19 ` Doug Anderson
2024-11-24 10:00 ` [PATCH v3 2/4] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver Maud Spierings via B4 Relay
2024-11-25 12:21 ` Konrad Dybcio [this message]
2024-11-25 17:43 ` Maud Spierings
2024-11-24 10:00 ` [PATCH v3 3/4] arm64: dts: qcom: x1e80100-vivobook-s15: Add lid switch Maud Spierings via B4 Relay
2024-11-25 12:22 ` Konrad Dybcio
2024-11-24 10:01 ` [PATCH v3 4/4] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth Maud Spierings via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af6f4b48-7e9b-4561-818d-150fe954d821@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maud_spierings@hotmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®