mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eugen Hristev <eugen.hristev@linaro.org>
To: Rosen Penev <rosenp@gmail.com>, dmaengine@vger.kernel.org
Cc: Vinod Koul <vkoul@kernel.org>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:MICROCHIP AT91 DMA DRIVERS"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit
Date: Fri, 21 Nov 2025 10:52:03 +0200	[thread overview]
Message-ID: <af7028da-34cc-42e5-8768-b6218ebae3f2@linaro.org> (raw)
In-Reply-To: <20251106022405.85604-2-rosenp@gmail.com>



On 11/6/25 04:24, Rosen Penev wrote:
> size_t formats under 32-bit evaluate to the same thing and GCC does not
> warn against it. Not the case with 64-bit.
> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Reviewed-by: Eugen Hristev <eugen.hristev@linaro.org>

> ---
>  drivers/dma/at_hdmac.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
> index 2d147712cbc6..7d226453961f 100644
> --- a/drivers/dma/at_hdmac.c
> +++ b/drivers/dma/at_hdmac.c
> @@ -887,7 +887,7 @@ atc_prep_dma_interleaved(struct dma_chan *chan,
>  	first = xt->sgl;
>  
>  	dev_info(chan2dev(chan),
> -		 "%s: src=%pad, dest=%pad, numf=%d, frame_size=%d, flags=0x%lx\n",
> +		 "%s: src=%pad, dest=%pad, numf=%zu, frame_size=%zu, flags=0x%lx\n",
>  		__func__, &xt->src_start, &xt->dst_start, xt->numf,
>  		xt->frame_size, flags);
>  
> @@ -1174,7 +1174,7 @@ atc_prep_dma_memset_sg(struct dma_chan *chan,
>  	int			i;
>  	int			ret;
>  
> -	dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%zx f0x%lx\n", __func__,
> +	dev_vdbg(chan2dev(chan), "%s: v0x%x l0x%x f0x%lx\n", __func__,
>  		 value, sg_len, flags);
>  
>  	if (unlikely(!sgl || !sg_len)) {
> @@ -1503,7 +1503,7 @@ atc_prep_dma_cyclic(struct dma_chan *chan, dma_addr_t buf_addr, size_t buf_len,
>  	unsigned int		periods = buf_len / period_len;
>  	unsigned int		i;
>  
> -	dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@%pad - %d (%d/%d)\n",
> +	dev_vdbg(chan2dev(chan), "prep_dma_cyclic: %s buf@%pad - %d (%zu/%zu)\n",
>  			direction == DMA_MEM_TO_DEV ? "TO DEVICE" : "FROM DEVICE",
>  			&buf_addr,
>  			periods, buf_len, period_len);


  reply	other threads:[~2025-11-21  8:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06  2:24 [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Rosen Penev
2025-11-06  2:24 ` [PATCH dmaengine 1/2] dmaengine: at_hdmac: fix formats under 64-bit Rosen Penev
2025-11-21  8:52   ` Eugen Hristev [this message]
2025-11-06  2:24 ` [PATCH dmaengine 2/2] dmaengine: at_hdmac: add COMPILE_TEST support Rosen Penev
2025-11-21  8:52   ` Eugen Hristev
2025-11-22  9:30 ` [PATCH dmaengine 0/2] dmaengine: at_hdmac: support COMPILE_TEST Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af7028da-34cc-42e5-8768-b6218ebae3f2@linaro.org \
    --to=eugen.hristev@linaro.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=rosenp@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®