From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Claudiu Beznea <Claudiu.Beznea@microchip.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ASoC: dt-bindings: Add bindings for Cadence I2S-MC controller
Date: Wed, 22 May 2024 09:30:21 +0200 [thread overview]
Message-ID: <af72c0c1-144d-4f04-86ba-d85e5125d261@linaro.org> (raw)
In-Reply-To: <0e7496c4-7dfc-404d-944c-a1869389722b@linaro.org>
On 08/05/2024 10:03, Krzysztof Kozlowski wrote:
> On 08/05/2024 09:04, Xingyu Wu wrote:
>> Add bindings for the Multi-Channel I2S controller of Cadence.
>>
>> The Multi-Channel I2S (I2S-MC) implements a function of the
>> 8-channel I2S bus interfasce. Each channel can become receiver
>> or transmitter. Four I2S instances are used on the StarFive
>> JH8100 SoC. One instance of them is limited to 2 channels, two
>> instance are limited to 4 channels, and the other one can use
>> most 8 channels. Add a unique property about
>> 'starfive,i2s-max-channels' to distinguish each instance.
>>
>> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
>
>
>> +
>> + starfive,i2s-max-channels:
>> + description:
>> + Number of I2S max stereo channels supported on the StarFive
>> + JH8100 SoC.
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + enum: [2, 4, 8]
>> +
>> +allOf:
>> + - $ref: dai-common.yaml#
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: starfive,jh8100-i2s
>> + then:
>> + required:
>> + - starfive,i2s-max-channels
>> + else:
>> + properties:
>> + starfive,i2s-max-channels: false
>> +
>> +required:
>
> I asked to put it after properties: block, not after allOf:. See
> example-schema for preferred order. Why? Because we are used to it and
> it makes reading the schema easier for us.
>
> Rest looks good, so with the re-order:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Since you do not plan to fix it and already started pinging mark, I
retract my review.
Unreviewed-by.
Implement the feedback I already asked you BEFORE.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-22 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 7:04 [PATCH v3 0/2] Add Cadence I2S-MC controller driver Xingyu Wu
2024-05-08 7:04 ` [PATCH v3 1/2] ASoC: dt-bindings: Add bindings for Cadence I2S-MC controller Xingyu Wu
2024-05-08 8:03 ` Krzysztof Kozlowski
2024-05-22 7:30 ` Krzysztof Kozlowski [this message]
2024-05-22 8:24 ` Xingyu Wu
2024-05-08 7:04 ` [PATCH v3 2/2] ASoC: cdns: Add drivers of Cadence Multi-Channel I2S Controller Xingyu Wu
2024-05-22 2:33 ` Xingyu Wu
2024-05-22 7:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af72c0c1-144d-4f04-86ba-d85e5125d261@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®