From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Manish Pandey <quic_mapa@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_cang@quicinc.com,
quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com,
quic_bhaskarv@quicinc.com, quic_narepall@quicinc.com,
quic_rampraka@quicinc.com, quic_ahari@quicinc.com
Subject: Re: [PATCH V2] arm64: dts: qcom: qcm6490: Add UFS nodes
Date: Thu, 21 Dec 2023 14:58:55 +0100 [thread overview]
Message-ID: <af7becf0-84b7-4630-9c37-0e6296c41f74@linaro.org> (raw)
In-Reply-To: <20231221111959.12970-1-quic_mapa@quicinc.com>
On 21.12.2023 12:19, Manish Pandey wrote:
> Add UFS host controller and Phy nodes for
> Qualcomm qcm6490 Board.
>
> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>
> ---
> Changes from v1:
> - updated with correct patchset
Well no, this clearly hasn't been compile-tested..
Please also include the board name in the subject
(qcm6490: -> qcm6490-idp:)
>
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index 03e97e27d16d..51efd46b576c 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -440,6 +440,25 @@
> status = "okay";
> };
>
> +&ufs_mem_hc {
> + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&vreg_l7b_2p9>;
> + vcc-max-microamp = <800000>;
> + vccq-supply = <&vreg_l9b_1p2>;
> + vccq-max-microamp = <900000>;
> + vccq2-supply = <&vreg_l9b_1p2>;
> + vccq2-max-microamp = <900000>;
These regulators should get regulator-allow-set-load since the
UFS driver expects to perform current/mode setting ops on them
Konrad
prev parent reply other threads:[~2023-12-21 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 11:19 Manish Pandey
2023-12-21 13:58 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af7becf0-84b7-4630-9c37-0e6296c41f74@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_ahari@quicinc.com \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_mapa@quicinc.com \
--cc=quic_narepall@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®