From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 888273AC0D3 for ; Mon, 8 Jun 2026 10:35:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780914960; cv=none; b=B4bXC+y5oc5Nbwcuvf66GRAdwk1C5C6nguCIJMaHAX2Z3rPJDCF5xaIriKKJVOgxTZ1/4FaF2679/4tYmemH1+qjL03KLEq8syFfsvtYaH4+EU9iwmCr6dmSPg37vRL4FUHc31TlHo6i1cu+vdhM+BjG68rX2PU++WB+zOeuKN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780914960; c=relaxed/simple; bh=0+d8hdZrhAVzwAoofJ6eUvBRfYq1O84m3xZM5f7b63I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ahD/67Dr2TC5h2pX/JZVq6fPnNQHeKr1U1MltgFo/VkvgWFfyArJIS9DLX50JUElpUJmx5hRFAFxZr8kL7rFX/5Q5qzBkWioEtTJBlN30tktmwDsHDBf1fQphMfr4EVZrUD7jFSVDGNV88h7kZHs09JuG+Ha8/mbU8mlzwgFPfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hDEjA9zm; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hDEjA9zm" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2bf77d4a4e2so26559815ad.1 for ; Mon, 08 Jun 2026 03:35:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780914957; x=1781519757; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=o7rfjN8gvyO5A78qI/nvGvuW8Ai7Jn9ZQl2KKv15ni4=; b=hDEjA9zmnWg2MOV3Nia13b0rLudUNVxoWi7q8Xrhi7A16rxx/mtsIrEzMpscUS61Wy X6grKekCYsNfLyc23jB1+8YfBvpODu8wnt6fslnhuJa2HH9b4hjtCkDMzsRkv2rf2WpG MqZy9DZybxj0LUmuRN/F9QrFeiNhs4vt9yrWswqoHxhIx0UmTe5cIiE4mL8wUi2S2uOD UPn+RoCZw22ChZqvTiATVvjGaUsSvj/Jd5B2wrMCDH9SZ38XeOi8RH56FztBYVCq5Ifz KYGKACiBfxrEeq06nNGz7Omnv5tbNZzUu22XCLU0S9VmkrMkLjndp13Zd2f9f1y810xz 2RmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780914957; x=1781519757; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o7rfjN8gvyO5A78qI/nvGvuW8Ai7Jn9ZQl2KKv15ni4=; b=IQokOgGVUZ9q+otXJ2I63H40LiYWtt/MS8/lQOPdiLmu0JkNJLykw3+cmLpYvgajRT oMFlP2h2kH4gVF0CdO2+xtAKdwTn2SUIN1elRC8E1nEzAJ3ILkhgm3ngx2s7qqNmE6IA 8BL8GuTWc/Pw4Oa8Xai6K9ZrpSuAFEXvJ4eqJ7pyUSrrLq6mm549Qs8uxXDb3TvfSQ1q 94xZxhlKZOg/hjUOz4x1/ekV2DgGvxQCvJe8C/P/IivycOUS3RBA4nbwjCRKdJ8dhL+5 q2KjgoEaQ7u/dQXjAS9WlHUtmwSKopQG9/I7ZECzoin99tKYKYHPaLZUCWB6kFzbczdx +jRA== X-Forwarded-Encrypted: i=1; AFNElJ/gNMCRkpdpRDE8glwcNro1Rt3Kxj/dYXGBYkzTy0nyMizmxUGeF/4n0ptruoxLJNTlmXYehhYRejZDvd4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2xbcms2a2c3LWXiJWPbj9gP3PyY7cR2L1OBRiT14q+JVoTytw 37SYelD/TRJoFqt58ohK5fEfjmwMoLW8me4V1ipdRng2nX7jCLRVCVWc X-Gm-Gg: Acq92OGhj1kbzKClxHC0C11gT2y5CdlSbtSdPnwRKnrMHEbNqUNYXRFCHwujgL85t9g omRjNpnb2v5qb6jhYNv5TytWLO1QiM5nXTzRfbVaz/5LjEdqpWMjhC5K0J8NHkqXL35+9K5Snkv grOhV/VBPxxXAfQVRdH0HhWoNmhI7DR6f7KgmSoNg4YsyKERVFs6jgKm1flPxGgWvNn/vN5lYuy /NZyLcvCvhjRV4/vHeMz0qYPTb/MC+KDp7NPo+jDSV6Eq4VKWay7yuPYJlmhTh7SHc18Cy2sVl3 dtxOlnnvNcmiwq4eHAbVmsiRt4jhFqq3TTocbaV6jt8juXsJvKuEfkPO0z08dM4+uP22vwmjZZi RdhwosBareeyLH6XRYtdeNfyOeQaQ83wug17JjOJ/I5xWDEfn8Mw0kldStzR78KaX3KbI2JeEPN dpu85D0ehcAmlBBhXpjaPSh/0uKwvLIuxeU4xNApiz3qeCEUfnqAkYR0Kv4yZ85HWjPgsPOs8OJ CqJDr8mWNh8LsY= X-Received: by 2002:a17:903:8c3:b0:2bd:d6f1:3388 with SMTP id d9443c01a7336-2c1ec9271edmr112272305ad.28.1780914956983; Mon, 08 Jun 2026 03:35:56 -0700 (PDT) Received: from [192.168.0.100] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16649ca4dsm176604255ad.76.2026.06.08.03.35.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 03:35:56 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 18:35:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/5] drm/verisilicon: introduce per-variant hardware ops table To: Icenowy Zheng , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260608023237.305036-1-a0987203069@gmail.com> <20260608023237.305036-4-a0987203069@gmail.com> <399cd127b56b4a2fb3161865a681606e04e6b2c6.camel@iscas.ac.cn> <98eb7772-257f-4fa7-8e9b-51a635cb12dd@gmail.com> <340c213ca47dabb8bc3d260311e2fd4818bd8001.camel@iscas.ac.cn> Content-Language: en-US From: Joey Lu In-Reply-To: <340c213ca47dabb8bc3d260311e2fd4818bd8001.camel@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/8/2026 6:06 PM, Icenowy Zheng wrote: > 在 2026-06-08一的 17:45 +0800，Joey Lu写道： >>>> diff --git a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> index 1f2be41ae496..75bc36a078f7 100644 >>>> --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>> @@ -53,12 +53,6 @@ static int >>>> vs_primary_plane_atomic_check(struct >>>> drm_plane *plane, >>>>    return 0; >>>>   } >>>> >>>> -static void vs_primary_plane_commit(struct vs_dc *dc, unsigned >>>> int >>>> output) >>>> -{ >>>> - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), >>>> - VSDC_FB_CONFIG_EX_COMMIT); >>>> -} >>>> - >>>>   static void vs_primary_plane_atomic_enable(struct drm_plane >>>> *plane, >>>>       struct >>>> drm_atomic_commit >>>> *atomic_state) >>>>   { >>>> @@ -69,13 +63,8 @@ static void >>>> vs_primary_plane_atomic_enable(struct >>>> drm_plane *plane, >>>>    unsigned int output = vcrtc->id; >>>>    struct vs_dc *dc = vcrtc->dc; >>>> >>>> - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), >>>> - VSDC_FB_CONFIG_EX_FB_EN); >>>> - regmap_update_bits(dc->regs, VSDC_FB_CONFIG_EX(output), >>>> -    VSDC_FB_CONFIG_EX_DISPLAY_ID_MASK, >>>> - >>>> VSDC_FB_CONFIG_EX_DISPLAY_ID(output)); >>>> - >>>> - vs_primary_plane_commit(dc, output); >>>> + if (dc->funcs->plane_enable_ex) >>>> + dc->funcs->plane_enable_ex(dc, output); >>> Please note that all theae codes are for primary planes, maybe the >>> helper should be named mentioning primary. Overlay planes will need >>> a >>> different codepath because they change different registers. >>> >>> Thanks, >>> Icenowy >> Understood. To avoid confusion, I will rename `plane_enable_ex`, >> `plane_disable_ex`, and `plane_update_ex` to `primary_plane_enable`, >> `primary_plane_disable`, and `primary_plane_update` in `vs_dc_funcs`, >> `vs_dc8200.c`, and `vs_primary_plane.c`. > Maybe keep the `_ex` here as some operations is still on the common > codepath? > > Thanks, > Icenowy Got it. I’ll keep the `_ex` suffix in place. That way it’s consistent with the common codepath operations, and the inline comments already makes the intent clear. >>>>   } >>>> >>>>   static void vs_primary_plane_atomic_disable(struct drm_plane >>>> *plane, >>>> @@ -88,10 +77,8 @@ static void >>>> vs_primary_plane_atomic_disable(struct >>>> drm_plane *plane, >>>>    unsigned int output = vcrtc->id; >>>>    struct vs_dc *dc = vcrtc->dc; >>>> >>>> - regmap_set_bits(dc->regs, VSDC_FB_CONFIG_EX(output), >>>> - VSDC_FB_CONFIG_EX_FB_EN); >>>> - >>>> - vs_primary_plane_commit(dc, output); >>>> + if (dc->funcs->plane_disable_ex) >>>> + dc->funcs->plane_disable_ex(dc, output); >>>>   } >>>> >>>>   static void vs_primary_plane_atomic_update(struct drm_plane >>>> *plane, >>>> @@ -133,18 +120,11 @@ static void >>>> vs_primary_plane_atomic_update(struct drm_plane *plane, >>>>    regmap_write(dc->regs, VSDC_FB_STRIDE(output), >>>>         fb->pitches[0]); >>>> >>>> - regmap_write(dc->regs, VSDC_FB_TOP_LEFT(output), >>>> -      VSDC_MAKE_PLANE_POS(state->crtc_x, state- >>>>> crtc_y)); >>>> - regmap_write(dc->regs, VSDC_FB_BOTTOM_RIGHT(output), >>>> -      VSDC_MAKE_PLANE_POS(state->crtc_x + state- >>>>> crtc_w, >>>> - state->crtc_y + state- >>>>> crtc_h)); >>>>    regmap_write(dc->regs, VSDC_FB_SIZE(output), >>>>         VSDC_MAKE_PLANE_SIZE(state->crtc_w, state- >>>>> crtc_h)); >>>> >>>> - regmap_write(dc->regs, VSDC_FB_BLEND_CONFIG(output), >>>> -      VSDC_FB_BLEND_CONFIG_BLEND_DISABLE); >>>> - >>>> - vs_primary_plane_commit(dc, output); >>>> + if (dc->funcs->plane_update_ex) >>>> + dc->funcs->plane_update_ex(dc, output, state); >>>>   } >>>> >>>>   static const struct drm_plane_helper_funcs >>>> vs_primary_plane_helper_funcs = {