From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90891C433FE for ; Thu, 24 Feb 2022 14:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235331AbiBXOEx (ORCPT ); Thu, 24 Feb 2022 09:04:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230080AbiBXOEv (ORCPT ); Thu, 24 Feb 2022 09:04:51 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9342A20E782 for ; Thu, 24 Feb 2022 06:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=In1tFsWPrLFrqNLMpx3GuPpIs5m9KwMwJez6fPga1iE=; b=BpkO8GxoEqhNunPCOAzYt6PR1/ SOmbhli+VLn7MtqDLxOVi3SlHmSOQpdOn2CWgXV1/nQ4wfbLn+BOs7bs16b2eJzlOEcaWf/9uGJLR gXj5kxSXJ9/zDijlpvsHt9yivArF0dr1/83eJUP3U7Tn8yI7X6RSVBCOHV7WzoH8Db8loGXkmnNh9 QwzIx49MiMjY6UcYAffpZ7+GWjvivfVAPRqlLst7Qtt+NkRniKjWJp7SxvbzcQP+EMBmpxNpFS4nd QUF+wopZlxV2NHZleVdduUg701TnxMfHJ57twpKh3UcleHexxxhy0QUpxFnfFh4a5D7egA2zb+iFC JTm0aAwQ==; Received: from [2a01:799:95e:a400:cca0:57ac:c55d:a485] (port=64706) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNEjC-0005ye-7d; Thu, 24 Feb 2022 15:04:18 +0100 Message-ID: Date: Thu, 24 Feb 2022 15:04:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] drm/repaper: Use format helper for xrgb8888 to monochrome conversion To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <20220223193735.213185-1-javierm@redhat.com> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20220223193735.213185-1-javierm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 23.02.2022 20.37, skrev Javier Martinez Canillas: > There is now a drm_fb_xrgb8888_to_mono_reversed() helper function to do > format conversion from XRGB8888 to reversed monochrome. > > Use that helper and remove the open coded version in the repaper driver. > > Signed-off-by: Javier Martinez Canillas > --- Tested-by: Noralf Trønnes Reviewed-by: Noralf Trønnes Do you have commit rights and will apply this patch? Noralf.