From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753834AbcHQHUt (ORCPT ); Wed, 17 Aug 2016 03:20:49 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:59311 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752700AbcHQHUs (ORCPT ); Wed, 17 Aug 2016 03:20:48 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68e-f79cb6d000006cfe-36-57b4104d3c5d Subject: Re: [PATCH V4]mmc: dw_mmc-k3: UHS-SD card for Hisilicon Hikey To: Jinguojun , Shawn Lin , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, wsa+renesas@sang-engineering.com, arnd@arndb.de, rmk+kernel@arm.linux.org.uk References: <1470276973-41683-1-git-send-email-kid.jin@hisilicon.com> <74c80b1c-5570-0ee0-4132-ff703d8d5eb4@hisilicon.com> <06f63a26-251d-5ba8-f877-dae75aa8e362@rock-chips.com> <1b724dde-863d-fa28-fa58-595c34c1bef2@samsung.com> <5d5551f4-e49c-d005-eb0b-9ca472a8d249@hisilicon.com> Cc: guodong.xu@linaro.org, kongfei@hisilicon.com, suzhuangluan@hisilicon.com From: Jaehoon Chung Message-id: Date: Wed, 17 Aug 2016 16:20:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-reply-to: <5d5551f4-e49c-d005-eb0b-9ca472a8d249@hisilicon.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsWyRsSkUNdXYEu4Qe9RTYuTT9awWfyddIzd 4v+dHlaLP5cXMFps/P6P2WLT42usFpd3zWGzOPK/n9Fi84eXbBZ3nqxntej+aWdxfG24Rd85 dwdej5bmHjaP378mMXo8nruR3WPxnpdMHneu7WHz2Lyk3uPvrP0sHs8Wrmfx+LxJLoAzissm JTUnsyy1SN8ugSvjdNMFpoLjchWPJ7xlb2DcLdHFyMkhIWAicbltFQuELSZx4d56ti5GLg4h gRWMEueeNwE5HGBFXTM9IeKzGCVmzl7GBtLAKyAo8WPyPRaQGmYBdYkpU3Ihah4wSnxee5Ed pEZYwE3i0bVWMFtEYCOTxLuPFhBFX5gkls2/ADaIWcBH4vr8t2BXsAnoSGz/dpwJYoGdxL7/ Z5hBbBYBVYnFC++xgtiiAmESJ8+dAxvKKeAo8fbTdUaIOfISB688ZwFZICEwl0Pix9xtLBDN AhLfJh9igfhGVmLTAWaIjyUlDq64wTKBUWwWkn9mIfwzC8nUBYzMqxhFUwuSC4qT0ouM9IoT c4tL89L1kvNzNzECI/r0v2d9OxhvHrA+xCjAwajEwztjxuZwIdbEsuLK3EOMpkBHTGSWEk3O B6aNvJJ4Q2MzIwtTE1NjI3NLMyVx3gSpn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGBcd 1DAQu33Nud1VS0XNpvjXc3aHjc+zHdOdt4kZKd3bGq4rkPLBZfqsHUyzXkXNuJntkFwpcWn1 r1vdpsr3Zmsmms+tuxPtc6lwZurTnY/+6CrYCSV1iwsV/Ki+muewM93QNygrt3vdxjCrsPSY q7yFb1PLRefU7V8yWXjF55DgRav3mNzTVmIpzkg01GIuKk4EAH/PGV3jAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLKsWRmVeSWpSXmKPExsVy+t9jQV1fgS3hBgufKlmcfLKGzeLvpGPs Fv/v9LBa/Lm8gNFi4/d/zBabHl9jtbi8aw6bxZH//YwWmz+8ZLO482Q9q0X3TzuL42vDLfrO uTvwerQ097B5/P41idHj8dyN7B6L97xk8rhzbQ+bx+Yl9R5/Z+1n8Xi2cD2Lx+dNcgGcUQ2M NhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAVysplCXm lAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0JgusxMkADCWsYM043XWAqOC5X8XjCW/YGxt0SXYwc HBICJhJdMz27GDmBTDGJC/fWs3UxcnEICcxilJg5exkbSIJXQFDix+R7LCD1zALqElOm5ELU PGCU+Lz2IjtIjbCAm8Sja61gtojARiaJdx8tIIq+MEksm38BbBCzgI/E9flvWUBsNgEdie3f jjNBLLCT2Pf/DDOIzSKgKrF44T1WEFtUIEzi5LlzYEM5BRwl3n66zggxR17i4JXnLBMYgc5E uG8Wwn2zkFQtYGRexSiRWpBcUJyUnmuUl1quV5yYW1yal66XnJ+7iRGcNJ5J72A8vMv9EKMA B6MSD+8Nq83hQqyJZcWVuYcYJTiYlUR4//NtCRfiTUmsrEotyo8vKs1JLT7EaAp070RmKdHk fGBCyyuJNzQ2MTOyNDI3tDAyNlcS5338f12YkEB6YklqdmpqQWoRTB8TB6dUAyN3QOpr1XU3 8zPZvPaKSa2bxvhe2kowRbjr/ozXqpJy0laHT9a4b9ibvazH4cI2i96JC0xO/tzptkm+Wsdl 4sb24vJpOd3KX1TfWTI8fdbaLi98WlOPLdShf1f1qedrvk+de/54aFHEphnM7OreddPM8qdc VLu6M1Ez1W97xEntJR+8XAwedyqxFGckGmoxFxUnAgAH2KKkMAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/17/2016 03:11 PM, Jinguojun wrote: > Hi > > On 2016/8/8 18:46, Jaehoon Chung wrote: >> Hi, >> >> On 08/08/2016 06:10 PM, Shawn Lin wrote: >>> Hi guy, >>> >>> On 2016/8/8 15:10, Jinguojun wrote: >>>> Hi,maintainers >>>> >>>> Pls help to review code,this is the newest patch after your advise >> >> Subject.. >> >> s/UHS-SD/UHS-I/ >> >>>> >>> >>> Please give Jaehoon more time to review your patch before sending a >>> ping or resending one(~2 weeks), as it's only four days(weekend >>> included) since v4 was done....IMHO, it's quite bold... >>> >>>> Thx > I apologize for my rudeness. Don't mind. Feel free to tell me anytime! :) >>>> On 2016/8/4 10:16, Jin Guojun wrote: >>>>> mmc: dw_mmc-k3: Hisilicon Hikey have no tuning function in >>>>> dw_mmc-k3.c,so we must do the tuning function stub when we init UHS card. >>>>> >>> >>> Hrmmm.... remove "mmc: dw_mmc-k3:" from the meat of commit msg。 >>> >>> And you do nothing for dw_mci_hi6220_execute_tuning, why? >>> Could you elaborate more.. >>> >>> > OK I'll remove the mmc: dw_mmc-k3:,Then Hikey can't support SDR104,so we only support SDR12 SDR25 SD50,and we do not need to do tuning for these modes. >>>>> V1:add .prepare_command in dw_mmc.c >>>>> V2:delete .prepare_command, add err = 0 in dw_mci_execute_tuning >>>>> V3:delete err = 0 in dw_mci_execute_tuning,add .execute_tuning in >>>>> dw_mmc-k3.c >>>>> V4:add "linux-mmc@vger.kernel.org", patch version, Changelog, etc.. >>> >>> The changelog is totally wrong, namely it should not be listed in the >>> commit msg... >>> > OK I'll delete this part >>>>> >>>>> Signed-off-by: Jin Guojun >>>>> --- >>>>> drivers/mmc/host/dw_mmc-k3.c | 6 ++++++ >>>>> 1 file changed, 6 insertions(+) >>>>> >>>>> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c >>>>> index 8e9d886..6247894 100644 >>>>> --- a/drivers/mmc/host/dw_mmc-k3.c >>>>> +++ b/drivers/mmc/host/dw_mmc-k3.c >>>>> @@ -131,11 +131,17 @@ static void dw_mci_hi6220_set_ios(struct dw_mci *host, struct mmc_ios *ios) >>>>> host->bus_hz = clk_get_rate(host->biu_clk); >>>>> } >>>>> >>>>> +static int dw_mci_hi6220_execute_tuning(struct dw_mci_slot *slot, u32 opcode) >>>>> +{ >>>>> + return 0; >>>>> +} >> >> >> All of UHS-I cards didn't need to do tuning sequence on your SoC? it's strange. >> >> I think we can fix more exactly in dw_mmc.c >> As i know, some UHS cards don't need to send the tuning sequence. >> (If i know wrong, let me know plz.) >> >> But just skipping execute_tuning..I think it's not correct. >> >> Best Regards, >> Jaehoon Chung >> > We cant support SDR104 currently.We only turn on SDR12 SDR25 SDR50. I will send the patch for execute_tuning in dwmmc.c within this week. After that, could you check that patch? I will add your email to CC. How about? I think it's better than using the dummy function. :) Best Regards, Jaehoon Chung >>>>> + >>>>> static const struct dw_mci_drv_data hi6220_data = { >>>>> .caps = dw_mci_hi6220_caps, >>>>> .switch_voltage = dw_mci_hi6220_switch_voltage, >>>>> .set_ios = dw_mci_hi6220_set_ios, >>>>> .parse_dt = dw_mci_hi6220_parse_dt, >>>>> + .execute_tuning = dw_mci_hi6220_execute_tuning, >>>>> }; >>>>> >>>>> static const struct of_device_id dw_mci_k3_match[] = { >>>>> >>>> >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>> >>> >> >> >> . >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >