mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Almeida" <andrealmeid@igalia.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>,
	linux-kbuild@vger.kernel.org, kernel-dev@igalia.com,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: Re: [PATCH v4 08/12] mips: Get rid of custom mips ABIs for syscall tables
Date: Wed, 12 Aug 2026 14:36:50 -0300	[thread overview]
Message-ID: <af92da09-4e89-4ec1-8286-01c0526f8c51@igalia.com> (raw)
In-Reply-To: <a1d0c110-d23a-418e-9155-23b13b590445@app.fastmail.com>

Em 12/08/2026 10:11, Arnd Bergmann escreveu:
> On Wed, Aug 12, 2026, at 14:53, André Almeida wrote:
>> Em 12/08/2026 06:16, Arnd Bergmann escreveu:
>>> On Wed, Aug 12, 2026, at 05:33, André Almeida wrote:
>>> I had expected you to use 'common' instead of '32' and '64' here. Since you
>>> did not combine the n32/n64 tables, this makes no practical difference,
>>> but it still makes the tables look different from all the other ones, and
>>> it means that the following patch to unify the tables is harder to
>>> validate since the inputs are still not line-identical.
>>>
>>> Is there some reason you went with this approach?
>>>
>> Ops, no good reason here, it was a mistake :) I will redo it to use
>> common from [1, 211] syscalls.
> 
> I can see this done in one of two ways:
> 
> a) make everything in the mips specific files 'common' and keep the
>     three separate files
> b) make only the first 211 syscalls in n32/n64 common, using compat
>     entries where those differ, then use 32/64 as the ABI for the
>     ones where the numbers went out of sync, and merge the two
>     files into one.
> 
> I've added Thomas Bogendörfer to Cc, he may have an opinion one
> way or the other.
> 

I believe b) is the best option here, as we can remove one more common 
file. I will add Thomas Bogendörfer in Cc for the next round.

  reply	other threads:[~2026-08-12 17:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12  3:32 [PATCH v4 00/12] syscalls: Add a shared table for all archs André Almeida
2026-08-12  3:32 ` [PATCH v4 01/12] syscalls: Make --abis parsing more robust André Almeida
2026-08-12  3:32 ` [PATCH v4 02/12] syscalls: Create unified partial table for all archs André Almeida
2026-08-12  3:32 ` [PATCH v4 03/12] scripts/syscall.tbl: Use the common table André Almeida
2026-08-12  3:33 ` [PATCH v4 04/12] arm: Use the common syscall table André Almeida
2026-08-12  3:33 ` [PATCH v4 05/12] s390: " André Almeida
2026-08-12  3:33 ` [PATCH v4 06/12] sparc: " André Almeida
2026-08-12  3:33 ` [PATCH v4 07/12] mips: Remove duplicated syscallnr.sh André Almeida
2026-08-12  3:33 ` [PATCH v4 08/12] mips: Get rid of custom mips ABIs for syscall tables André Almeida
2026-08-12  9:16   ` Arnd Bergmann
2026-08-12 12:53     ` André Almeida
2026-08-12 13:11       ` Arnd Bergmann
2026-08-12 17:36         ` André Almeida [this message]
2026-08-12  3:33 ` [PATCH v4 09/12] mips: Use the common syscall table André Almeida
2026-08-12  3:33 ` [PATCH v4 10/12] syscalls: Add an option for offsetting the common table André Almeida
2026-08-12  3:33 ` [PATCH v4 11/12] alpha: Define entry point for set_mempolicy_home_node syscall André Almeida
2026-08-12  3:33 ` [PATCH v4 12/12] alpha: Use the common syscall table André Almeida
2026-08-12  9:09   ` Arnd Bergmann
2026-08-12 12:55     ` André Almeida

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af92da09-4e89-4ec1-8286-01c0526f8c51@igalia.com \
    --to=andrealmeid@igalia.com \
    --cc=arnd@arndb.de \
    --cc=kernel-dev@igalia.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=nathan@kernel.org \
    --cc=tglx@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®