From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D73D42AA2 for ; Sat, 8 Feb 2025 16:01:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739030473; cv=none; b=IEXyo9dRMtMnqciL+FoNe+y/4LX3yUFQlUMYBLvNePM3UDWWy3QSfmYxYcbO0Jrvqr3wCtIo905ZldBL9Lm5DcKeUZtrIIkxZBZLt8j0LpYRQ+C09csuaj4R6S6RQecqJz0tOQCmkTIRaHGVx9t+Phib4k+LVGD8q1M5X09yMTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739030473; c=relaxed/simple; bh=Fg2JiZMmnK61MdHBlVq6XhIHAvPp2DJJ0WNo23hTHWY=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=aIXB+ZJ7EJmOP8c4Dvr84Cm89i/6GrMce5DQSGIo6NidSMbv2xGAD8bj6G5AVzSXNxr5b+VtHnZfU4v1MbDkBBX4svfe7edTMeY7Tubvb7TU6SY8XoP0RFLxVFzKsTa9OCqz16RUa+RFbJ1REMas/mfykGJnCtDu21udQmmhXSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=sQbTsvoQ; arc=none smtp.client-ip=212.227.17.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="sQbTsvoQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1739030448; x=1739635248; i=markus.elfring@web.de; bh=Fg2JiZMmnK61MdHBlVq6XhIHAvPp2DJJ0WNo23hTHWY=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=sQbTsvoQxKsSobMXrvfOogsNZ9YnCYEQpBCFx4l/wbkoJPk6SZ4tOVNTGq7Hyw6h LX5dMdKoHDRBB2aS1cPGKmf5DMp8aAmVKbrvy+fx9ZKv0f5aL9LoqLThZCu1a3VED RQF6vrLTqZppfe0FZGTl2mqY1QUB1pyVgaP8hkITP9mFfNu33dEnPWdD0XW3xy37n khj52+hT0yu8OWFaLaC+WDKtAf9C94ZLjxrJUGG9HHr+0Uhd5QLorLrA1+XHIC4Jc f13v9uHV65/TkP1ubYEwEyC0Bw+jUjp4gRHhCbmEVIA6EOqMj4UKwR23SuTng3b5s 502ko6QrH2BJqGjSJg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.29] ([94.31.93.11]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mmyr7-1swxyp0sFj-00adxo; Sat, 08 Feb 2025 17:00:48 +0100 Message-ID: Date: Sat, 8 Feb 2025 17:00:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Charles Han , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, David Airlie , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Michal Simek , Simona Vetter , Thomas Zimmermann , Tomi Valkeinen , Vishal Sagar Cc: LKML References: <20250208100323.11625-1-hanchunchao@inspur.com> Subject: Re: [PATCH] drm: xlnx: zynqmp_dpsub: Add NULL checks in zynqmp_audio_init() Content-Language: en-GB From: Markus Elfring In-Reply-To: <20250208100323.11625-1-hanchunchao@inspur.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:tWX9Yp8k5eSbPZvEe2id20EXKcSWu0YgkMbUFdQ9fiDBwmd7chG aHIDVWOgnhfr1Y/Qs+a8/X6Jkb2yrGjp+HFoHBLLHyyJV3HU2ydAdv3+3LO40Aat4Zv0nTD o219p7G2i35zOVhOGkxri+ihhfn1hNu+KmiEp6UinsfF9WaDOhFjF/OCOCw9NAEc4OhQw00 u9LxQ0dZreHMHPeJWHs7A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:C1ZI3h6gqPU=;snI/KsuJJ/Q8OOSdU3CR16eexbD h8c8Orq/SOJWvE1jHI/JMoMrPa1WTbypZR0oe6dw8GxlJudbkjF/PrnfssXN3qq/W19Mjwmca PEZ4PgRNS1tUknEGsAcQqS5UXcYUDNZscwjcWvGzzYYFs1ZCHRUdtFLbAXGOsTUbHBCQfk/yd dEIc8ITQkB+/URdqrf7uRJUN2ank2dbtLEEMgFs4Zw281TQFBmAT9ZZcNBBAsN4olqRZCw8CR j1IxHzjrH9bN+f/MEQEP1vBVhAZYVVsZ7qeq0SU4n3h0CNcXfdXm4NzS1BEKWZ4Fg961g/QVh 3bSgidHbieeg0PUHHJ+I342fUtMXLslDIklkSZbL6Xly8kaFQ4POBazZfi1bwDuawWY4tdrox u0sZ9sb5dN9CTD04l/VtJO5zVQb9sddORBFqpIPoUEDEYr0VA9K60UiFK9W8Aj1VI17j9nQfY 9Pds11TcPRsA4fD/ZkZykQSOPmkIETptHgkYhChKK0MMiyNxouk0Vy2l+vFzvT8KQaOEbHwnb ShFODt/ov9Z/jGAzatuW92lCbIBWxhB3V6IPoIBtUpHuemKONTIaFiQE5BYmc5MOIAQ9Bq3mP /GH6gx9kuNyGLjH3VAnBmyNG2x2kgHhy/tolCxZMWw1LZvKz4AYKHod5GfoRJTSXu8oIufmwj bzYtlzX4rCm4qZhxO5L70cbWluVfsZcSRQFKT/NaTNpAi5Mj+V8RCwS5OdaAzskgz1ZO4AwZA hj5QyCEZfj4ypmXDeg5OJkoRlByKt1Xqin0XXCBAVy3LswsiF29qUEJnEefHlk01f40l0wzTG Bn99OU41C3beD1nTTVonoVl6sRuJ9A9RBXIHFl/CwDFu0C2XiNgcEVbuUnkEaF7rwab/pL+PB qvBewYHOvPSpObbRDx3V2c9mneIInT93ekqYFFVeP5BQyQNj1I2mEaKrf/a5+YTDdfyV/0kV5 mziKkcNLqaxWyx+/xVUegDQ85dISON2tZRQofXaqHCzWzj/UJ3jyTbbsaPtKdHMcVbtG6EXdQ 9Z5qjkk4IukIz3sKHE5Q/f1qiy5xasMvcdg9/42nAVomhCOUsytwmMDr9liIpwHIgxdif3OgU wI5HczhtZwx8hsgVYyKswm3h8+0kqF7soEd5cAbQl1vpOtQcple8eaDfaI5E8mAy709Qt1Fzp ztpjKGk7DM1YWQ/W3ODVxQv/SWXjf8pMIA31qjhEu9phDA54tgAbuQ4LlTulD9rnChQLHZcX0 mzpH25f5KjNJRgmESZr0/PjT/Xx0p/7s1rSkb0YGWW2m+aa/h4nnMj2wqE61iJi3WTqGSl1Xc u3ptGKSOvJG9vNrpbXeK7aBMpAmRrGbvEjcYqEFVVSZpEI/yXnzpcX1T0e+JfeR0PabU0EJgi FtNCHOC3ZOc25teLO1+s8kcni4VvISRL5sHcxNUSaUShPkbp4FATMDxIDe7PMP8kFBg6bJ7rI ArRpObA== > devm_kasprintf() can return a NULL pointer on failure,but this > returned value in zynqmp_audio_init() is not checked. Another wording suggestion: devm_kasprintf() calls can return null pointers on failure. But some return values were not checked in zynqmp_audio_init(). > Add NULL check in zynqmp_audio_init(), to handle kernel NULL > pointer dereference error. Thus add three checks to prevent null pointer dereferences. Regards, Markus