From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbdAECjT (ORCPT ); Wed, 4 Jan 2017 21:39:19 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:37598 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdAECjM (ORCPT ); Wed, 4 Jan 2017 21:39:12 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <8a7ae6da362502c34df0560fc442d97f> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] mmc: dw_mmc: Fix some coding style To: Jaehoon Chung , Ziyuan Xu , ulf.hansson@linaro.org References: <1483534376-6521-1-git-send-email-xzy.xu@rock-chips.com> Cc: shawn.lin@rock-chips.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: Date: Thu, 5 Jan 2017 10:24:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/5 9:19, Jaehoon Chung wrote: > Hi, > > On 01/04/2017 09:52 PM, Ziyuan Xu wrote: >> Let's fix the warnings from checkpatch.pl: >> >> - line over 80 characters; >> - block comments should align the * on each Lines; >> - statements not starting on a tabstop. > > If there is no critical problem, > I think that current codes are keeping better than changing. > When someone contribute the patches relevant to these, it can be also changed, > (It's more meaningful.) > Indeed. Moreover, it breaks the git-blame history when we need to review how the code had been developing.. > Best Regards, > Jaehoon Chung > >> >> Signed-off-by: Ziyuan Xu >> --- >> >> drivers/mmc/host/dw_mmc.c | 33 +++++++++++++++++---------------- >> 1 file changed, 17 insertions(+), 16 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index ed63237..a8efe3f 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -94,7 +94,8 @@ struct idmac_desc { >> >> __le32 des1; /* Buffer sizes */ >> #define IDMAC_SET_BUFFER1_SIZE(d, s) \ >> - ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | (cpu_to_le32((s) & 0x1fff))) >> + ((d)->des1 = ((d)->des1 & cpu_to_le32(0x03ffe000)) | \ >> + (cpu_to_le32((s) & 0x1fff))) >> >> __le32 des2; /* buffer 1 physical address */ >> >> @@ -2733,16 +2734,16 @@ static void dw_mci_init_dma(struct dw_mci *host) >> struct device_node *np = dev->of_node; >> >> /* >> - * Check tansfer mode from HCON[17:16] >> - * Clear the ambiguous description of dw_mmc databook: >> - * 2b'00: No DMA Interface -> Actually means using Internal DMA block >> - * 2b'01: DesignWare DMA Interface -> Synopsys DW-DMA block >> - * 2b'10: Generic DMA Interface -> non-Synopsys generic DMA block >> - * 2b'11: Non DW DMA Interface -> pio only >> - * Compared to DesignWare DMA Interface, Generic DMA Interface has a >> - * simpler request/acknowledge handshake mechanism and both of them >> - * are regarded as external dma master for dw_mmc. >> - */ >> + * Check tansfer mode from HCON[17:16] >> + * Clear the ambiguous description of dw_mmc databook: >> + * 2b'00: No DMA Interface -> Actually means using Internal DMA block >> + * 2b'01: DesignWare DMA Interface -> Synopsys DW-DMA block >> + * 2b'10: Generic DMA Interface -> non-Synopsys generic DMA block >> + * 2b'11: Non DW DMA Interface -> pio only >> + * Compared to DesignWare DMA Interface, Generic DMA Interface has a >> + * simpler request/acknowledge handshake mechanism and both of them >> + * are regarded as external dma master for dw_mmc. >> + */ >> host->use_dma = SDMMC_GET_TRANS_MODE(mci_readl(host, HCON)); >> if (host->use_dma == DMA_INTERFACE_IDMA) { >> host->use_dma = TRANS_MODE_IDMAC; >> @@ -2756,9 +2757,9 @@ static void dw_mci_init_dma(struct dw_mci *host) >> /* Determine which DMA interface to use */ >> if (host->use_dma == TRANS_MODE_IDMAC) { >> /* >> - * Check ADDR_CONFIG bit in HCON to find >> - * IDMAC address bus width >> - */ >> + * Check ADDR_CONFIG bit in HCON to find >> + * IDMAC address bus width >> + */ >> addr_config = SDMMC_GET_ADDR_CONFIG(mci_readl(host, HCON)); >> >> if (addr_config == 1) { >> @@ -3337,8 +3338,8 @@ int dw_mci_runtime_resume(struct device *dev) >> * Restore the initial value at FIFOTH register >> * And Invalidate the prev_blksz with zero >> */ >> - mci_writel(host, FIFOTH, host->fifoth_val); >> - host->prev_blksz = 0; >> + mci_writel(host, FIFOTH, host->fifoth_val); >> + host->prev_blksz = 0; >> >> /* Put in max timeout */ >> mci_writel(host, TMOUT, 0xFFFFFFFF); >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards Shawn Lin