From: Bart Van Assche <bvanassche@acm.org>
To: 刘喜鑫 <liuxixin@kylinos.cn>, linux-block <linux-block@vger.kernel.org>
Cc: axboe <axboe@kernel.dk>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 回复: Re: 回复: Re: [PATCH v1] block/mq-deadline: hold elevator_lock in debugfs next_rq show
Date: Thu, 23 Jul 2026 10:38:33 -0700 [thread overview]
Message-ID: <af98cabf-89a6-41b0-9929-ec3e24783503@acm.org> (raw)
In-Reply-To: <4vwol95qmudj-4vww18fcfi2w@nsmail8.2--kylin--1>
On 7/22/26 7:37 PM, 刘喜鑫 wrote:
> That approach did not take effect, so I switched to the current patch.
>
> I have verified the current patch, and the KASAN crash is gone with it.
The following is missing from your patch:
- An explanation why q->elevator_lock is locked instead of dd->lock. I
think that you are misunderstanding the purpose of these locks.
- An explanation why locking q->elevator_lock from inside a debugfs
attribute neither triggers lock inversion nor a deadlock.
- An explanation why the dd and per_prio assignments happen with the
lock held. This seems unnecessary to me because neither
e->elevator_data nor the address of dd->per_prio[] are modified while
the mq-deadline debugfs attributes exist. Did I perhaps overlook
something?
Bart.
next parent reply other threads:[~2026-07-23 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4vwol95qmudj-4vww18fcfi2w@nsmail8.2--kylin--1>
2026-07-23 17:38 ` Bart Van Assche [this message]
2026-07-27 9:45 ` Xixin Liu
2026-07-27 10:25 ` Xixin Liu
2026-07-21 6:30 Xixin Liu
2026-07-22 17:44 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af98cabf-89a6-41b0-9929-ec3e24783503@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxixin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®