From: Stefan Wahren <wahrenst@gmx.net>
To: Triet Hoang <triet.hoang.dev@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] firmware: raspberrypi: Handle device registration errors
Date: Sat, 19 Sep 2026 18:05:49 +0200 [thread overview]
Message-ID: <af98e96e-5a2c-486c-b8ea-3ae3fdab8eb0@gmx.net> (raw)
In-Reply-To: <20260919034840.28593-2-triet.hoang.dev@gmail.com>
Am 19.09.26 um 05:48 schrieb Triet Hoang:
> Check the return value of platform_device_register_data() when
> registering the hwmon and clock devices. Propagate registration failures
> to the firmware probe instead of silently ignoring them.
>
> Use local platform device pointers so the global pointers are only
> updated after successful registration. If clock registration fails,
> unregister the previously registered hwmon device before releasing the
> firmware instance.
>
> Keep the existing behavior of skipping hwmon registration when the
> RPI_FIRMWARE_GET_THROTTLED request fails.
>
> Fixes: 70eea1bbb556 ("firmware: raspberrypi: Register hwmon driver")
> Fixes: 91f2cf4a6b21 ("firmware: raspberrypi: register clk device")
> Signed-off-by: Triet Hoang <triet.hoang.dev@gmail.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
next prev parent reply other threads:[~2026-09-19 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 3:48 [PATCH 0/2] " Triet Hoang
2026-09-19 3:48 ` [PATCH 1/2] " Triet Hoang
2026-09-19 16:05 ` Stefan Wahren [this message]
2026-09-19 3:48 ` [PATCH 2/2] firmware: raspberrypi: Clean up local formatting Triet Hoang
2026-09-19 16:06 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af98e96e-5a2c-486c-b8ea-3ae3fdab8eb0@gmx.net \
--to=wahrenst@gmx.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=triet.hoang.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®