From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751908AbcFBFXc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 2 Jun 2016 01:23:32 -0400
Received: from hotel311.server4you.de ([85.25.146.15]:43475 "EHLO
	hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751189AbcFBFXb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 2 Jun 2016 01:23:31 -0400
Subject: Re: Internal error xfs_trans_cancel
To: Dave Chinner <david@fromorbit.com>
References: <ab487269-a423-e3dc-6f59-3dda004960c3@monom.org>
 <20160601071047.GJ12670@dastard>
 <e80cee4f-1789-5418-ffa8-7551138bda0a@monom.org>
 <0644b434-6cea-4188-9702-469c26d191b8@monom.org>
 <20160602002653.GL12670@dastard>
Cc: linux-fsdevel@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        xfs@oss.sgi.com
From: Daniel Wagner <wagi@monom.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <af997005-e144-5509-885c-a688562ea3ec@monom.org>
Date: Thu, 2 Jun 2016 07:23:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <20160602002653.GL12670@dastard>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> posix03 and posix04 just emit error messages:
> 
> posix04 -n 40 -l 100
> posix04: invalid option -- 'l'
> posix04: Usage: posix04 [-i iterations] [-n nr_children] [-s] <filename>
> .....

I screwed that this up. I have patched my version of lockperf to make
all test using the same options names. Though forgot to send those
patches. Will do now.

In this case you can use use '-i' instead of '-l'.

> So I changed them to run "-i $l" instead, and that has a somewhat
> undesired effect:
> 
> static void
> kill_children()
> {
>         siginfo_t       infop;
> 
>         signal(SIGINT, SIG_IGN);
>>>>>>   kill(0, SIGINT);
>         while (waitid(P_ALL, 0, &infop, WEXITED) != -1);
> }
> 
> Yeah, it sends a SIGINT to everything with a process group id. It
> kills the parent shell:

Ah that rings a bell. I tuned the parameters so that I did not run into
this problem. I'll do patch for this one. It's pretty annoying.

> $ ./run-lockperf-tests.sh /mnt/scratch/
> pid 9597's current affinity list: 0-15
> pid 9597's new affinity list: 0,4,8,12
> sh: 1: cannot create /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor: Directory nonexistent
> posix01 -n 8 -l 100
> posix02 -n 8 -l 100
> posix03 -n 8 -i 100
> 
> $
> 
> So, I've just removed those tests from your script. I'll see if I
> have any luck with reproducing the problem now.

I was able to reproduce it again with the same steps.