From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A412741AC for ; Fri, 5 Dec 2025 22:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764972939; cv=none; b=VVGd6G7sjgWsJx+ya95ahCJQEewrzLXhepSzc8PpJ88CDqvSKP7EP3y+ElVwt7y0oj57rrQGK7UhBrO7TL1pTRV+tvKNcVVVH+l9jShid3XMeRGywIvHwWUyIIaGYHwmXgcjf0Sm2UgLfzder/OuBrEXk4wi8YwMi1zg6I8pW3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764972939; c=relaxed/simple; bh=7X41fbLYfu+EcYRq36QSEwVo5LR+kjMVbPmtO2P6Jb8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mjNiP2xfjyqVvJQtTfQ6iFoorUeqgb66VtIVEUtD8fbkMcsTWSbY/YQcUFOmCL/ku3bU3BxdkjNzOj/n1+JFvkgMD2pVHiNY9q9fJXpPRab+AcK72WRdBN74jhbWsCXOk/Q6R6DETqi0niYJBAqbw6yklo0hCJv839kghS3Hi1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jz+Ae4nl; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jz+Ae4nl" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47798ded6fcso20646425e9.1 for ; Fri, 05 Dec 2025 14:15:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764972936; x=1765577736; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5v6uADHyrPwoSXxbUmXf8HVGm6kBMdxAZOGM1duysCo=; b=Jz+Ae4nlcgmkrs+fx8HudxSMP6t02gI45+nyT9aifnAalIOEStDXvPcgA5Whtfxmdp K4XVN420r1A8wYbH8YmQ5ASn7auLnpGWRh5KZmmZc0mLCykbtBLHyR4qMMn8MfgQ/KRx 2a356+8EXkm9ItGAe69+fgNP2SF3j6i8fapnI3NJF3Z0VNYNKHEtFdrMWSIxPuEwnvfd CdgjrKub7fKtm8FOEbnPnCG+hKBZiTNPdBUWGIUVmPGNDoY/ok8I6MJcdpuUM6OmiqIo JlwRB0Rnoyw8615E3YPAJHubWEx+QRsz8ZGqA0bI74JQrYwvmqKFfisIpjhmevo3I3Z/ zhPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764972936; x=1765577736; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5v6uADHyrPwoSXxbUmXf8HVGm6kBMdxAZOGM1duysCo=; b=LPgXdH8iN2CVsH32bHx0WEsYAG8tUi6g1DTt0nnHdE255YZ3TQWCOu7rU7FfXGNW8Z ZaU6gcN7dKNEmr/YwlbtSyR+8DlTotY8MwFr+PTHwMTx2/ySL1aQVSJ3/sOfSHq+sGwt MnEdsfTD4HgntY+bD8GjYnjJMdkQ0RcAgVrz2STfQTgLmAsHYWc24DVr9tpHxXNsEXk1 lBA2h0abKN2OZI7BfjRa0S03jhnlzp+hHJtUYOGxP6FSfmcUqtdL6m03oJrY6ozn8fxu P2vgaoKbJgihiy+ula1OF44txVkuMd5dHE5MgCMTMd51FUMTnBl+lpiqy18P6yPfcxSC jXow== X-Forwarded-Encrypted: i=1; AJvYcCVJUUEHRPiQbefJV+khsnIV5KArnz2zDXI4nVTukKNO3m8ackvSvPyy2VwzDtvcPNmYjGP/QWRLt1fQcOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz26+W8v0JPf4KtZgAwufAcduSz8MEjTO6wI2YgYZWcWD1NoucR og7IJHdz83OfS2obVaHhVAFdFBO07nnOHZaxml/ghV9HPzSN7OS68dOm X-Gm-Gg: ASbGncvyAqqOWa5N9WaJmj90x/Fx1p9xJAZ404Xx3q51yDjpHpXp2SCN2Iglt8vvn/0 yUs19MNy9/IQyx6fvwjOMuNnDaL35uKHX6yrRArw6R6wybMa6qVrPP7JVcXZJ2NzgPSV8iyAUyF 1VJAbQmmZ9tRL51XlBFQFifWf0ioplHqK7viUbSLF2MmzS2xz83kHRfquTWVf1nbb8mmgSEyZiq 1FqsiOm6q47N+FH/QE49jrcU8ylon3x3n6FjH+vhtGHC3h6Nr5XCANMSEG2e+TIbbPyKq+R4un8 dEMtTXwOetjM3t7mN0EbjWoAKTMeYS9sXIX7ZJVyAxCUiFgeWcbNMqdQnCnzJ6zsZtsGN/DAjmn /VxisE0dvxhtfHGO4Kr7mRuV8VSYCbz+8z8/Kv+fWbmMUOq1UBA4uRxNIjSNfH5InMjbzIGj8Yy aSBmdfms7lbQsAyCxT7wCT8xKKSvq3fAeQmdc6ZKS2U7Ouffp701KuUo54BpHLTXEC85p7uYMAp J6iz7mMCFoi X-Google-Smtp-Source: AGHT+IGr0mJ0TQEJhtTmxbJJqr1Gb9Tqe8as+0pV6SSOhQvHyMjjnnr6lXkpXvUuRzvQDw1saw/9CA== X-Received: by 2002:a05:600c:4fd6:b0:471:1765:839c with SMTP id 5b1f17b1804b1-47939e1e42fmr5286815e9.20.1764972935942; Fri, 05 Dec 2025 14:15:35 -0800 (PST) Received: from ?IPV6:2a02:6b6f:e750:1800:450:cba3:aec3:a1fd? ([2a02:6b6f:e750:1800:450:cba3:aec3:a1fd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42f7d222491sm11419404f8f.22.2025.12.05.14.15.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Dec 2025 14:15:35 -0800 (PST) Message-ID: Date: Fri, 5 Dec 2025 22:15:34 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] mm: Change the interface of prep_compound_tail() Content-Language: en-GB To: Kiryl Shutsemau Cc: Andrew Morton , Muchun Song , David Hildenbrand , Oscar Salvador , Mike Rapoport , Vlastimil Babka , Lorenzo Stoakes , Matthew Wilcox , Zi Yan , Baoquan He , Michal Hocko , Johannes Weiner , Jonathan Corbet , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20251205194351.1646318-1-kas@kernel.org> <20251205194351.1646318-2-kas@kernel.org> <77d1911d-7b67-41c0-933e-b2a0810cf3b4@gmail.com> From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/12/2025 22:10, Kiryl Shutsemau wrote: > On Fri, Dec 05, 2025 at 09:49:36PM +0000, Usama Arif wrote: >> >> >> On 05/12/2025 19:43, Kiryl Shutsemau wrote: >>> Instead of passing down the head page and tail page index, pass the tail >>> and head pages directly, as well as the order of the compound page. >>> >>> This is a preparation for changing how the head position is encoded in >>> the tail page. >>> >>> Signed-off-by: Kiryl Shutsemau >>> --- >>> include/linux/page-flags.h | 4 +++- >>> mm/hugetlb.c | 8 +++++--- >>> mm/internal.h | 11 +++++------ >>> mm/mm_init.c | 2 +- >>> mm/page_alloc.c | 2 +- >>> 5 files changed, 15 insertions(+), 12 deletions(-) >>> >>> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >>> index 0091ad1986bf..2c1153dd7e0e 100644 >>> --- a/include/linux/page-flags.h >>> +++ b/include/linux/page-flags.h >>> @@ -865,7 +865,9 @@ static inline bool folio_test_large(const struct folio *folio) >>> return folio_test_head(folio); >>> } >>> >>> -static __always_inline void set_compound_head(struct page *page, struct page *head) >>> +static __always_inline void set_compound_head(struct page *page, >>> + struct page *head, >>> + unsigned int order) >> >> I can see that order is used later, I think patch 4, but probably this patch might cause a >> build warning as order is unused? Might be good to integrate that into the later patch? > > Is there warning for unused function parameters? ah I havent tried actually building, but I thought unused args would complain. If it doesnt, should be ok. > > I think it will blow up whole kernel, no? > >> Other nit is, do we want const for head here? (Its not there before, but might be good to add). > > Sure, can do. >