From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5695837882A for ; Wed, 29 Apr 2026 21:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497921; cv=none; b=sC7duAI53layo2+I3Es4AFQAgjX2ecMvJl3euSqrI7cbaSu4nneNxQuqNSr8tDS6XAvbXVlt5nUYkodmFLDS/0tioNBkbFBalWooRWhQQkWBvjRRsi4fGMF5eyI5xrnw4Zhcab87ajYEwUJJGjDGwcxO8InlGXtkaFEZao0qQkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497921; c=relaxed/simple; bh=Wu1Paw5c9CwP/MnjnA1atBgjzNoQlrQ79eV4DD9g4v8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WsLeICBaHWeC/l8x99e3iSgSY6o7nuoDhgWZ/1eM7x5aBB5UYYNTbMjMg6SXqqoLgQbtpanAMKQhPo/Vw/hlrN3PJaFygQZ0KE2Vpb5tttinw8Qxm4zvJLk9X+GXgexHX9n7X3d50BHNM7IPVDCgYUJHY3v9mTbYfO5bOzSMwv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=kK5SOO+t; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="kK5SOO+t" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso1644105e9.3 for ; Wed, 29 Apr 2026 14:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777497918; x=1778102718; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O1TG/Zd6POOLHsO7mW5uEu5sOZGfXHwcvlSHYjb8ZeQ=; b=kK5SOO+tMoYixHCn/3zlnI0N6G6hbvQvTWIMTDdH7Gm1BFWGcFcojWZUeS1uDPVPRO ooqTueOVDul0N6yPCjTWBWNsZ5fy5RCXwnjLHgykAnZqP/ZrIiXlkw09hlIBfS5ZHg7O /odeIDm2Zhx/h598vP0tJHJw3tYACpd61HTh+m/PUCdivuB9+WZBxsrDN1O0AKwYV3QW bBd7k2cXf8vSz0Akpxe0RXMwRW5XFSAVmTioxFOyfrcIiwqUwczFBsbbgGrYGXvuWLaO T0iJCWw3C35C9LLx38RovGebtCz/fI5kF3rdlQjWe7TtsB+KvddMYh4hiuoNpdj4R3q6 urwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777497918; x=1778102718; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O1TG/Zd6POOLHsO7mW5uEu5sOZGfXHwcvlSHYjb8ZeQ=; b=sFOrTb6eMaIppbSDBwku9J0YXH5sy07hKRysqVNfA4qxq9UHqwbUsiKAWKyPdbbtwM 5kuICQjyi5ZtybfD7dLDo9Zf69EBciZsj8qk+cGAp9pyImud90clLNmAxFkamxQ8ryOF 8lPwSH7mn2g1BgusOmhzy22FIvzDXye6pZMKM0JLkiKVtObvsVmbAko7kPB7F7dzs0e0 TlFIjUAcIf0Z80hdCF2jfQbk/YzlC7iJZrb7kMr5wWziQp12NyBYfNlEPAJ/llOCTMzq Rge3C3uvccRraT/+9LgMZqsVW92KyckQgdJ8IsY/ThwIP7kKmiqQtfYUAvkNEDpo2LDG YkwQ== X-Forwarded-Encrypted: i=1; AFNElJ+ad0wDwHPU64haZDftaAK5q9N5ocQQNMjyxUjAeCbDqaGUNUNzM2hIdIq4G3az7FhMX4uGKoram8uy4WQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzOaxD9a/eP/QgmA+Vt456dXdnZIIArUQVoE1pASWUaEWCm5VSX S4tIyfHO3A5VFmB1qItq/rAQFZaiajQejyQzMyXGRVMjOSmHWjuBas0iI5uIMmRIkl4= X-Gm-Gg: AeBDieuu+Pp5NcVCkybRYF7C5B9/MGIpd8VMXPEUFjnhsWTq5ZHXhM0iz/A3wzh8uj+ PXw5lMchwkV7tqYfjWAprT4E42GKJ3870Kuuk9zj5cz5Ge2zU9wLt/yh/DA2u+HX56V2AawYnWc H3wrwwpBab5rlQP+pk+Bfkz/b4zotZVTOQ3fIv56Mne6oHDK7GjXBw2RavN5qw+URNntX3ftcgC 4NShN7g12TvOMKVIqibH0wxrd264OKDAKZfmXhgY+CQGi96gWWQX7XvKggG1J4qXP3eRjEwJo4j 0pq8rL5pbA3nKT02BwERtnYgH4OXlNiE8nJn8HiaUTI7keDteAXNt70sUNqnrB6DE/0zrnmZPqL eJ6E9LWLqNX4RDzYzIzZ0CQQZStljjHNo9mgyZU93NY9VGgxVldMA9r4WZ8tbT3TVhAsSkzBi2s QQPzXxYIEfnAT8w5oAJXfMA2Iss9pVwM+dRmTg25s= X-Received: by 2002:a05:600c:a411:b0:485:3ec6:e634 with SMTP id 5b1f17b1804b1-48a8444159emr3159695e9.15.1777497917737; Wed, 29 Apr 2026 14:25:17 -0700 (PDT) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a822d4a9asm19299495e9.14.2026.04.29.14.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 14:25:17 -0700 (PDT) Date: Wed, 29 Apr 2026 23:25:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Lee Jones Cc: Peter Tyser , linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: Re: [PATCH] mfd: Consistently define pci_device_ids using named initializers Message-ID: References: <20260429170652.4178050-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="idxlqbjrw53yjhe5" Content-Disposition: inline In-Reply-To: <20260429170652.4178050-2-u.kleine-koenig@baylibre.com> --idxlqbjrw53yjhe5 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] mfd: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello, On Wed, Apr 29, 2026 at 07:06:51PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > The various struct pci_device_id arrays were initialized mostly by one > of the PCI_DEVICE macros and then list expressions. The latter isn't > easily readable if you're not into PCI. Using named initializers is more > explicit and thus easier to parse. >=20 > The secret plan is to make struct pci_device_id::driver_data an > anonymous union (similar to > https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre= =2Ecom/) > and that requires named initializers. But it's also a nice cleanup on > its own. >=20 > This change doesn't introduce changes to the compiled pci_device_id > arrays. Tested on x86 and arm64. >=20 > Signed-off-by: Uwe Kleine-K=F6nig (The Capable Hub) > --- > Hello, >=20 > the mentioned follow-up quest allows to do >=20 > - { PCI_VDEVICE(INTEL, 0x02a8), .driver_data =3D (kernel_ulong_t)&spt_ua= rt_info }, > + { PCI_VDEVICE(INTEL, 0x02a8), .driver_data_ptr =3D &spt_uart_info }, >=20 > which gets rid of a bunch of casts and so brings a little bit more type > safety. This patch is a preparation for that. >=20 > I assume a single patch for all of drivers/mfc is fine. If not I can > split per driver. Oh, it seems I got my mailtracking wrong and sent this patch twice with only slightly changed commit log. The commit log of this one is slightly better, but if you pick the other one that's fine, too. Sorry for the confusion, Uwe --idxlqbjrw53yjhe5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmnydzgACgkQj4D7WH0S /k4PkQgAo9fC9bIzcavvQjXlJ+QG7zZflgwcL5BQi/weW55k8sHkCsqcmnOrHFyf Mu2qU3HKKPMg8yPLXU+dQ8jdjlaRtUdccZ+BBX7sphEue0b8TDValJ5r7wMpy40y 7BiwLPeazbzXl5h8CLS1h7B0/OH1lmwIOlPtF1pgfb4DV4NQjZbLQSR7PJAfNPLs RjXM28MqA2ra5CrCfyCLvaePBa67UOd0zXFSkkrxaeFCcJkgGO5+3qDYL1+q0nOA McFCUJhy/nArpAPS5MGIAZsq9xFMNlSyoA/ekPdybdDBkl4KbgIkjGGxeHILPpkG lT6x5GdVf12i9U12G4dMP8A7RnmN3w== =B5Mh -----END PGP SIGNATURE----- --idxlqbjrw53yjhe5--