From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 203B936C0AB for ; Wed, 22 Apr 2026 07:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776842647; cv=none; b=UVCN5VCkF6fNopCUh0782/kxwvM+4ow1fvOlcly8Yo+98XX2N9R9kcO/N7qOHrEcvCincL9jLpJzq2fxL/h9IZLll6a9M2M7SpQX13RD6HBeYy8NAvTLxrpOZTF2gTlwcOrzkJN4J+vyRZhNjlS6t4WNPUihsLz8eynmIIKfF1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776842647; c=relaxed/simple; bh=ZXbH5y+tWJ9XW57g5zlTICCqaN8g6RgnO2K9CStQ9Zc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nmS9/tjIT5b3JhShSTgHZ65o8/Cu1gXA1kOxQz+BvegdH6HFArEbhI8Un8wEZP7q5tgZzO1rQ3BEfYft0TBDNlqnWf2MNosUWauG5m5ICbleuKoBfLZy4mQez6Ll6wZVgzpjc0AKkPsAAxY6dojGCiLwNqQvX97k/qCwIXFSPN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pIltHJMd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WnAMJE2V; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pIltHJMd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WnAMJE2V" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63M4eL8U3083047 for ; Wed, 22 Apr 2026 07:24:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OsMFhzh9B9P04QQ52S0OECWBliG0c1fRkWxIyLVs8XA=; b=pIltHJMdN3HD7r2R cLYp8qGwpb96c1WnPoNi1S+D7MIVT+WdXbU+U/p7zkDoIESf+uRidspEA9exmfCJ 4D1YBXa3lQ5+fv//c338B7ox9SGDkTKoab1pnpEnXqiq9mA1n+BDvNLQBAHq20s6 EbuzFclDYN4eWtb/ZwwC1CgD3Vzs1Ps92cD5OjaF8G8XMTh/XJfTwEr+XPt/r2lR qwz/9KmgtxofsTtfsiVk3qF22hT902z7vhff1555rLQaXSdU5WDxS+whx/7urkXE 9S83QqIBBjGULOZkE7/88l8mm7FeG9wUnSHLECdC0lECX0XxIq0VrSSJajXbstmm j6dXkw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dpenmj9qe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Apr 2026 07:24:04 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b2ec17dc21so58260245ad.2 for ; Wed, 22 Apr 2026 00:24:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776842529; x=1777447329; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OsMFhzh9B9P04QQ52S0OECWBliG0c1fRkWxIyLVs8XA=; b=WnAMJE2V8aWfvvcYkFEKhySxBpzocncBXflEphSuLVph+HFxBGIQ58S4G+WWHg0oSf 3LO/03U3U1w19vvEVyEWnRzIC5H6Lo21mxZppfAEaXADg53mK4YlKzEUh7WTQwFnX0uI ETiJRIimir0wBVncKD07iLDBG+8edgx2b3hNiKkFvSvyfq+/ESRAD/AzptoXuaDts9Co 7dbx/X6boZ3AciD7Yp84+Dt8erUv/bP6b6jzXrz8/iel/gy+PkLB4wjKtXF7I5YKwxL2 AiAAUuAl+Zrhc8vB4qSQZtiJbotVoEQV7xi2QP8zN/23JDy7dubmT5yZ7IUwwpwbucrw G4FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776842529; x=1777447329; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OsMFhzh9B9P04QQ52S0OECWBliG0c1fRkWxIyLVs8XA=; b=exteQ6ICZCjd79t48D6y7an1VKNNxr/py4RcbBRMqcI82RwIj2cZ7DNZiPeN0j4Div r0+Ib91EddK7u2qMyj1Qao6BxdYhjdnSCILF/TNaBp+pQUOQ0m3IZMVd0SIcBVJJs6PL 7S5RHAmOhoPL1Mi4HjZYR5GJA/zk96svIFxi3Wr+d9PpP5aT+omUVMBf5rAfRf8XyiS+ 0eYXZVJoc4pzwkiyboF0n+TKV2IwrTiEI+riQgUAPVa/3SfV780331rM7uNlSau+rqbr 0Xr4F/UtEncyaW6LbN07F4ND9RRAd/E+JMU3ZKSKnjiq7OFfPsxv6kiHRJEwgJZxkJVr HnYg== X-Forwarded-Encrypted: i=1; AFNElJ/sxUPyp1hVYvVQ+m8jYlPawOQgJKPqhUMxGJvdO+7xFxh5ItP8CUeVKjdo/fLYEBo8r5WrOsrttbWuCwI=@vger.kernel.org X-Gm-Message-State: AOJu0YxAVsmdR+pPf6vJq6XYhC4c8bW0Yg1V9mGfP0t3Q7L8cWAWS9w8 xoedIr3NDSsiG8DaGLBV+jBS7NZcGk6TW+ZBjWhBIpSRexP4WyUfS99rzlZn6tmi6AKU/AimcDM BF6Rw/2oOV1Hz5MgfCDPCfULJe4/ETEc5Qif938IPAj8SViAwPNKLW6btH7K7YLvMOzs= X-Gm-Gg: AeBDieuKYqF1R79BC275QRuQxceyNv2+zegYbvx9Tzi0e0lJ4vm3Jt94ORuanvkybC6 oBrtMjX3uKIaz76ZSJoswfGZSCA9Kt1ZrA1dQ/k8G+aq2inYllDoa4NgUdZ1qrJ3XlSK8YdLLJ2 vVKo3hYJNrZs41JV75wA3fpnbUJ0xFp62o9KvXEv0Yct5Cas+rpOszTLbt6l48cdI3YbSIJhb7A GgUxlaEytdzQm/S+K2rh7VR8UeOSDc8GSCEl0Feew4SxCRgIissyGYTMJqUnSf3uY3w1xiF432P L/EzZM0TjXu0l0x7xrk5v9qeqWmnY8QGDgMeN7++AREhmnsxR58j6KEsg3NvUU6Ft7k0PKLjSAS 6DLK+2Dd/2Wynd950bn7RHsvh4EFCBG4D3UYU/BolpMCbkrLlP7hwhJycC9ZBr+hwAZTo3yEr X-Received: by 2002:a17:903:2c5:b0:2b2:4697:4370 with SMTP id d9443c01a7336-2b5f9e8cac7mr219783425ad.3.1776842528670; Wed, 22 Apr 2026 00:22:08 -0700 (PDT) X-Received: by 2002:a17:903:2c5:b0:2b2:4697:4370 with SMTP id d9443c01a7336-2b5f9e8cac7mr219783075ad.3.1776842528163; Wed, 22 Apr 2026 00:22:08 -0700 (PDT) Received: from [10.152.199.23] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fa9ff409sm195396035ad.14.2026.04.22.00.22.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Apr 2026 00:22:07 -0700 (PDT) Message-ID: Date: Wed, 22 Apr 2026 12:52:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] ath11k: fix peer resolution on rx path when peer_id=0 To: Matthew Leach , Jeff Johnson Cc: Baochen Qiang , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20260417-ath11k-null-peerid-workaround-v3-1-d04302284486@collabora.com> Content-Language: en-US From: Rameshkumar Sundaram In-Reply-To: <20260417-ath11k-null-peerid-workaround-v3-1-d04302284486@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: GomfiwtJ33cKlv-LoNu0BEbIXRTaIkQu X-Proofpoint-ORIG-GUID: GomfiwtJ33cKlv-LoNu0BEbIXRTaIkQu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIyMDA2OCBTYWx0ZWRfX1MhvLO4X8sSX DF/1zBup0crMxEB8IgwdnxCJWDoNczkIbI8r/sj2gs6hNaKyakcO0nbJUtV54VV3NnJCInyRQvK aEqzel4UgX3kB7Sm7ry7M2pwsczU0bg2ttwhaNUcAsC4JCqBEgwuN1Su8zF80KPSXE9aW0lheza ou/2l6muySQFfU30pPUSrHL44DC29JkQV5wCYsSO+sD8KLgBJRZK3vjGSNIPFpmEyVx+OjTNxtw 9yU/Ya7Vim2LsvxQawH154dYav5aQU29IgFOAe+LUn2Y7kQnH8wXHOsT/hBnT238vAWsQNLNaRz iyZHMjlTFLF1Wbnr85sxFI4xT4SGSED8F75zM0fvHMc+1d3xKgEojbajpyA4DYUfWJ/lKF6dy3N Uz9nE46W+lYsDudtZuzxeJ69sRaXRBHT4UylscEDD7d5MGQ8dOR5wHBVpnml+c9l844HWv4x3SJ DcFnlGnZdxxCMRnNmtQ== X-Authority-Analysis: v=2.4 cv=Xd65Co55 c=1 sm=1 tr=0 ts=69e87794 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=i3rc2wEZqLSP7JN4NF4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604220068 On 4/17/2026 4:37 PM, Matthew Leach wrote: > It has been observed that on certain chipsets a peer can be assigned > peer_id=0. For reception of non-aggregated MPDUs this is fine as > ath11k_dp_rx_h_find_peer() has a fallback case where it locates the peer > based upon the source MAC address. On an aggregated link, the mpdu_start > header is only populated by hardware on the first sub-MSDU. This causes > the peer resolution to be skipped for the subsequent MSDUs and the > encryption type of these frames to be set to an incorrect value, > resulting in these MSDUs being dropped by ieee80211. > > ath11k_pci 0000:03:00.0: data rx skb 000000002f4b704d len 1534 peer xx:xx:xx:xx:xx:xx 0 ucast sn 3063 he160 rate_idx 9 vht_nss 2 freq 5240 band 1 flag 0x40d1a fcs-err 0 mic-err 0 amsdu-more 0 peer_id 0 first_msdu 1 last_msdu 0 > ath11k_pci 0000:03:00.0: data rx skb 0000000038acd580 len 1534 peer (null) 0 ucast sn 3063 he160 rate_idx 9 vht_nss 2 freq 5240 band 1 flag 0x40d00 fcs-err 0 mic-err 0 amsdu-more 0 peer_id 0 first_msdu 0 last_msdu 1 > > Remove the null peer_id checks in ath11k_dp_rx_h_find_peer() and > ath11k_hal_rx_parse_mon_status_tlv(), allowing peers with an assigned ID > of 0 to be resolved. > Please add a Fixes: tag, since this addresses a real RX-path bug. At least the dp_rx.c change seems to trace back to 2167fa606c0f ("ath11k: Add support for RX decapsulation offload"). Please also use the usual wireless subject prefix, e.g. wifi: ath11k: fix peer resolution on rx path when peer_id=0 It would also be useful to add a Tested-on: tag if this was validated on affected hardware, as suggested in the ath11k submission guidelines.