From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Yue Haibing <yuehaibing@huawei.com>, "clm@fb.com" <clm@fb.com>,
"josef@toxicpanda.com" <josef@toxicpanda.com>,
"dsterba@suse.com" <dsterba@suse.com>,
"mpdesouza@suse.com" <mpdesouza@suse.com>,
"gniebler@suse.com" <gniebler@suse.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs: Fix passing 0 to ERR_PTR in btrfs_search_dir_index_item()
Date: Tue, 22 Oct 2024 07:16:17 +0000 [thread overview]
Message-ID: <afa71ba0-8029-44b1-90fe-c8e45bb02657@wdc.com> (raw)
In-Reply-To: <4cefb5b1-648b-58f6-abd7-d3cabfe507ec@huawei.com>
On 22.10.24 08:53, Yue Haibing wrote:
>> and then set it to ENOENT if it is NULL. So it should be
>>
>> if (ret >= 0)
>> ret = -ENOENT;
>> return ERR_PTR(-ENOENT);
>
> Here should be
> return ERR_PTR(ret);
Yep of cause.
prev parent reply other threads:[~2024-10-22 7:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-19 9:23 Yue Haibing
2024-10-21 8:25 ` Johannes Thumshirn
2024-10-22 3:22 ` Yue Haibing
2024-10-22 6:37 ` Johannes Thumshirn
2024-10-22 6:53 ` Yue Haibing
2024-10-22 7:16 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa71ba0-8029-44b1-90fe-c8e45bb02657@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=gniebler@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®